Skip to content

Replace FullScreenLoadingIndicator with ActivityIndicator in LoadingPage#84798

Merged
stitesExpensify merged 1 commit intomainfrom
claude-useValidLoadingIndicatorInLoadingPage
Mar 12, 2026
Merged

Replace FullScreenLoadingIndicator with ActivityIndicator in LoadingPage#84798
stitesExpensify merged 1 commit intomainfrom
claude-useValidLoadingIndicatorInLoadingPage

Conversation

@MelvinBot
Copy link
Contributor

@MelvinBot MelvinBot commented Mar 10, 2026 •
edited by Julesssss
Loading

Explanation of Change

LoadingPage.tsx renders HeaderWithBackButton alongside FullScreenLoadingIndicator. As part of the loading indicator standardization (#69850), shouldUseGoBackButton will soon default to true in FullScreenLoadingIndicator, which would cause users to see two back controls — the header back button AND the Go Back button from the loader.

This PR replaces FullScreenLoadingIndicator with a View wrapping a plain ActivityIndicator, using the existing fullScreenLoading style to maintain pixel-perfect visual parity (same background color, opacity, centering, and spinner size). This pattern matches the established convention used in HelpContent.tsx.

Fixed Issues

$ #84590
PROPOSAL: #84590 (comment)

Tests

  1. Navigate to a page that uses LoadingPage (easiest is Private Notes, accessed after clicking profile in a dm chat)
  2. Verify the loading spinner appears centered with the same background color and opacity as before
  3. Verify the header back button works correctly
  4. Verify no Go Back button appears in the loading area
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

  1. Navigate to a page that uses LoadingPage (easiest is Private Notes, accessed after clicking profile in a dm chat)
  2. Verify the loading spinner appears centered with the same background color and opacity as before
  3. Verify the header back button works correctly
  4. Verify no Go Back button appears in the loading area
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — visual-only component swap, no layout change

Android: mWeb Chrome

N/A — visual-only component swap, no layout change

iOS: Native

N/A — visual-only component swap, no layout change

iOS: mWeb Safari

N/A — visual-only component swap, no layout change

MacOS: Chrome / Safari

N/A — visual-only component swap, no layout change

@MelvinBot @Julesssss
Replace FullScreenLoadingIndicator with ActivityIndicator in LoadingPage
b0d15fa 
LoadingPage already renders HeaderWithBackButton, so using
FullScreenLoadingIndicator is unnecessary and will cause duplicate
back controls once shouldUseGoBackButton defaults to true.

Replace with a View + ActivityIndicator using the same
fullScreenLoading style to maintain pixel-perfect visual parity.

Co-authored-by: Jules <Julesssss@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 10, 2026 21:16
@MelvinBot MelvinBot mentioned this pull request Mar 10, 2026
Open
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Sign in to view
@MelvinBot

This comment was marked as off-topic.

Sign in to view
Julesssss
Julesssss approved these changes Mar 10, 2026
View reviewed changes
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on web adhoc. Loading indicator remains in center

@Julesssss
Copy link
Contributor

Julesssss commented Mar 10, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Julesssss Julesssss marked this pull request as ready for review March 10, 2026 22:08
@Julesssss Julesssss requested a review from a team as a code owner March 10, 2026 22:08
@melvin-bot melvin-bot bot requested review from heyjennahay and stitesExpensify and removed request for a team March 10, 2026 22:08
@melvin-bot
Copy link

melvin-bot bot commented Mar 10, 2026

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Julesssss
Copy link
Contributor

Julesssss commented Mar 10, 2026 •
edited
Loading

@stitesExpensify I don't have a screenshot but verify this UI test. This was a test issue for a large refactor. I'll have a C+ review for the remainder.

@codecov
Copy link

codecov bot commented Mar 11, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/LoadingPage.tsx 0.00% <0.00%> (ø)
... and 10 files with indirect coverage changes

@situchan
Copy link
Contributor

situchan commented Mar 11, 2026

I'd like to be C+ reviewer for the remainder if needed

@Julesssss
Copy link
Contributor

Julesssss commented Mar 11, 2026

Bumping review @stitesExpensify

@stitesExpensify stitesExpensify merged commit 6133407 into main Mar 12, 2026
57 of 59 checks passed
@stitesExpensify stitesExpensify deleted the claude-useValidLoadingIndicatorInLoadingPage branch March 12, 2026 18:53
@OSBotify
Copy link
Contributor

OSBotify commented Mar 12, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

🚧 @stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84798.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6133407-fda79d3-c5a61c9e34c7159e233bbaf3fdc066fd347507e3/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6133407-fda79d3-183a6d3a16b3ac0bcb4c000e6d76ad130e1d3544/index.html
Android iOS
Web 🕸️
https://84798.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Mar 12, 2026
Closed
87 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Mar 12, 2026

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.3.37-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 16, 2026

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@situchan situchan mentioned this pull request Mar 17, 2026
Merged
52 tasks
@situchan situchan mentioned this pull request Mar 17, 2026
Merged
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Julesssss Julesssss Julesssss approved these changes

@stitesExpensify stitesExpensify stitesExpensify approved these changes

@heyjennahay heyjennahay Awaiting requested review from heyjennahay

Assignees

@Julesssss Julesssss

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MelvinBot @Julesssss @situchan @OSBotify @stitesExpensify