Skip to content

Add 434 to broken connection ignored statuses for card feeds#84803

Merged
deetergp merged 7 commits intomainfrom
claude-fixChaseCardFeedBrokenState
Mar 11, 2026
Merged

Add 434 to broken connection ignored statuses for card feeds#84803
deetergp merged 7 commits intomainfrom
claude-fixChaseCardFeedBrokenState

Conversation

@MelvinBot
Copy link
Contributor

@MelvinBot MelvinBot commented Mar 10, 2026

Explanation of Change

NewDot incorrectly marks the entire Chase company card feed as "broken" when individual cards have error 434 ("account not found"). This is a card-specific error (e.g., a closed/removed bank account) that should not cause the feed-level broken connection UI.

Changes:

  1. Added 434 to BROKEN_CONNECTION_IGNORED_STATUSES in CONST/index.ts so card-specific "account not found" errors no longer trigger the feed-level broken connection state.
  2. Updated getFeedConnectionBrokenCard() in CardUtils.ts to use the same BROKEN_CONNECTION_IGNORED_STATUSES allowlist instead of a hardcoded !== 200 check, ensuring consistency with isCardConnectionBroken().

Fixed Issues

$ #83372
PROPOSAL: #83372 (comment)

Tests

  1. Set up a workspace with a Chase company card feed
  2. Have a card in the feed with lastScrapeResult = 434 (account not found)
  3. Verify the feed is NOT shown as "broken" (no red dot, no "Card feed connection is broken" banner)
  4. Have a card with a genuinely broken status (e.g., lastScrapeResult = 403)
  5. Verify the feed IS correctly shown as broken for that case
  • Verify that no errors appear in the JS console

Offline tests

N/A — this change only affects how scrape result statuses are classified. No network requests are made or modified.

QA Steps

  1. Find a workspace with a Chase company card feed where one or more cards have lastScrapeResult = 434
  2. Verify the feed is NOT marked as broken (no red dot on workspace sidebar, no "Card feed connection is broken" banner)
  3. Verify that feeds with genuinely broken connections (non-ignored status codes) still correctly show the broken state
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — logic-only change, no UI modifications

Android: mWeb Chrome

N/A — logic-only change, no UI modifications

iOS: Native

N/A — logic-only change, no UI modifications

iOS: mWeb Safari

N/A — logic-only change, no UI modifications

MacOS: Chrome / Safari

N/A — logic-only change, no UI modifications

@MelvinBot @carlosmiceli
Add 434 to broken connection ignored statuses for card feeds
b51fb08 
Card-specific error 434 (account not found) should not mark the entire
feed as broken. Also align getFeedConnectionBrokenCard to use the same
BROKEN_CONNECTION_IGNORED_STATUSES allowlist for consistency.

Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 10, 2026 21:37
@MelvinBot MelvinBot mentioned this pull request Mar 10, 2026
Open
@carlosmiceli carlosmiceli marked this pull request as ready for review March 10, 2026 21:47
@carlosmiceli carlosmiceli requested a review from a team as a code owner March 10, 2026 21:47
@melvin-bot melvin-bot bot requested review from JmillsExpensify and situchan and removed request for a team and JmillsExpensify March 10, 2026 21:47
@melvin-bot
Copy link

melvin-bot bot commented Mar 10, 2026

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 10, 2026 21:47
github-actions[bot]
github-actions bot reviewed Mar 10, 2026
View reviewed changes
@MelvinBot @carlosmiceli
Reuse isCardConnectionBroken() in getFeedConnectionBrokenCard()
5ede693 
Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team as a code owner March 10, 2026 22:33
@melvin-bot melvin-bot bot requested review from carlosmiceli and removed request for a team March 10, 2026 22:33
@melvin-bot
Copy link

melvin-bot bot commented Mar 10, 2026

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot @carlosmiceli
Fix: Prettier formatting in CardUtils.ts
000d8ef 
Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

MelvinBot commented Mar 10, 2026

Fixed the failing Prettier check: the callback in getFeedConnectionBrokenCard() in src/libs/CardUtils.ts needed to be collapsed to a single line per Prettier's formatting rules.

@codecov
Copy link

codecov bot commented Mar 11, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 93.54% <100.00%> (ø)
src/libs/CardUtils.ts 84.18% <100.00%> (+0.70%) ⬆️
... and 141 files with indirect coverage changes

@carlosmiceli
Copy link
Contributor

carlosmiceli commented Mar 11, 2026

@situchan ready for you, should be a quick one

@situchan
Copy link
Contributor

situchan commented Mar 11, 2026 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari Screenshot 2026-03-11 at 8 55 11 PM

Before:

Screenshot 2026-03-11 at 8 56 06 PM

After:

Screenshot 2026-03-11 at 8 55 22 PM

situchan
situchan reviewed Mar 11, 2026
View reviewed changes
src/libs/CardUtils.ts
}

return Object.values(feedCards).find((card) => !isEmptyObject(card) && card.bank !== feedToExclude && card.lastScrapeResult !== 200);
return Object.values(feedCards).find((card) => !isEmptyObject(card) && card.bank !== feedToExclude && isCardConnectionBroken(card));
Copy link
Contributor

@situchan situchan Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot can you add unit test for getFeedConnectionBrokenCard?

Copy link
Contributor Author

@MelvinBot MelvinBot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 9 unit tests for getFeedConnectionBrokenCard covering:

  • undefined / empty feedCards
  • card with a broken connection status (e.g. 403)
  • cards with ignored statuses only (200, 434)
  • cards with no lastScrapeResult
  • feedToExclude filtering
  • empty card objects being skipped

All tests pass locally (da2d66f).

@MelvinBot @situchan
Add unit tests for getFeedConnectionBrokenCard
da2d66f 
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@carlosmiceli
Copy link
Contributor

carlosmiceli commented Mar 11, 2026

@MelvinBot fix failing tests

@MelvinBot @carlosmiceli
Fix typecheck: use 'as unknown as Card' for partial test objects
ad49add 
Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

MelvinBot commented Mar 11, 2026

Fixed the failing typecheck: the test card objects in getFeedConnectionBrokenCard tests were using as Card but were missing required properties (domainName, lastUpdated, fraud). Changed all casts to as unknown as Card to match the existing test pattern in the file.

MelvinBot and others added 2 commits March 11, 2026 14:53
@MelvinBot @carlosmiceli
Fix typecheck: use 'as unknown as Card' for partial test objects
137f922 
The test card objects are missing required Card properties (domainName,
lastUpdated, fraud), so a direct 'as Card' cast fails. Using
'as unknown as Card' matches the pattern used in the rest of the file.

Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
@MelvinBot @carlosmiceli
Merge remote-tracking branch 'origin/claude-fixChaseCardFeedBrokenSta…
fb457c2 
…te' into claude-fixChaseCardFeedBrokenState

Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

MelvinBot commented Mar 11, 2026

Fixed the failing typecheck: changed as Card to as unknown as Card on all partial test card objects in the getFeedConnectionBrokenCard test suite. The partial objects were missing required Card properties (domainName, lastUpdated, fraud), so the direct cast failed. Using as unknown as Card matches the pattern used throughout the rest of the test file.

@situchan
Copy link
Contributor

situchan commented Mar 11, 2026 •
edited
Loading

@carlosmiceli After adding 434 to ignored statuses, we no longer show broken connection error for Break connection (Testing) as its lastScrapeResult is 434. Please confirm it's expected

Screenshot 2026-03-11 at 8 57 59 PM

@carlosmiceli carlosmiceli requested a review from a team March 11, 2026 15:07
@melvin-bot melvin-bot bot requested review from situchan and removed request for a team March 11, 2026 15:07
@melvin-bot
Copy link

melvin-bot bot commented Mar 11, 2026

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@carlosmiceli
Copy link
Contributor

carlosmiceli commented Mar 11, 2026

@carlosmiceli After adding 434 to ignored statuses, we no longer show broken connection error for Break connection (Testing) as its lastScrapeResult is 434. Please confirm it's expected

Screenshot 2026-03-11 at 8 57 59 PM

Yes, that's to be expected since I believe that function is for seeing errors we should actually see in the UI.

@carlosmiceli carlosmiceli requested a review from a team March 11, 2026 15:09
@melvin-bot melvin-bot bot requested review from deetergp and removed request for a team March 11, 2026 15:09
@melvin-bot
Copy link

melvin-bot bot commented Mar 11, 2026

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@carlosmiceli
Copy link
Contributor

carlosmiceli commented Mar 11, 2026

@deetergp pulled you in to just review/merge, since I co-authored a commit here, thanks sir 🙇

@deetergp
Copy link
Contributor

deetergp commented Mar 11, 2026

@carlosmiceli Roger, wilco!

deetergp
deetergp approved these changes Mar 11, 2026
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deetergp deetergp merged commit 4e4263f into main Mar 11, 2026
31 checks passed
@deetergp deetergp deleted the claude-fixChaseCardFeedBrokenState branch March 11, 2026 20:02
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🚧 @deetergp has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84803.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4e4263f-3d8daef-099d81665ef12600a5f8ac96537ab5e10588fd80/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4e4263f-3d8daef-ae8b58dc5f8cb54e133be47276fdc45cb2f262bb/index.html
Android iOS
Web 🕸️
https://84803.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@MelvinBot MelvinBot mentioned this pull request Mar 11, 2026
Draft
52 tasks
@OSBotify OSBotify mentioned this pull request Mar 12, 2026
Closed
87 tasks
@m-natarajan
Copy link

m-natarajan commented Mar 12, 2026

@carlosmiceli @situchan @deetergp Can this one please be tested internally, We can't add Chase cards and unable to trigger connection error from our end

@OSBotify
Copy link
Contributor

OSBotify commented Mar 12, 2026

🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.37-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot MelvinBot mentioned this pull request Mar 15, 2026
Merged
53 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Mar 16, 2026

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@amyevans amyevans mentioned this pull request Mar 17, 2026
Merged
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@deetergp deetergp deetergp approved these changes

@carlosmiceli carlosmiceli Awaiting requested review from carlosmiceli

+1 more reviewer

@situchan situchan situchan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlosmiceli carlosmiceli

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MelvinBot @carlosmiceli @situchan @deetergp @m-natarajan @OSBotify