fix: Issues related to video progress and controls especially on Android by Uzaifm127 · Pull Request #84865 · Expensify/App

Uzaifm127 · 2026-03-11T10:44:47Z

Explanation of Change

In this PR, we are solving the following issues:

In Android, control bar disappears when trying to seek.
In Android, the video resumes automatically when holding the progress bar for few seconds.
If the control bar is fading out and the user starts seeking, controls are hiding in between the drag and seek ends at the wrong position.
In Android, If the video is paused and we seek the progress bar then the video starts to play if it was paused.

Fixed Issues

$ #82026
PROPOSAL: #82026 (comment)

Tests

Open the app (Android preferred).
Go to Inbox tab.
Open any DM chat.
Add a video attachment.
Send the message.
Play the video.
Try to drag or tap on the progress bar forward or backward.
Verify that:
- User can drag the progress bar to seek forward and backward in the video.
- Video playback position updates accordingly to the selected point in the progress bar.
- Progress bar or control bar wouldn't disappear when seeking.
- The video wouldn't resume automatically when holding the progress bar for few seconds in android.
- If the video was paused it will be kept paused if we seek the progress bar in the paused state.
- We can drag the progress bar correctly when try to drag during the fading of the control bar.

Verify that no errors appear in the JS console

Offline tests

Same as Test

QA Steps

Same as Test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-native.mp4

Android: mWeb Chrome

Android-mWeb.mp4

iOS: Native

iOS-native.mp4

iOS: mWeb Safari

iOS-safari.mp4

MacOS: Chrome / Safari

macOS.mp4

codecov · 2026-03-11T10:52:50Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...mponents/VideoPlayer/VideoPlayerControls/index.tsx	`0.00% <ø> (ø)`
...eoPlayer/VideoPlayerControls/ProgressBar/index.tsx	`0.00% <0.00%> (ø)`
src/components/VideoPlayer/BaseVideoPlayer.tsx	`47.21% <13.79%> (-2.97%)`	⬇️
... and 13 files with indirect coverage changes

melvin-bot · 2026-03-12T17:46:59Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Uzaifm127 · 2026-03-12T17:48:08Z

@QichenZhu The failing jest test seems unrelated to the PR changes.

Uzaifm127 · 2026-03-12T17:49:54Z

I found two more bugs in video player (not related to what we are solving). I'll post about those bugs tomorrow.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d40f57ecc1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-12T17:56:25Z

src/components/VideoPlayer/BaseVideoPlayer.tsx

+                                            if (shouldResumeAfterSeek) {
+                                                allowSharedAutoPlayRef.current = true;
+                                                playVideo();


Reset autoplay gate when seek ends from paused state

After a paused seek, onSeekStart sets allowSharedAutoPlayRef.current = false, but this block only restores it inside the shouldResumeAfterSeek branch. That leaves the autoplay gate permanently off for that player, so when the same video becomes non-current and the user taps play once, togglePlayCurrentVideo only updates the URL and shareVideoPlayerElements refuses to auto-play because !allowSharedAutoPlayRef.current is still true; users then need a second tap to actually start playback.

Useful? React with 👍 / 👎.

trjExpensify

👍

QichenZhu · 2026-03-16T08:42:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-16.at.9.17.35.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-03-16.at.9.26.25.PM.mov

iOS: HybridApp

Screen.Recording.2026-03-16.at.9.29.25.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-03-16.at.9.37.43.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-16.at.9.40.17.PM.mov

QichenZhu · 2026-03-16T08:45:38Z

NAB: Video seek drag gesture conflicts with previous/next slide navigation on mobile web. Also seen on staging and may block testing of this PR.

nab-android-web.mov

QichenZhu

LGTM.

The failed unit test should be fixed on main. Tested locally and it passed.

Uzaifm127 · 2026-03-16T08:50:09Z

Let me merge main

github-actions · 2026-03-16T23:28:38Z

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-16T23:33:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84865.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4e02280-03346cd-6e767c9c7e5e45305f3fabe687886df6dead7db1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4e02280-03346cd-17cb72b46ff698009f95e6deec623d99527dd40a/index.html

Web 🕸️
https://84865.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-16T23:33:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-17T11:55:50Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.39-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:02:56Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix: issues related to video progress and controls especially on Android

164e1dd

melvin-bot bot assigned Uzaifm127 Mar 11, 2026

Uzaifm127 changed the title ~~fix: Issues related to video progress and controls especially on Android~~ [WIP] fix: Issues related to video progress and controls especially on Android Mar 11, 2026

Uzaifm127 added 2 commits March 12, 2026 22:35

refactored the code

cd580b2

fixed prettier formatting

01e7ef6

Uzaifm127 changed the title ~~[WIP] fix: Issues related to video progress and controls especially on Android~~ fix: Issues related to video progress and controls especially on Android Mar 12, 2026

Uzaifm127 added 2 commits March 12, 2026 23:01

Removed shouldResumeAfterSeek from onBegin in ProgressBar

389a851

Merge branch 'main' of https://github.com/Uzaifm127/App into fix/82026

d40f57e

Uzaifm127 marked this pull request as ready for review March 12, 2026 17:46

Uzaifm127 requested review from a team as code owners March 12, 2026 17:46

melvin-bot bot requested review from QichenZhu and removed request for a team March 12, 2026 17:46

melvin-bot bot requested review from trjExpensify and removed request for a team March 12, 2026 17:46

chatgpt-codex-connector bot reviewed Mar 12, 2026

View reviewed changes

trjExpensify approved these changes Mar 13, 2026

View reviewed changes

QichenZhu approved these changes Mar 16, 2026

View reviewed changes

melvin-bot bot requested a review from inimaga March 16, 2026 08:49

Merge branch 'main' of https://github.com/Uzaifm127/App into fix/82026

7a962c3

inimaga approved these changes Mar 16, 2026

View reviewed changes

inimaga merged commit 4e02280 into Expensify:main Mar 16, 2026
32 checks passed

OSBotify mentioned this pull request Mar 17, 2026

Deploy Checklist: New Expensify 2026-03-17 #85529

Closed

75 tasks

Conversation

Uzaifm127 commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 11, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

Uzaifm127 commented Mar 12, 2026

Uh oh!

Uzaifm127 commented Mar 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Mar 16, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu commented Mar 16, 2026

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

Uzaifm127 commented Mar 16, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uzaifm127 commented Mar 11, 2026 •

edited

Loading

codecov bot commented Mar 11, 2026 •

edited by github-actions bot

Loading