[NoQA] [Snyk] Security upgrade reassure from 1.0.0-rc.4 to 1.0.0 by MelvinBot · Pull Request #84893 · Expensify/App

MelvinBot · 2026-03-11T15:48:41Z

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SIMPLEGIT-15457646

melvin-bot · 2026-03-11T15:49:23Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

The Snyk PR updated reassure in package.json from ^1.0.0-rc.4 to ^1.0.0 but did not regenerate package-lock.json, causing npm ci to fail in all CI checks due to the lock file being out of sync.

MelvinBot · 2026-03-11T15:54:08Z

Fixed the failing checks: The Snyk PR updated reassure in package.json (from ^1.0.0-rc.4 to ^1.0.0) but did not regenerate package-lock.json. This caused npm ci to fail across all CI checks because the lock file was out of sync with package.json. Regenerated the lock file to resolve the mismatch.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d6bd8d3d2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-11T15:57:23Z

package.json

    "react-refresh": "^0.14.2",
    "react-test-renderer": "19.1.0",
-    "reassure": "^1.0.0-rc.4",
+    "reassure": "^1.0.0",


Regenerate lockfile for reassure upgrade

This change updates package.json to reassure@^1.0.0 but leaves package-lock.json pinned to ^1.0.0-rc.4/1.0.0-rc.4 (see package-lock.json:276 and package-lock.json:35200-35208), so the upgrade is not actually reflected in reproducible installs. In this repo, setupNode runs npm ci (.github/actions/composite/setupNode/action.yml:56), and npm ci requires the lockfile to be in sync (it errors with: npm ci can only install packages when your package.json and package-lock.json ... are in sync), which can break CI jobs whenever dependency install is needed.

Useful? React with 👍 / 👎.

…b0cfaf03044f0a4501bb

MelvinBot · 2026-03-11T16:02:25Z

Fixed the failing checks: The branch was behind main, causing npm ci to fail because package.json and package-lock.json were out of sync. Many packages (reassure, mathjs, @babel/runtime, etc.) had version mismatches between the lock file and the updated package.json. Merged main into this branch to bring everything in sync.

github-actions · 2026-03-17T12:05:53Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-17T12:11:45Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84893.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-74dab13-9897949-b02c639a30c2720b7ee00acaa38a1d7e6c22c0ff/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-74dab13-9897949-603c258d5b36abde9f5919fbb06309ee3f5d067a/index.html

Web 🕸️
https://84893.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-17T12:14:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-18T13:29:54Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T14:05:55Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-23T09:26:57Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: package.json to reduce vulnerabilities

1d6bd8d

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SIMPLEGIT-15457646

MelvinBot requested a review from a team as a code owner March 11, 2026 15:48

melvin-bot bot requested review from mjasikowski and removed request for a team March 11, 2026 15:49

Fix: Update package-lock.json to match reassure version upgrade

3bc3b79

The Snyk PR updated reassure in package.json from ^1.0.0-rc.4 to ^1.0.0 but did not regenerate package-lock.json, causing npm ci to fail in all CI checks due to the lock file being out of sync.

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into snyk-fix-3315450c9ff3…

c8300e0

…b0cfaf03044f0a4501bb

mjasikowski approved these changes Mar 17, 2026

View reviewed changes

mjasikowski merged commit 74dab13 into main Mar 17, 2026
41 of 42 checks passed

mjasikowski deleted the snyk-fix-3315450c9ff3b0cfaf03044f0a4501bb branch March 17, 2026 12:04

mjasikowski changed the title ~~[Snyk] Security upgrade reassure from 1.0.0-rc.4 to 1.0.0~~ [NoQA] [Snyk] Security upgrade reassure from 1.0.0-rc.4 to 1.0.0 Mar 17, 2026

OSBotify mentioned this pull request Mar 18, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] [Snyk] Security upgrade reassure from 1.0.0-rc.4 to 1.0.0#84893

[NoQA] [Snyk] Security upgrade reassure from 1.0.0-rc.4 to 1.0.0#84893
mjasikowski merged 3 commits intomainfrom
snyk-fix-3315450c9ff3b0cfaf03044f0a4501bb

MelvinBot commented Mar 11, 2026 •

edited by melvin-bot bot

Loading

Uh oh!

melvin-bot bot commented Mar 11, 2026

Uh oh!

MelvinBot commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Uh oh!

MelvinBot commented Mar 11, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MelvinBot commented Mar 11, 2026 • edited by melvin-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 11, 2026

Uh oh!

MelvinBot commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Mar 11, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented Mar 11, 2026 •

edited by melvin-bot bot

Loading