Skip to content

[CP staging] Revert "feat/81501: Add Range filter for all date type filters"#84979

Merged
luacmartins merged 1 commit intomainfrom
revert-81897-btkcodedev/81501RangeUI
Mar 12, 2026
Merged

[CP staging] Revert "feat/81501: Add Range filter for all date type filters"#84979
luacmartins merged 1 commit intomainfrom
revert-81897-btkcodedev/81501RangeUI

Conversation

@neil-marcellini
Copy link
Contributor

@neil-marcellini neil-marcellini commented Mar 11, 2026

Fixed Issues

$ #84959
$ #84987
$ #84988
$ #85027
$ #85037
$ #85051

QA steps

Same as fixed issues

Reverts #81897

@neil-marcellini neil-marcellini self-assigned this Mar 11, 2026
@melvin-bot
Copy link

melvin-bot bot commented Mar 11, 2026

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@neil-marcellini neil-marcellini changed the title Revert "feat/81501: Add Range filter for all date type filters" [CP staging] Revert "feat/81501: Add Range filter for all date type filters" Mar 11, 2026
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 93.54% <ø> (+1.48%) ⬆️
src/components/DatePicker/CalendarPicker/Day.tsx 100.00% <100.00%> (ø)
src/components/DatePicker/CalendarPicker/index.tsx 82.29% <ø> (-0.19%) ⬇️
.../Search/SearchPageHeader/DatePickerFilterPopup.tsx 0.00% <ø> (ø)
...ts/Search/SearchPageHeader/useSearchFiltersBar.tsx 75.00% <100.00%> (+1.26%) ⬆️
...e/SearchFiltersReportFieldPage/ReportFieldDate.tsx 0.00% <ø> (ø)
...FiltersPage/SearchFiltersReportFieldPage/index.tsx 0.00% <ø> (ø)
...pace/travel/WorkspaceTravelInvoicingExportPage.tsx 0.00% <ø> (ø)
src/types/form/SearchAdvancedFiltersForm.ts 100.00% <ø> (ø)
...mponents/Search/FilterDropdowns/DropdownButton.tsx 92.59% <50.00%> (-0.27%) ⬇️
... and 7 more
... and 12 files with indirect coverage changes

@luacmartins luacmartins marked this pull request as ready for review March 12, 2026 15:05
@luacmartins luacmartins requested review from a team as code owners March 12, 2026 15:05
@melvin-bot melvin-bot bot requested review from heyjennahay and removed request for a team March 12, 2026 15:05
@melvin-bot melvin-bot bot requested review from mjasikowski and removed request for a team March 12, 2026 15:06
@melvin-bot
Copy link

melvin-bot bot commented Mar 12, 2026

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@luacmartins
Copy link
Contributor

Straight revert. Merging without checklists

@luacmartins luacmartins merged commit d0b7d56 into main Mar 12, 2026
45 of 50 checks passed
@luacmartins luacmartins deleted the revert-81897-btkcodedev/81501RangeUI branch March 12, 2026 15:07
@melvin-bot
Copy link

melvin-bot bot commented Mar 12, 2026

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions
Copy link
Contributor

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

OSBotify pushed a commit that referenced this pull request Mar 12, 2026
…1RangeUI

[CP staging] Revert "feat/81501: Add Range filter for all date type filters"

(cherry picked from commit d0b7d56)

(cherry-picked to staging by luacmartins)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 12, 2026
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.36-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.37-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants