[No QA] Fix negative Sentry span duration logs in dev by marcaaron · Pull Request #85009 · Expensify/App

marcaaron · 2026-03-12T01:00:18Z

Explanation of Change

spanToJSON(span).start_timestamp produces negative or huge duration values in dev (reported here by @JakubKorytko). This switches to storing performance.now() when a span starts and using that for the duration log, which is reliable across all environments.

Added ActiveSpanEntry type wrapping the span + a startTime
Changed the activeSpans map to store entries instead of raw spans
Updated endSpan, cancelSpan, and getSpan to unwrap entries
Removed unused spanToJSON import

Fixed Issues

$ #85008

Tests

Run the app locally on web with npm run web
Perform actions that trigger Sentry spans (navigate between screens, open a report)
Open the browser dev console and filter logs by [Sentry]
Verify span ending logs show reasonable positive durations (e.g. Ending span (120ms)) instead of negative or huge values

Verify that no errors appear in the JS console

Offline tests

N/A - logging-only change, no network dependency.

QA Steps

N/A - No QA. Dev logging only, no user-facing behavior change.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…stead of spanToJSON start_timestamp

melvin-bot · 2026-03-12T01:00:24Z

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JakubKorytko

LGTM, one small comment

JakubKorytko · 2026-03-12T12:40:20Z

src/libs/telemetry/activeSpans.ts

        span.setAttribute(CONST.TELEMETRY.ATTRIBUTE_MIN_DURATION, extraOptions.minDuration);
    }
-    activeSpans.set(spanId, span);
+    activeSpans.set(spanId, {span, startTime: Date.now()});


Date.now() is still wall-clock time, not monotonic. If the device clock jumps forward/backward during a span because of NTP sync, manual time change, or resume-from-sleep behavior, durationMs can still become negative or arbitrarily large. That means the bug is reduced, but not actually fixed "across all environments"; I believe a monotonic source like performance.now() would avoid the same class of failure.

luacmartins · 2026-03-12T20:43:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Julesssss

NAB, description is outdated now with the last commit.

NAB, Also should we use performance.now elsewhere in our metrics?

github-actions · 2026-03-12T20:54:49Z

🚧 @marcaaron has triggered a test Expensify/App build. You can view the workflow run here.

marcaaron · 2026-03-12T20:56:52Z

NAB, Also should we use performance.now elsewhere in our metrics?

I think yes, but also would need to audit the usages to make sure that is what we want.

github-actions · 2026-03-12T21:03:09Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85009.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e3f2c20-fda79d3-c5a61c9e34c7159e233bbaf3fdc066fd347507e3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e3f2c20-fda79d3-183a6d3a16b3ac0bcb4c000e6d76ad130e1d3544/index.html

Web 🕸️
https://85009.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-12T23:19:59Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.3.37-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-16T10:07:52Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix negative/huge Sentry span durations in dev by using Date.now() in…

a65f5fc

…stead of spanToJSON start_timestamp

marcaaron requested a review from JakubKorytko March 12, 2026 01:00

marcaaron requested review from a team as code owners March 12, 2026 01:00

melvin-bot bot assigned marcaaron Mar 12, 2026

melvin-bot bot requested a review from ChavdaSachin March 12, 2026 01:00

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 12, 2026 01:00

JakubKorytko reviewed Mar 12, 2026

View reviewed changes

marcaaron added 2 commits March 12, 2026 10:05

Merge branch 'main' into marcaaron-fixSentryDurationLogs

538cb29

Use performance.now() for monotonic span duration measurement

2e61474

marcaaron removed the request for review from ChavdaSachin March 12, 2026 20:10

JakubKorytko approved these changes Mar 12, 2026

View reviewed changes

luacmartins approved these changes Mar 12, 2026

View reviewed changes

Julesssss approved these changes Mar 12, 2026

View reviewed changes

marcaaron merged commit e3f2c20 into main Mar 12, 2026
34 of 37 checks passed

marcaaron deleted the marcaaron-fixSentryDurationLogs branch March 12, 2026 20:53

github-actions bot mentioned this pull request Mar 12, 2026

Investigate workflow job failing on main: test / test (job 7) #85142

Open

OSBotify mentioned this pull request Mar 12, 2026

Deploy Checklist: New Expensify 2026-03-12 #85146

Closed

87 tasks

MelvinBot mentioned this pull request Mar 16, 2026

Investigate workflow job failing on main: test / test (job 7) #85259

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Fix negative Sentry span duration logs in dev#85009

[No QA] Fix negative Sentry span duration logs in dev#85009
marcaaron merged 3 commits intomainfrom
marcaaron-fixSentryDurationLogs

marcaaron commented Mar 12, 2026 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

JakubKorytko left a comment

Uh oh!

JakubKorytko Mar 12, 2026

Uh oh!

luacmartins commented Mar 12, 2026 •

edited

Loading

Uh oh!

Julesssss left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

marcaaron commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

OSBotify commented Mar 12, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

marcaaron commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

JakubKorytko left a comment

Choose a reason for hiding this comment

Uh oh!

JakubKorytko Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

marcaaron commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

OSBotify commented Mar 12, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marcaaron commented Mar 12, 2026 •

edited

Loading

luacmartins commented Mar 12, 2026 •

edited

Loading