fix: Assigned task appears hidden and assignee status not shown#85032
fix: Assigned task appears hidden and assignee status not shown#85032dangrous merged 3 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e804b99f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| }); | ||
| // If assignee is created optimistically, we need to clear the optimistic personal details to prevent duplication with real data sent from BE. | ||
| if (isOptimisticPersonalDetail(assigneeAccountID)) { |
There was a problem hiding this comment.
Keep cleanup for synthetic assignee personal details
This guard skips cleanup for a common optimistic-assignee path: invite-by-email options use a synthetic accountID (generateAccountID), and setNewOptimisticAssignee stores that record in PERSONAL_DETAILS_LIST without isOptimisticPersonalDetail, so isOptimisticPersonalDetail(assigneeAccountID) returns false here. As a result, on success we keep the synthetic personal detail key even after the backend returns the real user/accountID, which can leave duplicate/stale assignee data (e.g., outdated avatar/status) in later lookups. Please preserve cleanup for synthetic assignee entries or retain the optimistic flag when persisting them.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The thing is BE may not send the data so if we just remove it, the avatar isn't shown
There was a problem hiding this comment.
@dukenv0307 based on what the bot said, it sounds like we should probably add isOptimisticPersonalDetail to setNewOptimisticAssignee, right? I realize that's not related to this exact issue, but might be helpful.
There was a problem hiding this comment.
@nkdengineer can you please update the PR based on the comment above?
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-03-12.at.22.55.27.movAndroid: mWeb ChromeScreen.Recording.2026-03-12.at.22.50.53.moviOS: HybridAppScreen.Recording.2026-03-12.at.22.53.33.moviOS: mWeb SafariScreen.Recording.2026-03-12.at.22.50.20.movMacOS: Chrome / SafariScreen.Recording.2026-03-12.at.22.45.35.mov |
dangrous
left a comment
There was a problem hiding this comment.
Code looks good, but might be able to grab an incremental improvement to clean up setNewOptimisticAssignee, too.
JmillsExpensify
left a comment
There was a problem hiding this comment.
No concerns from me
|
Do we want to act on @dangrous's comment before merging? |
|
If this is pressing, I'd say we can go ahead and merge, but if we have time to update #85032 (comment) it might be a nice bonus |
fd50a81
|
🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.39-0 🚀
|
|
Deploy Blocker #85532 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀
|
Explanation of Change
Fixed Issues
$ #81714
PROPOSAL: #81714 (comment)
Tests
Offline tests
None
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-03-12.at.14.46.07.mov
Android: mWeb Chrome
Screen.Recording.2026-03-12.at.14.47.21.mov
iOS: Native
Screen.Recording.2026-03-12.at.14.48.57.mov
iOS: mWeb Safari
Screen.Recording.2026-03-12.at.14.42.40.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-12.at.14.37.47.mov