Skip to content

Fix blank page when clicking Clear cache and restart in Troubleshoot#85047

Closed
MelvinBot wants to merge 1 commit intomainfrom
claude-fixTroubleshootBlankPage
Closed

Fix blank page when clicking Clear cache and restart in Troubleshoot#85047
MelvinBot wants to merge 1 commit intomainfrom
claude-fixTroubleshootBlankPage

Conversation

@MelvinBot
Copy link
Contributor

@MelvinBot MelvinBot commented Mar 12, 2026

Explanation of Change

Clicking "Clear cache and restart" in Settings > Troubleshoot on staging causes the web page to go blank instead of showing the "Are you sure?" confirmation modal. This was a regression introduced by #84799, which memoized the Global Modal context and exposed a latent bug.

The root cause is a combination of two issues:

  1. The confirm modal uses shouldHandleNavigationBack: true (hardcoded default), which pushes a browser history entry without a React Navigation id. On modal close, window.history.back() fires a popstate event that React Navigation processes as genuine back navigation, corrupting the navigation state.
  2. clearOnyxAndResetApp() was called without shouldNavigateToHomepage, so after Onyx state was wiped, the app was left on a corrupted navigation state with no recovery.

This PR applies two targeted fixes:

  • Passes shouldHandleNavigationBack: false to the confirm modal — this modal immediately clears the app state and does not need browser back-button handling, avoiding the navigation corruption entirely.
  • Passes shouldNavigateToHomepage: true to clearOnyxAndResetApp() — after clearing Onyx, the app navigates to HOME rather than being left stranded.

Fixed Issues

$ #84957
PROPOSAL: #84957 (comment)

Tests

  1. Navigate to Settings (click profile avatar in bottom left)
  2. Click Troubleshoot
  3. Click "Clear cache and restart"
  4. Verify the "Are you sure?" confirmation modal appears with "Reset and refresh" and "Cancel" buttons
  5. Verify the page does NOT go blank
  6. Click "Cancel" and verify the modal closes normally
  7. Click "Clear cache and restart" again
  8. Click "Reset and refresh" and verify the app clears cache and navigates to the home screen
  • Verify that no errors appear in the JS console

Offline tests

N/A — the "Clear cache and restart" flow requires an active session and immediately resets the app.

QA Steps

  1. Navigate to Settings > Troubleshoot
  2. Click "Clear cache and restart"
  3. Verify that the "Are you sure?" modal appears with "Reset and refresh" and "Cancel" buttons (page should NOT go blank)
  4. Click "Reset and refresh"
  5. Verify the app clears cache and navigates to the home screen
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Web: Chrome

Tested via Playwright on the dev environment. The confirmation modal now appears correctly with "Are you sure?" title and "Reset and refresh" / "Cancel" buttons. The page does not go blank.

@MelvinBot @inimaga
Fix blank page when clicking Clear cache and restart in Troubleshoot
2a3b04a 
Two changes to prevent the blank page:
1. Pass shouldHandleNavigationBack: false to the confirm modal since the
   modal immediately clears app state and doesn't need browser back-button
   handling. This prevents window.history corruption that confuses React
   Navigation.
2. Pass shouldNavigateToHomepage: true to clearOnyxAndResetApp() so the
   app navigates to HOME after clearing Onyx state instead of being left
   on a corrupted navigation state.

Co-authored-by: Issa Nimaga <inimaga@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 12, 2026 10:29
@MelvinBot MelvinBot mentioned this pull request Mar 12, 2026
Closed
7 tasks
@inimaga inimaga marked this pull request as ready for review March 12, 2026 11:29
@inimaga inimaga requested a review from a team as a code owner March 12, 2026 11:29
@melvin-bot melvin-bot bot requested review from nyomanjyotisa and removed request for a team March 12, 2026 11:29
@melvin-bot
Copy link

melvin-bot bot commented Mar 12, 2026

@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from JmillsExpensify and removed request for a team March 12, 2026 11:29
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85047.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://85047.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@inimaga
Copy link
Contributor

inimaga commented Mar 12, 2026

Closing PR as issue no longer reproduceable.

@inimaga inimaga closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@inimaga inimaga

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MelvinBot @inimaga