Skip to content

Guard getDeleteTrackExpenseInformation against undefined reportAction#85112

Closed
blimpich wants to merge 1 commit intomainfrom
blimpich-guardGetDeleteTrackExpenseInformation
Closed

Guard getDeleteTrackExpenseInformation against undefined reportAction#85112
blimpich wants to merge 1 commit intomainfrom
blimpich-guardGetDeleteTrackExpenseInformation

Conversation

@blimpich
Copy link
Contributor

Explanation of Change

getDeleteTrackExpenseInformation in src/libs/actions/IOU/index.ts crashes with TypeError: Cannot read properties of undefined (reading 'childReportID') when reportAction is undefined. PR #84350 added a guard in the Split.ts caller, but the function itself remains vulnerable — any caller passing an unloaded report action (due to Onyx's eventually-consistent data) will hit this crash.

This PR:

  1. Makes the reportAction parameter optional (OnyxTypes.ReportAction | undefined)
  2. Adds an early return with a Log.warn if reportAction is missing, returning empty onyx data
  3. Guards deleteTrackExpense from calling API.write when parameters are undefined

Fixed Issues

$ #84349

Tests

  1. Open the app and navigate to Search
  2. Open a money request report (/search/r/<reportID>)
  3. Select multiple transactions including split transactions
  4. Click delete
  5. Verify no crash occurs and no childReportID TypeError in the console
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline
  2. Repeat the test steps above
  3. Verify the app does not crash — if a report action is missing, the delete is silently skipped with a warning log

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant