Guard getDeleteTrackExpenseInformation against undefined reportAction#85112
Closed
Guard getDeleteTrackExpenseInformation against undefined reportAction#85112
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
getDeleteTrackExpenseInformationinsrc/libs/actions/IOU/index.tscrashes withTypeError: Cannot read properties of undefined (reading 'childReportID')whenreportActionisundefined. PR #84350 added a guard in theSplit.tscaller, but the function itself remains vulnerable — any caller passing an unloaded report action (due to Onyx's eventually-consistent data) will hit this crash.This PR:
reportActionparameter optional (OnyxTypes.ReportAction | undefined)Log.warnifreportActionis missing, returning empty onyx datadeleteTrackExpensefrom callingAPI.writewhen parameters are undefinedFixed Issues
$ #84349
Tests
/search/r/<reportID>)childReportIDTypeError in the consoleOffline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari