Remove Onyx.connect() for the key: ONYXKEYS.NVP_ACTIVE_POLICY_ID#85121
Remove Onyx.connect() for the key: ONYXKEYS.NVP_ACTIVE_POLICY_ID#85121tgolen merged 7 commits intoExpensify:mainfrom
Conversation
…ctivePolicyID from useOnyx
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
src/libs/actions/Session/index.ts
Outdated
There was a problem hiding this comment.
| policyID: '', |
@dukenv0307 The change is simple as that. And please test this with #58538. This was a implementation mistake which adds copilot policyID to this call which does not make sense. And we do not use this variable to restore stashed session so we call it as blank. See other places for reference.
|
|
|
@shubham1206agra Good catch! I updated the PR, can you please take a look again? Screen.Recording.2026-03-16.at.11.17.10.mov |
Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-03-16.at.4.42.39.PM.mov |
|
@tgolen Please review this PR |
tgolen
left a comment
There was a problem hiding this comment.
Man... this is great to see. I love seeing this!
|
🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.39-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀
|
Explanation of Change
Fixed Issues
$ #67788
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari