follow up: GBR appears when there is report field error by daledah · Pull Request #85199 · Expensify/App

daledah · 2026-03-13T07:47:45Z

Explanation of Change

Fixed Issues

$ #82676
#84965
#85021

PROPOSAL: #82676 (comment)

Tests

Create workspace > Enable Report
Create a few report fields. (Without initial value)
Create an expense to that workspace
Click on that expense
Verify that: There is RBR when report field error displayed

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

codecov · 2026-03-13T08:16:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...bs/actions/OnyxDerived/configs/reportAttributes.ts	`96.82% <100.00%> (+0.10%)`	⬆️
src/libs/ReportUtils.ts	`78.04% <73.68%> (+0.15%)`	⬆️
... and 9 files with indirect coverage changes

melvin-bot · 2026-03-13T08:25:06Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19ba7bbfd4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/ReportUtils.ts

joekaufmanexpensify

👍

truph01 · 2026-03-17T09:26:39Z

~~@daledah Does our original PR cause this bug?~~

@daledah Two issues #84965 and #85021 have the same RCA, right?

src/libs/actions/OnyxDerived/configs/reportAttributes.ts

truph01 · 2026-03-17T10:07:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-18.at.14.54.01.mov

Android: mWeb Chrome

Screen.Recording.2026-03-18.at.14.46.04.mov

iOS: HybridApp

Screen.Recording.2026-03-18.at.14.51.29.mov

iOS: mWeb Safari

Screen.Recording.2026-03-18.at.14.52.03.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-18.at.14.31.00.mov

daledah · 2026-03-17T10:39:30Z

@daledah Two issues #84965 and #85021 have the same RCA, right?

It looks like another PR removed reportViolations, and the internal team merged my PR before it was synced with main.

dangrous

LGTM though conflicts now!

truph01 · 2026-03-19T03:45:12Z

@daledah We have conflicts

daledah · 2026-03-19T04:22:45Z

@dangrous all looks good now

OSBotify · 2026-03-19T15:17:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-19T15:30:55Z

🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T15:35:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85199.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c42d514-c628576-961e83ec63718b95d7cbda7d0da7981acf939e0d/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://85199.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dangrous · 2026-03-19T20:07:31Z

Aughhhhhhhh guys it happened again. #84673 was merged between the previous check and this one, and so we're messing up typecheck again. Can we update this one?

EDIT: Wait! got my timing wrong. Not our fault it's their fault haha. Sigh.

OSBotify · 2026-03-19T20:25:13Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

- Remove reportViolations param from hasVisibleReportFieldViolations - Update getFieldViolation call to single-arg form - Remove REPORT_VIOLATIONS from reportAttributes dependencies/compute - Fix OnyxDerivedTest to match reduced dependency count Made-with: Cursor

This reverts commit feb5f3d, re-landing the changes from PR Expensify#84673. Made-with: Cursor Fix semantic conflicts with Expensify#85199 (GBR report field errors) - Remove reportViolations param from hasVisibleReportFieldViolations - Update getFieldViolation call to single-arg form - Remove REPORT_VIOLATIONS from reportAttributes dependencies/compute - Fix OnyxDerivedTest to match reduced dependency count Made-with: Cursor

OSBotify · 2026-03-23T09:27:42Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

follow up: GBR appears when there is report field error

58c142a

melvin-bot bot assigned daledah Mar 13, 2026

fix ts and add test

19ba7bb

daledah marked this pull request as ready for review March 13, 2026 08:25

daledah requested review from a team as code owners March 13, 2026 08:25

melvin-bot bot requested a review from truph01 March 13, 2026 08:25

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 13, 2026 08:25

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

joekaufmanexpensify previously approved these changes Mar 13, 2026

View reviewed changes

daledah added 2 commits March 16, 2026 19:28

Merge branch 'main' into follow-up/83424

42abfcb

fix bot comments

349e728

daledah dismissed joekaufmanexpensify’s stale review via 349e728 March 16, 2026 12:31

truph01 reviewed Mar 17, 2026

View reviewed changes

src/libs/actions/OnyxDerived/configs/reportAttributes.ts Outdated Show resolved Hide resolved

daledah added 2 commits March 17, 2026 17:39

Merge branch 'main' into follow-up/83424

5c71cba

fix hasVisibleReportFieldViolations logic

c62a975

truph01 approved these changes Mar 18, 2026

View reviewed changes

melvin-bot bot requested a review from dangrous March 18, 2026 08:13

dangrous previously approved these changes Mar 18, 2026

View reviewed changes

resolve conflict

5ddd5f9

daledah dismissed dangrous’s stale review via 5ddd5f9 March 19, 2026 03:52

dangrous approved these changes Mar 19, 2026

View reviewed changes

dangrous merged commit c42d514 into Expensify:main Mar 19, 2026
32 checks passed

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

MelvinBot mentioned this pull request Mar 19, 2026

fix: use in-app VisionCamera for chat attachments on Android and iOS #84770

Open

64 tasks

dangrous mentioned this pull request Mar 19, 2026

[NO QA] Remove ONYXKEYS.COLLECTION.REPORT_VIOLATIONS #84673

Merged

52 tasks

MelvinBot mentioned this pull request Mar 19, 2026

Chat - Skeleton loader appears when refreshing app #85867

Closed

7 tasks

melvin-bot bot mentioned this pull request Mar 23, 2026

[Due for payment 2026-03-30] GBR appears when there is report field error #82676

Open

7 tasks

Conversation

daledah commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

truph01 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

daledah commented Mar 17, 2026

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Mar 19, 2026

Uh oh!

daledah commented Mar 19, 2026

Uh oh!

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

dangrous commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

daledah commented Mar 13, 2026 •

edited

Loading

codecov bot commented Mar 13, 2026 •

edited by github-actions bot

Loading

truph01 commented Mar 17, 2026 •

edited

Loading

truph01 commented Mar 17, 2026 •

edited

Loading

dangrous commented Mar 19, 2026 •

edited

Loading