[CP Staging] Fix - 'Expense - Report RHP re-renders every time clicking Create expense' by GCyganek · Pull Request #85213 · Expensify/App

GCyganek · 2026-03-13T10:10:22Z

Explanation of Change

Replacing the scrollIntoView() with the mobile version of scrollToTab() logic to fix the weird layout shift when Create distance/Track distance is opened from RHP

Fixed Issues

$ #85155
PROPOSAL: N/A

Tests

IMPORTANT: opening Create expense with Per diem from RHP is not fixed here as it's not related to the scrollable tab selector and is already reproducible on production

Precondition -
Have a report with a couple of expenses(at least two)

Go to the workspace chat
Open the expenses Preview
Click on "+" > Create Expense
The report RHP should remain stable when clicking Create expense

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

order of tabs was changed just for testing

Screen.Recording.2026-03-13.at.11.14.12.mov

Android: mWeb Chrome

iOS: Native

order of tabs was changed just for testing

Screen.Recording.2026-03-13.at.11.11.43.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

order of tabs was changed just for testing

Screen.Recording.2026-03-13.at.11.05.29.mov

…ense'

melvin-bot · 2026-03-13T10:18:24Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-13T10:19:49Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/TabSelector/TabSelectorItem.tsx	`100.00% <ø> (ø)`
src/components/TabSelector/TabSelectorContext.tsx	`11.11% <0.00%> (+0.58%)`	⬆️
src/components/TabSelector/scrollToTab/index.ts	`0.00% <0.00%> (ø)`
... and 173 files with indirect coverage changes

ZhenjaHorbach · 2026-03-13T10:21:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-03-13.11.49.46.mov

Android: mWeb Chrome

2026-03-13.11.47.06.mov

iOS: HybridApp

2026-03-13.11.49.46.mov

iOS: mWeb Safari

2026-03-13.11.47.06.mov

MacOS: Chrome / Safari

2026-03-13.11.40.57.mov

src/components/TabSelector/scrollToTab/index.ts

ZhenjaHorbach · 2026-03-13T10:39:05Z

Small comment in the description for this issue

IMPORTANT: opening Create distance with Per diem from RHP is not fixed here as it's not related to the scrollable tab selector and is already reproducible on production

Instead Create distance should be Create expense

ZhenjaHorbach · 2026-03-13T10:42:58Z

@GCyganek
And could you fix lint issues, please?

GCyganek · 2026-03-13T10:46:27Z

@GCyganek And could you fix lint issues, please?

on it, sorry!

ZhenjaHorbach · 2026-03-13T10:55:15Z

LGTM!

trjExpensify

👍

luacmartins · 2026-03-13T17:10:36Z

@mountiny wanna review before we merge?

mountiny

Thanks for a quick fix

…p-layout-shift [CP Staging] Fix - 'Expense - Report RHP re-renders every time clicking Create expense' (cherry picked from commit 07f05b1) (cherry-picked to staging by luacmartins)

OSBotify · 2026-03-13T18:25:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-13T18:52:24Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.37-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

github-actions · 2026-03-13T19:25:43Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-13T19:30:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85213.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-07f05b1-2ebebc3-4e2936ca25e694ccc24a61569fd90136e96a6d56/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-07f05b1-2ebebc3-bd254ac439d9fbcd7b1118ccc3e02909f3818951/index.html

Web 🕸️
https://85213.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

IuliiaHerets · 2026-03-13T19:36:05Z

CP was passed by QA team, comment

OSBotify · 2026-03-16T10:08:37Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-16T10:33:41Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.38-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-17T11:29:28Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix - 'Expense - Report RHP re-renders every time clicking Create exp…

1ef4f12

…ense'

melvin-bot bot assigned GCyganek Mar 13, 2026

GCyganek mentioned this pull request Mar 13, 2026

Expense - Report RHP re-renders every time clicking Create expense #85155

Closed

7 tasks

GCyganek marked this pull request as ready for review March 13, 2026 10:18

GCyganek requested review from a team as code owners March 13, 2026 10:18

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team March 13, 2026 10:18

melvin-bot bot requested review from trjExpensify and removed request for a team March 13, 2026 10:18

github-actions bot reviewed Mar 13, 2026

View reviewed changes

src/components/TabSelector/scrollToTab/index.ts Show resolved Hide resolved

delete tabRef and registerTab()

d0c0d6d

Fix lint

e657024

ZhenjaHorbach approved these changes Mar 13, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny March 13, 2026 10:55

trjExpensify approved these changes Mar 13, 2026

View reviewed changes

luacmartins approved these changes Mar 13, 2026

View reviewed changes

mountiny changed the title ~~Fix - 'Expense - Report RHP re-renders every time clicking Create expense'~~ [CP Staging] Fix - 'Expense - Report RHP re-renders every time clicking Create expense' Mar 13, 2026

mountiny approved these changes Mar 13, 2026

View reviewed changes

mountiny merged commit 07f05b1 into Expensify:main Mar 13, 2026
38 of 39 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 13, 2026

OSBotify mentioned this pull request Mar 13, 2026

Deploy Checklist: New Expensify 2026-03-12 #85146

Closed

87 tasks

Conversation

GCyganek commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 13, 2026

Uh oh!

codecov bot commented Mar 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ZhenjaHorbach commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 13, 2026

Uh oh!

GCyganek commented Mar 13, 2026

Uh oh!

ZhenjaHorbach commented Mar 13, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Mar 13, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 13, 2026

Uh oh!

OSBotify commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

IuliiaHerets commented Mar 13, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

GCyganek commented Mar 13, 2026 •

edited

Loading

codecov bot commented Mar 13, 2026 •

edited by github-actions bot

Loading

ZhenjaHorbach commented Mar 13, 2026 •

edited

Loading

ZhenjaHorbach commented Mar 13, 2026 •

edited

Loading