Fix: Suggestion List - Compose box lost focus after closing suggestion list with ESC key#85223
Fix: Suggestion List - Compose box lost focus after closing suggestion list with ESC key#85223dangrous merged 4 commits intoExpensify:mainfrom
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
During testing i have found console error which is also reproduced in the latest main 2026-03-13.14.11.23.movSo it's not related to this PR |
src/libs/clearSelectedTextIfComposerBlurred/clearSelectedTextIfComposerBlurred.website.ts
Outdated
Show resolved
Hide resolved
src/libs/clearSelectedTextIfComposerBlurred/clearSelectedTextIfComposerBlurred.website.ts
Outdated
Show resolved
Hide resolved
|
Test failing is out of time, i think we can just restart it to fix |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppN/A — the change does not affect Android native Android: mWeb ChromeScreen.Recording.2026-03-16.at.15.57.41.moviOS: HybridAppScreen.Recording.2026-03-16.at.15.53.20.moviOS: mWeb SafariScreen.Recording.2026-03-16.at.15.51.59.movMacOS: Chrome / SafariScreen.Recording.2026-03-16.at.15.49.52.mov |
|
@Eskalifer1 Could you please merge main again? The unit test issue might already be resolved on main |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.39-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀
|
Explanation of Change
This PR fixes a bug where, when Composer is in focus and the user has the suggestion menu open (using
:or@) and presses theEsckey, Composer loses focusFixed Issues
$#84737
PROPOSAL:#84737 (comment)
Tests
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-03-13.13.52.36.mov