Part 7 - Thread betas through buildPolicyData and openReportFromDeepLink to prepareOnboardingOnyxData.#85251
Conversation
…epareOnboardingOnyxData. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
buildPolicyData and openReportFromDeepLink to prepareOnboardingOnyxData.
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03772e4728
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@Krishna2323 The code change looks good. Could you recover the test coverage? |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-03-16.at.14.17.25.mov |
|
@DylanDylann test added. The report looks correct for the files changed:
|
|
@Krishna2323 Could you take a look at src/libs/actions/Policy/Policy.ts ?
|
|
@DylanDylann it's unrelated:
|
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #66417 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
cc @tgolen |
|
🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.39-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀
|
buildPolicyData and openReportFromDeepLink to prepareOnboardingOnyxData.buildPolicyData and openReportFromDeepLink to prepareOnboardingOnyxData.


Explanation of Change
Fixed Issues
$ #66417
PROPOSAL:
Tests
Same as QA Steps
Verify that no errors appear in the JS console
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-03-13.22-28-45.mp4