Skip to content

Dont show Allow Location modal when creating 0 amount expense #85261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Valforte merged 2 commits into from
Mar 13, 2026
Merged

Dont show Allow Location modal when creating 0 amount expense #85261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e57e40b
dont show Allow Location modal when creating 0 amount expense
Valforte Mar 13, 2026
6e80417
prettier
Valforte Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/iou/request/step/IOURequestStepConfirmation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@
const isMovingTransactionFromTrackExpense = isMovingTransactionFromTrackExpenseIOUUtils(action);
const isTestTransaction = transaction?.participants?.some((participant) => isSelectedManagerMcTest(participant.login));

const gpsRequired = transaction?.amount === 0 && iouType !== CONST.IOU.TYPE.SPLIT && Object.values(receiptFiles).length && !isTestTransaction;
const gpsRequired = transaction?.amount === 0 && iouType !== CONST.IOU.TYPE.SPLIT && Object.values(receiptFiles).length && !isTestTransaction && isScanRequest(transaction);
const [isConfirmed, setIsConfirmed] = useState(false);
const [isConfirming, setIsConfirming] = useState(false);

Expand Down Expand Up @@ -699,7 +699,7 @@
existingIOUReport = iouReport;
}
},
[

Check warning on line 702 in src/pages/iou/request/step/IOURequestStepConfirmation.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

React Hook useCallback has an unnecessary dependency: 'transactionIDs'. Either exclude it or remove the dependency array
transactionIDs,
transactions,
receiptFiles,
Expand Down
Loading