Skip to content

Revert "Respect mute preference for iOS foreground notification sounds" #85264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 1 commit into from
Mar 13, 2026
Merged

Revert "Respect mute preference for iOS foreground notification sounds" #85264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/libs/Notification/PushNotification/ForegroundNotifications/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import Airship, {iOS} from '@ua/react-native-airship';
import shouldShowPushNotification from '@libs/Notification/PushNotification/shouldShowPushNotification';
import {getIsMuted} from '@libs/Sound/BaseSound';
import type ForegroundNotificationsModule from './types';

function configureForegroundNotifications() {
Expand All @@ -15,15 +14,7 @@ function configureForegroundNotifications() {

// Set a callback to override our foreground presentation per notification depending on the app's current state.
// Returning null keeps the default presentation. Returning [] uses no presentation (hides the notification).
Airship.push.iOS.setForegroundPresentationOptionsCallback((pushPayload) => {
if (!shouldShowPushNotification(pushPayload)) {
return Promise.resolve([]);
}
if (getIsMuted()) {
return Promise.resolve([iOS.ForegroundPresentationOption.List, iOS.ForegroundPresentationOption.Banner, iOS.ForegroundPresentationOption.Badge]);
}
return Promise.resolve(null);
});
Airship.push.iOS.setForegroundPresentationOptionsCallback((pushPayload) => Promise.resolve(shouldShowPushNotification(pushPayload) ? null : []));
}

function disableForegroundNotifications() {
Expand Down
84 changes: 0 additions & 84 deletions tests/unit/ForegroundNotificationsTest.ts
View file
Open in desktop

This file was deleted.

Loading