Add rhpHomePage variant (D) to onboarding A/B/C/D test by marcochavezf · Pull Request #85273 · Expensify/App

marcochavezf · 2026-03-13T21:13:30Z

Explanation of Change

This PR does two things for the onboarding A/B/C/D experiment (#610149):

1. Add variant D (rhpHomePage) frontend handling

Add frontend handling for the new rhpHomePage onboarding variant that navigates users to the Home page after onboarding, without opening the side panel or test drive modal. Concierge Anywhere remains accessible in the #admins room naturally.

Changes:

Add RHP_HOME_PAGE: 'rhpHomePage' constant and update the OnboardingRHPVariant type
Include rhpHomePage in shouldOpenRHPVariant() eligibility check
Add early return in handleRHPVariantNavigation() that navigates to ROUTES.HOME

2. Fix race condition in variant redirect (affects all variants)

Users assigned to rhpConciergeDm or rhpAdminsRoom sometimes don't get redirected to the workspace editor. The root cause: shouldOpenRHPVariant() reads module-level variables populated by Onyx.connectWithoutView() callbacks, which may not have fired by the time navigation runs after the CompleteGuidedSetup API response.

Fix: Accept an optional variantOverride parameter in shouldOpenRHPVariant() and handleRHPVariantNavigation(). The caller in BaseOnboardingInterestedFeatures extracts the variant directly from the API response's onyxData and passes it through, bypassing the async Onyx callback entirely. Existing callers without the override continue to work via the module-level variable (backward compatible).

Companion PRs:

Auth#20374 — Backend randomization (% 3 → % 4, adds rhpHomePage branch)
Web-Expensify#51287 — PHP NVP doc + test assertions

Deployment note: This PR should deploy before Auth#20374 to avoid a measurement gap. App changes are no-ops until Auth activates the randomization.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/610149

Tests

Variant D (new):

Sign up with a new account
Select "Manage my team's expenses" during onboarding
Select company size "1-10 employees"
Complete the onboarding flow (workspace creation, interested features)
If your account is assigned rhpHomePage variant (check via await Onyx.get('nvp_onboardingRHPVariant') in the console), verify:
- You land on the Home page
- The side panel does auto-open

Existing variants (regression check):
6. For rhpConciergeDm variant: verify you land on Workspace Overview with the side panel open showing Concierge DM
7. For rhpAdminsRoom variant: verify you land on Workspace Overview with the side panel open showing the #admins room chat
8. For control variant: verify you land on Home view, no side panel open

Race condition fix verification:
9. On a slow network connection (use Chrome DevTools throttling), complete onboarding as a micro-company user
10. Verify you are consistently redirected to the correct variant destination (not falling through to default/HOME)

Offline tests

N/A — variant assignment happens during onboarding which requires network.

QA Steps

Same as Tests above. Focus on steps 9-10 for the race condition fix.

PR Author Checklist

Screenshots/Videos

Android: Native

No screenshots or videos

Android: mWeb Chrome

No screenshots or videos

iOS: Native

No screenshots or videos

iOS: mWeb Safari

No screenshots or videos

MacOS: Chrome / Safari

No screenshots or videos

Add frontend handling for the new rhpHomePage variant that navigates users to the Home page after onboarding, without opening the side panel or test drive modal. Concierge Anywhere remains accessible in the #admins room naturally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

melvin-bot · 2026-03-13T21:13:37Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

The module-level onboardingRHPVariant variable in RHPVariantTest/index.ts is populated by an Onyx.connectWithoutView callback that may not have fired by the time navigateAfterOnboarding calls shouldOpenRHPVariant. This causes intermittent failures where users assigned to rhpConciergeDm or rhpAdminsRoom fall through to default navigation instead of the workspace editor. Fix: accept an optional variantOverride parameter in shouldOpenRHPVariant and handleRHPVariantNavigation. The caller in BaseOnboardingInterestedFeatures extracts the variant directly from the CompleteGuidedSetup API response onyxData and passes it through, bypassing the async Onyx callback entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

codecov · 2026-03-13T22:03:16Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.54% <ø> (ø)`
...omponents/SidePanel/RHPVariantTest/index.native.ts	`100.00% <100.00%> (ø)`
src/libs/navigateAfterOnboarding.ts	`70.37% <50.00%> (ø)`
...estedFeatures/BaseOnboardingInterestedFeatures.tsx	`0.00% <0.00%> (ø)`
src/components/SidePanel/RHPVariantTest/index.ts	`0.00% <0.00%> (ø)`
... and 71 files with indirect coverage changes

The response onyxData is typed with a narrow key union that does not include nvp_onboardingRHPVariant. Cast to Array<{key: string; value: unknown}> to allow searching for the variant key. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The rhpHomePage variant should open the RHP with Concierge DM on the Home page, not just navigate to Home silently. This matches the experiment intent: test whether landing on Home + RHP Concierge performs differently from workspace overview + RHP Concierge. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

marcochavezf · 2026-03-16T18:56:00Z

Hi @thesahindia! Could you prioritize the review soon? Any questions, please let me know!

joekaufmanexpensify

Good for product

thesahindia · 2026-03-17T23:45:45Z

@marcochavezf, for rhpHomePage variant the Concierge DM gets auto-opened.

Screen.Recording.2026-03-18.at.5.11.47.AM.mov

marcochavezf · 2026-03-18T01:03:12Z

@marcochavezf, for rhpHomePage variant the Concierge DM gets auto-opened.

Yup, this is the expected behavior for this variant. The RHP remains closed only for the control variant

thesahindia · 2026-03-18T04:11:41Z

@marcochavezf, do we need to update the test steps for rhpHomePage? I thought the side panel shouldn't open.

marcochavezf · 2026-03-18T05:05:48Z

@marcochavezf, do we need to update the test steps for rhpHomePage? I thought the side panel shouldn't open.

Oh yes, good catch, updated!

thesahindia · 2026-03-18T09:23:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-18.at.5.11.47.AM.mov

thesahindia

LGTM!

melvin-bot · 2026-03-18T09:24:08Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-03-18T09:24:12Z

🎯 @thesahindia, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #85625.

github-actions · 2026-03-18T11:52:43Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-18T11:58:33Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85273.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d1f626f-84e475f-77d09b73609720c3600ee9a5e3eae06352e51080/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d1f626f-84e475f-504ddab03ed9b6fbb0e6cb65555a77d56cfbdb77/index.html

Web 🕸️
https://85273.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-18T12:01:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru · 2026-03-18T13:25:14Z

@marcochavezf
How do we set up to verify the following:

Existing variants (regression check):
6. For rhpConciergeDm variant: verify you land on Workspace Overview with the side panel open showing Concierge DM
7. For rhpAdminsRoom variant: verify you land on Workspace Overview with the side panel open showing the #admins room chat
8. For control variant: verify you land on Home view, no side panel open

OSBotify · 2026-03-18T13:30:24Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T14:06:25Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

marcochavezf · 2026-03-19T18:12:37Z

@marcochavezf How do we set up to verify the following:

Existing variants (regression check):
6. For rhpConciergeDm variant: verify you land on Workspace Overview with the side panel open showing Concierge DM
7. For rhpAdminsRoom variant: verify you land on Workspace Overview with the side panel open showing the #admins room chat
8. For control variant: verify you land on Home view, no side panel open

The way to check is by signing up with a new account and checking in the console the variant with the following command await Onyx.get('nvp_onboardingRHPVariant')

marcochavezf · 2026-03-19T18:19:18Z

Hmm I realized that control variant is not landing in the Home view

I'm going to revert this one, since this is a regression

This reverts merge commit d1f626f because the control variant regressed — it no longer lands on the Home view after onboarding. Reverting to restore correct behavior while the fix is reworked. Made-with: Cursor

…g-variant-d Revert "Add rhpHomePage variant (D) to onboarding A/B/C/D test" (#85273)

…g-variant-d Revert "Add rhpHomePage variant (D) to onboarding A/B/C/D test" (#85273) (cherry picked from commit 329f10c) (cherry-picked to staging by cristipaval) Made-with: Cursor

OSBotify · 2026-03-23T09:28:00Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

marcochavezf requested review from a team as code owners March 13, 2026 21:13

melvin-bot bot assigned marcochavezf Mar 13, 2026

melvin-bot bot requested a review from thesahindia March 13, 2026 21:13

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 13, 2026 21:13

marcochavezf and others added 2 commits March 13, 2026 16:05

joekaufmanexpensify approved these changes Mar 16, 2026

View reviewed changes

thesahindia approved these changes Mar 18, 2026

View reviewed changes

melvin-bot bot requested a review from carlosmiceli March 18, 2026 09:24

melvin-bot bot mentioned this pull request Mar 18, 2026

[Due for Payment 2026-03-26] Payment issue for E/App PR#85273 #85625

Open

carlosmiceli approved these changes Mar 18, 2026

View reviewed changes

carlosmiceli merged commit d1f626f into main Mar 18, 2026
38 of 39 checks passed

carlosmiceli deleted the marco/610149-onboarding-variant-d-app branch March 18, 2026 11:49

OSBotify mentioned this pull request Mar 18, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

marcochavezf mentioned this pull request Mar 19, 2026

[CP Staging] Revert "Add rhpHomePage variant (D) to onboarding A/B/C/D test" (#85273) #85849

Merged

50 tasks

cristipaval added a commit that referenced this pull request Mar 19, 2026

Merge pull request #85849 from Expensify/marco/revert-85273-onboardin…

329f10c

…g-variant-d Revert "Add rhpHomePage variant (D) to onboarding A/B/C/D test" (#85273)

Conversation

marcochavezf commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 13, 2026

Uh oh!

codecov bot commented Mar 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

marcochavezf commented Mar 16, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

thesahindia commented Mar 17, 2026

Uh oh!

marcochavezf commented Mar 18, 2026

Uh oh!

thesahindia commented Mar 18, 2026

Uh oh!

marcochavezf commented Mar 18, 2026

Uh oh!

thesahindia commented Mar 18, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 18, 2026

Uh oh!

melvin-bot bot commented Mar 18, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

kavimuru commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

marcochavezf commented Mar 19, 2026

Uh oh!

marcochavezf commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marcochavezf commented Mar 13, 2026 •

edited

Loading

codecov bot commented Mar 13, 2026 •

edited by github-actions bot

Loading