Fix travel card display in Assigned Cards by blimpich · Pull Request #85282 · Expensify/App

blimpich · 2026-03-14T00:08:28Z

Explanation of Change

Two bugs preventing the Travel CVV entry from showing in the wallet's Assigned Cards section:

The travel card was appearing as a duplicate "Expensify Card" in the assigned cards loop because it used the deprecated isTravelCard NVP for detection (which is no longer set by the backend). Switched to feedCountry === TRAVEL_US and now skip travel cards from that loop entirely — the dedicated travelCardGrouped section already handles them correctly.
The travelCardGrouped entries were only included when both company AND personal cards existed. The fallback return path (companyCardsGrouped.length > 0 && personalCardsGrouped.length > 0 being false) dropped travelCardGrouped entirely. This was the actual root cause — most users only have one card type, so the Travel CVV entry was silently omitted.

Fixed Issues

$ #85281

Tests

Verify that no errors appear in the JS console

Log in as a user with a travel card assigned and the travelInvoicing beta enabled
Go to Settings > Wallet
Verify the "Travel CVV" entry appears under Assigned Cards with the luggage icon and "Use this when booking travel" subtitle
Verify there is no duplicate "Expensify Card" entry for the travel card
Tap the Travel CVV entry and verify it navigates to the Travel CVV page

Offline tests

Go offline
Navigate to Settings > Wallet
Verify the Travel CVV entry still displays correctly in the Assigned Cards list

QA Steps

Verify that no errors appear in the JS console

Same as tests, on staging with a travel card account.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…gation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

melvin-bot · 2026-03-14T00:08:35Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/settings/Wallet/PaymentMethodList.tsx

blimpich · 2026-03-14T00:15:17Z

@thesahindia @heyjennahay please ignore the ping

codecov · 2026-03-14T00:19:32Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/settings/Wallet/PaymentMethodList.tsx	`0.00% <0.00%> (ø)`
... and 15 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8cf4691aa8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/settings/Wallet/PaymentMethodList.tsx

Travel cards are now identified by feedCountry === TRAVEL_US instead of the deprecated isTravelCard NVP. They are skipped in the assignedCardsGrouped loop since the dedicated travelCardGrouped section already renders them with the correct title, icon, and navigation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The fallback path (when only company OR personal cards exist, not both) was returning companyCardsGrouped without travelCardGrouped, so the Travel CVV entry was silently dropped. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

blimpich · 2026-03-14T01:06:04Z

@codex review

chatgpt-codex-connector · 2026-03-14T01:13:08Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ikevin127

Code-wise LGTM, if you require manual testing - I'm assuming you have a test email account for your personal ngrok that I should use which will have a Travel card assigned ? Let me know and I'll perform the tests 👐

ℹ️ This PR should probably have [NoQA] in the title.

melvin-bot · 2026-03-14T01:22:10Z

@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blimpich · 2026-03-14T01:56:30Z

Nope, no test email account because I can't create fake travel cards in dev. Or at least I'm not aware of a way to do it. So just looking for code review and then we can QA this once it's deployed to staging.

ikevin127 · 2026-03-14T02:15:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

parasharrajat · 2026-03-14T06:05:55Z

src/pages/settings/Wallet/PaymentMethodList.tsx

                return [...companyCards, ...personalCards];
            }
-            return [...companyCardsGrouped, ...personalCardsGrouped];
+            return [...companyCardsGrouped, ...travelCardGrouped, ...personalCardsGrouped];


Should the travelCard be last in the list?

parasharrajat

Otherwise looks good.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2026-03-14T07:31:48Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-03-16T12:31:04Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-16T12:35:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85282.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bc7b1b1-a6a9d5f-67aff241e9e59e4d00ddfc2b8c090bc34471907d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bc7b1b1-a6a9d5f-ae8cd9cb4d9c28b1b0240dd3d59fc01738f396e8/index.html

Web 🕸️
https://85282.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-16T12:47:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-17T11:56:47Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.39-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:03:53Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Fix travel card in Assigned Cards showing wrong title, icon, and navi…

8cf4691

…gation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

blimpich requested review from a team as code owners March 14, 2026 00:08

melvin-bot bot assigned blimpich Mar 14, 2026

melvin-bot bot requested review from heyjennahay and thesahindia and removed request for a team March 14, 2026 00:08

melvin-bot bot removed the request for review from a team March 14, 2026 00:08

github-actions bot reviewed Mar 14, 2026

View reviewed changes

src/pages/settings/Wallet/PaymentMethodList.tsx Outdated Show resolved Hide resolved

blimpich added the InternalQA This pull request required internal QA label Mar 14, 2026

blimpich removed request for heyjennahay and thesahindia March 14, 2026 00:14

chatgpt-codex-connector bot reviewed Mar 14, 2026

View reviewed changes

src/pages/settings/Wallet/PaymentMethodList.tsx Outdated Show resolved Hide resolved

blimpich and others added 2 commits March 13, 2026 17:48

blimpich requested review from ikevin127, parasharrajat and rlinoz March 14, 2026 01:06

ikevin127 approved these changes Mar 14, 2026

View reviewed changes

melvin-bot bot requested a review from roryabraham March 14, 2026 01:22

parasharrajat reviewed Mar 14, 2026

View reviewed changes

parasharrajat approved these changes Mar 14, 2026

View reviewed changes

melvin-bot bot requested a review from Gonals March 14, 2026 07:31

roryabraham approved these changes Mar 14, 2026

View reviewed changes

rlinoz approved these changes Mar 16, 2026

View reviewed changes

rlinoz merged commit bc7b1b1 into main Mar 16, 2026
49 of 51 checks passed

rlinoz deleted the blimpich-fixTravelCardWalletDisplay branch March 16, 2026 12:30

github-actions bot mentioned this pull request Mar 16, 2026

Investigate workflow job failing on main: chooseDeployActions #85400

Closed

OSBotify mentioned this pull request Mar 17, 2026

Deploy Checklist: New Expensify 2026-03-17 #85529

Closed

75 tasks

melvin-bot bot mentioned this pull request Mar 18, 2026

[Due for payment 2026-03-25] Travel card in Assigned Cards shows wrong title, icon, and navigates to wrong page #85281

Closed

Conversation

blimpich commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 14, 2026

Uh oh!

Uh oh!

blimpich commented Mar 14, 2026

Uh oh!

codecov bot commented Mar 14, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

blimpich commented Mar 14, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 14, 2026

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 14, 2026

Uh oh!

blimpich commented Mar 14, 2026

Uh oh!

ikevin127 commented Mar 14, 2026

Reviewer Checklist

Uh oh!

parasharrajat Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

parasharrajat left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 14, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

blimpich commented Mar 14, 2026 •

edited

Loading

codecov bot commented Mar 14, 2026 •

edited by github-actions bot

Loading

parasharrajat left a comment •

edited

Loading