Skip to content

Revert "fix: selecting multiple messages doesn't work as expected"#85299

Closed
situchan wants to merge 1 commit intoExpensify:mainfrom
situchan:revert-82507-fix/selection-bug-37447
Closed

Revert "fix: selecting multiple messages doesn't work as expected"#85299
situchan wants to merge 1 commit intoExpensify:mainfrom
situchan:revert-82507-fix/selection-bug-37447

Conversation

@situchan
Copy link
Contributor

@situchan situchan commented Mar 15, 2026

Explanation of Change

Reverts #82507

Fixes bad regression below:

bug image

Fixed Issues

$ #85358

@github-actions
Copy link
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...rc/components/ActionSheetAwareScrollView/index.tsx 0.00% <ø> (ø)
src/pages/inbox/report/PureReportActionItem.tsx 56.69% <ø> (-0.06%) ⬇️
src/components/FlatList/FlatList/index.tsx 0.00% <0.00%> (ø)
... and 13 files with indirect coverage changes

@NJ-2020
Copy link
Contributor

NJ-2020 commented Mar 15, 2026

@situchan Have you tried running npm install? It's working on my side:

Screen.Recording.2026-03-15.at.18.48.46.mov

@situchan
Copy link
Contributor Author

@situchan Have you tried running npm install? It's working on my side:

Screen.Recording.2026-03-15.at.18.48.46.mov

I ran. Should I try npm ci?

@situchan
Copy link
Contributor Author

ok npm ci fixes the above bug.

But #82507 (comment) is still happening. Let's fix this.

@situchan situchan closed this Mar 18, 2026
@situchan situchan deleted the revert-82507-fix/selection-bug-37447 branch March 18, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants