fix content alignment & improvemance#85306
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
| const {transitionActionSheetState} = ActionSheetAwareScrollView.useActionSheetAwareScrollViewActions(); | ||
| const {translate, formatPhoneNumber, localeCompare, formatTravelDate, getLocalDateFromDatetime, datetimeToCalendarTime} = useLocalize(); | ||
| const {showConfirmModal} = useConfirmModal(); | ||
| const platform = getPlatform(); |
There was a problem hiding this comment.
❌ CONSISTENCY-1 (docs)
The PR introduces getPlatform() and isWeb inside PureReportActionItem to determine the accessibilityRole. This is a platform-specific check within a heavily rendered component. While the original code already had Platform.OS !== CONST.PLATFORM.WEB, replacing it with getPlatform() (a function call on every render) is strictly worse than the static constant Platform.OS for a component rendered per report action.
If keeping the platform check inline, prefer the original Platform.OS which is a static constant with zero per-render cost:
accessibilityRole={Platform.OS !== CONST.PLATFORM.WEB ? CONST.ROLE.BUTTON : undefined}Alternatively, extract the platform-specific accessibilityRole logic into a platform-specific file or constant.
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
|
Explanation of Change
Fixed Issues
$ #37447
#82507 (comment)
PROPOSAL: #37447 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-03-16.at.23.53.57.mov
Android: mWeb Chrome
Screen.Recording.2026-03-16.at.21.51.22.mov
iOS: Native
Screen.Recording.2026-03-17.at.00.06.59.mov
iOS: mWeb Safari
Screen.Recording.2026-03-17.at.00.10.11.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-17.at.00.13.16.mov