Show 'Concierge is thinking' indicator in #admins room by marcochavezf · Pull Request #85327 · Expensify/App

marcochavezf · 2026-03-16T05:17:52Z

Explanation of Change

The AgentZero "Concierge is thinking..." status indicator was not appearing in the #admins room during onboarding because the frontend useAgentZeroStatusIndicator hook and the ReportActionCompose submit logic were gated on isConciergeChatReport(), which only returns true for the 1:1 Concierge DM chat. The backend already correctly sends the agentZeroProcessingRequestIndicator NVP for admin rooms, but the App was ignoring it.

This PR extends the check to also activate the indicator for isAdminRoom() reports. This enables:

The optimistic "Thinking..." indicator when the user sends a message or clicks a suggested followup
The server-pushed status labels (e.g., "Concierge is looking up categories...")
The Pusher subscription for real-time reasoning event updates

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/610150

Tests

Enable the suggestedFollowups beta for your test account (alternatively, you can use an account with the domain @dmb.fun which is already included in the beta)
Sign up as a new user and select "Manage my team's expenses" during onboarding
Navigate to the #admins room
Send a message or click a suggested followup
Verify that "Concierge is thinking..." (or similar status label) appears above the text input while waiting for a response
Verify the indicator disappears when Concierge's response arrives
Open the Concierge 1:1 DM chat
Send a message and verify the indicator still works there (regression check)

Verify that no errors appear in the JS console

Offline tests

Send a message in the #admins room while online
Verify the thinking indicator appears
Go offline while the indicator is showing
Verify the indicator clears (optimistic state clears on offline)

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

PR

The AgentZero status indicator (typing/thinking) was only shown in Concierge DM chats because the useAgentZeroStatusIndicator hook and the submit form logic were gated on isConciergeChatReport(), which returns false for policy #admins rooms. The backend already sends the indicator NVP for admin rooms, but the App was ignoring it. Extend the check to also activate the indicator for isAdminRoom() reports, so users see "Concierge is thinking..." in the #admins room during onboarding with the suggestedFollowups beta. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

melvin-bot · 2026-03-16T05:17:57Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-16T05:27:35Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useAgentZeroStatusIndicator.ts	`100.00% <100.00%> (ø)`
src/pages/inbox/ReportScreen.tsx	`71.12% <ø> (+0.13%)`	⬆️
...report/ReportActionCompose/ReportActionCompose.tsx	`68.90% <100.00%> (+0.13%)`	⬆️
... and 270 files with indirect coverage changes

marcochavezf

Checklist boxes updated - triggering re-check

joekaufmanexpensify

Makes sense to me!

ikevin127 · 2026-03-17T01:21:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

web.mov

ikevin127

(2) NAB comments during code-review. Moving forward with manual testing ♻️

src/hooks/useAgentZeroStatusIndicator.ts

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx

ikevin127

Other than the ☝️ 2 NAB comments, LGTM 🟢

melvin-bot · 2026-03-17T01:53:07Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-03-17T01:53:11Z

🎯 @ikevin127, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #85496.

Address review feedback: - Rename isConciergeChat parameter to isAgentZeroChat in useAgentZeroStatusIndicator hook since it now supports both Concierge DMs and #admins rooms - Remove useMemo wrapper for shouldShowConciergeIndicator in ReportActionCompose since it's a simple boolean expression that doesn't need memoization Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

marcochavezf · 2026-03-17T22:46:46Z

Comments addressed, ready for re-review!

ikevin127

Thanks, LGTM 🟢

melvin-bot · 2026-03-17T22:54:41Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-03-17T23:03:02Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-17T23:07:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85327.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-88ee5ad-84e475f-77d09b73609720c3600ee9a5e3eae06352e51080/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-88ee5ad-84e475f-504ddab03ed9b6fbb0e6cb65555a77d56cfbdb77/index.html

Web 🕸️
https://85327.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-17T23:10:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru · 2026-03-18T13:27:51Z

@marcochavezf is applause.expensifail.com domain account is beta enabled?

Enable the suggestedFollowups beta for your test account (alternatively, you can use an account with the domain @dmb.fun which is already included in the beta)

OSBotify · 2026-03-18T13:30:39Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

marcochavezf · 2026-03-18T13:31:12Z

Hi @kavimuru, I think yes but let's use the dumb.fun domain to be sure

OSBotify · 2026-03-18T14:06:40Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-23T09:28:18Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

marcochavezf requested review from a team as code owners March 16, 2026 05:17

melvin-bot bot assigned marcochavezf Mar 16, 2026

melvin-bot bot requested a review from ikevin127 March 16, 2026 05:17

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 16, 2026 05:17

marcochavezf commented Mar 16, 2026

View reviewed changes

joekaufmanexpensify previously approved these changes Mar 16, 2026

View reviewed changes

ikevin127 reviewed Mar 17, 2026

View reviewed changes

src/hooks/useAgentZeroStatusIndicator.ts Outdated Show resolved Hide resolved

src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx Outdated Show resolved Hide resolved

ikevin127 approved these changes Mar 17, 2026

View reviewed changes

melvin-bot bot requested a review from carlosmiceli March 17, 2026 01:53

melvin-bot bot mentioned this pull request Mar 17, 2026

[Due for Payment 2026-03-26] Payment issue for E/App PR#85327 #85496

Open

carlosmiceli previously approved these changes Mar 17, 2026

View reviewed changes

marcochavezf dismissed stale reviews from carlosmiceli and joekaufmanexpensify via 1d5e72e March 17, 2026 21:29

marcochavezf requested review from carlosmiceli and ikevin127 March 17, 2026 22:46

ikevin127 approved these changes Mar 17, 2026

View reviewed changes

melvin-bot bot requested a review from mjasikowski March 17, 2026 22:54

carlosmiceli approved these changes Mar 17, 2026

View reviewed changes

carlosmiceli merged commit 88ee5ad into main Mar 17, 2026
38 checks passed

carlosmiceli deleted the marco/610150-admins-room-thinking-indicator branch March 17, 2026 23:02

OSBotify mentioned this pull request Mar 18, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

Conversation

marcochavezf commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

codecov bot commented Mar 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

marcochavezf left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 17, 2026

Uh oh!

melvin-bot bot commented Mar 17, 2026

Uh oh!

marcochavezf commented Mar 17, 2026

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 17, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

kavimuru commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

marcochavezf commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marcochavezf commented Mar 16, 2026 •

edited

Loading

codecov bot commented Mar 16, 2026 •

edited by github-actions bot

Loading

ikevin127 commented Mar 17, 2026 •

edited

Loading