feat: Person Amount and Attendees in Expense Table by nkdengineer · Pull Request #85332 · Expensify/App

nkdengineer · 2026-03-16T07:06:18Z

Explanation of Change

feat: Person Amount and Attendees in Expense Table

Fixed Issues

$ #83223
PROPOSAL: #83223 (comment)

Tests

Create a workspace expense.
Add multiple attendees to the expense.
Split the expense between attendees.
View the expense in the NewDot expense table.
Verify that the attendees column displays the attendees correctly
Verify that the total per attendee column shows the correct amount with the correct format

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-03-16T07:06:23Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-03-16T07:19:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.65% <ø> (ø)`
...stReportView/MoneyRequestReportTransactionList.tsx	`0.00% <ø> (ø)`
src/components/Search/SearchTableHeader.tsx	`5.40% <ø> (ø)`
src/libs/TransactionUtils/index.ts	`83.69% <100.00%> (ø)`
src/components/TransactionItemRow/index.tsx	`85.34% <88.88%> (+0.29%)`	⬆️
src/styles/utils/index.ts	`49.41% <75.00%> (+<0.01%)`	⬆️
src/libs/SearchUIUtils.ts	`68.17% <30.76%> (-0.24%)`	⬇️
...nents/Search/SearchList/ListItem/AttendeesCell.tsx	`0.00% <0.00%> (ø)`
... and 16 files with indirect coverage changes

melvin-bot · 2026-03-16T15:42:13Z

@shawnborton @hungvu193 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2026-03-16T15:50:34Z

Looks pretty good. Can we see screenshots for light mode too?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21c7142ee4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-16T15:56:50Z

src/components/TransactionItemRow/index.tsx

+                            <TextWithTooltip
+                                testID="TotalPerAttendeeCell"
+                                shouldShowTooltip
+                                text={convertToDisplayString(totalPerAttendee, getCurrency(transactionItem))}


Handle scanning expenses before formatting per-attendee amount

When a receipt is still scanning, getAmount(transactionItem) resolves to 0 and this path always formats it as currency, so the new per-attendee column shows $0.00 even though the amount is not finalized yet. The total column already guards this state in DataCells/TotalCell.tsx by showing the scanning label, so this creates inconsistent and misleading values specifically for scanning expenses with attendees.

Useful? React with 👍 / 👎.

nkdengineer · 2026-03-16T15:58:31Z

@shawnborton Here is the light mode.

shawnborton · 2026-03-16T16:07:30Z

For both themes, I think we need to adjust the border color when the row is highlighted as well as when the row is selected - it should always match the background color:

shawnborton · 2026-03-16T16:11:02Z

Also, the +X text should use our micro strong styles:

shawnborton · 2026-03-16T16:13:50Z

Then I was thinking we'd use the overlay color from darkmode as the scrim over the last avatar, and always use our buttonSuccessText color:

dannymcclain · 2026-03-16T16:31:29Z

Love all that feedback Shawn!

dubielzyk-expensify · 2026-03-17T00:50:09Z

Yeah really like this. We should probably update that styling back in Figma within the chat message component

nkdengineer · 2026-03-17T09:22:28Z

Also, the +X text should use our micro strong styles:
For both themes, I think we need to adjust the border color when the row is highlighted as well as when the row is selected - it should always match the background color:

@shawnborton I updated these problems.

Then I was thinking we'd use the overlay color from darkmode as the scrim over the last avatar, and always use our buttonSuccessText color:

For this one, can you please highlight what we need to change? Thanks.

justinpersaud · 2026-03-31T19:37:34Z

I think we can solve the issue @shawnborton reported in the frontend here

Actually I forgot, we have a few small things to fix first

justinpersaud · 2026-04-01T18:00:57Z

Failing typescript check

nkdengineer · 2026-04-01T18:47:02Z

@justinpersaud It's on main. Merged main to fix this.

github-actions · 2026-04-01T22:06:06Z

🚧 @justinpersaud has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-01T22:11:28Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85332.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-39a01d7-84fce23-e79ad1b5000fe6733a0e7e0cc497a6de9f94d699/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-39a01d7-84fce23-a5e2bdc70767c5ae967720369b0d4e31ef816f29/index.html

Web 🕸️
https://85332.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-01T22:13:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-02T20:19:20Z

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.3.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-02T20:22:05Z

Yes, help site changes are required. PR #85332 adds two new columns (Attendees and Per attendee) to the expense table, which are not documented.

I've created #86991 with the following updates:

Adding-Attendees.md — Added a new section explaining how attendees and per-attendee amounts appear in the expense table.
Managing-Expenses-in-a-Report.md — Added the two new columns to the expense table column list.

Please mark it as "Ready for review" when it is ready.

mitarachim · 2026-04-02T21:02:03Z

Deploy Blocker #87006 was identified to be related to this PR.

jponikarchuk · 2026-04-02T21:02:06Z

Deploy Blocker #87005 was identified to be related to this PR.

mitarachim · 2026-04-02T21:14:35Z

Deploy Blocker #87016 was identified to be related to this PR.

OSBotify · 2026-04-07T01:10:16Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.52-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

nkdengineer added 2 commits March 13, 2026 16:34

feat: Display Per-Person Amount and Attendees in Expense Table

d64c058

Merge branch 'main' of https://github.com/nkdengineer/App into fix/83223

d6de2ee

melvin-bot bot assigned nkdengineer Mar 16, 2026

nkdengineer added 4 commits March 16, 2026 14:43

implement hook to get the attendees

c7c8457

use getAttendees util

c2ef12a

use avatar from attendee data to display the avatar

c7ac28c

change condition to display total per attendee

21c7142

nkdengineer marked this pull request as ready for review March 16, 2026 15:42

nkdengineer requested review from a team as code owners March 16, 2026 15:42

melvin-bot bot requested review from hungvu193 and shawnborton and removed request for a team March 16, 2026 15:42

melvin-bot bot requested review from JmillsExpensify and removed request for a team March 16, 2026 15:42

chatgpt-codex-connector bot reviewed Mar 16, 2026

View reviewed changes

nkdengineer added 2 commits March 17, 2026 15:43

Merge branch 'main' into fix/83223

3aff07e

update border color and text style

8c93a95

Merge branch 'main' into fix/83223

b364061

justinpersaud previously approved these changes Apr 1, 2026

View reviewed changes

nkdengineer added 3 commits April 1, 2026 23:11

remove useMemo

f3ae724

show scanning per attendee

3c00f7e

Merge branch 'main' into fix/83223

17b20bd

Merge branch 'main' of https://github.com/nkdengineer/App into fix/83223

98d6923

justinpersaud approved these changes Apr 1, 2026

View reviewed changes

justinpersaud merged commit 39a01d7 into Expensify:main Apr 1, 2026
32 checks passed

OSBotify mentioned this pull request Apr 2, 2026

Deploy Checklist: New Expensify 2026-04-02 #86989

Closed

MelvinBot mentioned this pull request Apr 2, 2026

[No QA] Update help site docs for Attendees expense table columns #86991

Open

3 tasks

jponikarchuk mentioned this pull request Apr 2, 2026

Expense - Attendees field does not update to custom avatar #87005

Open

7 tasks

mitarachim mentioned this pull request Apr 2, 2026

[Due for payment 2026-04-14] Expense - Per attendee amount on the table does not show negative sign #87006

Open

7 tasks

jponikarchuk mentioned this pull request Apr 2, 2026

[Due for payment 2026-04-14] [$250] Display Per-Person Amount and Attendees in Expense Table #83223

Open

7 tasks

mitarachim mentioned this pull request Apr 2, 2026

Reports- Attendees&Per attendee are still enabled by default after disabling Attendee tracking #87016

Closed

7 tasks

lanitochka17 mentioned this pull request Apr 3, 2026

Reports - Unable to sort by Attendees and Per attendee #87088

Open

7 tasks

jponikarchuk mentioned this pull request Apr 9, 2026

[Exploratory] Reports - Attendees and Per attendee column are blank for unreported expense #87528

Open

7 tasks

Conversation

nkdengineer commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

codecov bot commented Mar 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

shawnborton commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Mar 16, 2026

Uh oh!

shawnborton commented Mar 16, 2026

Uh oh!

shawnborton commented Mar 16, 2026

Uh oh!

shawnborton commented Mar 16, 2026

Uh oh!

dannymcclain commented Mar 16, 2026

Uh oh!

dubielzyk-expensify commented Mar 17, 2026

Uh oh!

nkdengineer commented Mar 17, 2026

Uh oh!

justinpersaud commented Mar 31, 2026

Uh oh!

justinpersaud commented Apr 1, 2026

Uh oh!

nkdengineer commented Apr 1, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

OSBotify commented Apr 1, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

MelvinBot commented Apr 2, 2026

Uh oh!

mitarachim commented Apr 2, 2026

Uh oh!

jponikarchuk commented Apr 2, 2026

Uh oh!

mitarachim commented Apr 2, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

nkdengineer commented Mar 16, 2026 •

edited

Loading

codecov bot commented Mar 16, 2026 •

edited by github-actions bot

Loading