Skip to content

Migrated RoomInvitePage.tsx from useOptionsList to usePersonalDetailOptions #85344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
Mar 18, 2026
+107 −455
Merged

Migrated RoomInvitePage.tsx from useOptionsList to usePersonalDetailOptions #85344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions src/libs/OptionsListUtils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@
*/

let allReports: OnyxCollection<Report>;
Onyx.connect({

Check warning on line 211 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function

Check warning on line 211 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.REPORT,
waitForCollectionCallback: true,
callback: (value) => {
Expand All @@ -220,7 +220,7 @@
const allSortedReportActions: Record<string, ReportAction[]> = {};
const cachedOneTransactionThreadReportIDs: Record<string, string | undefined> = {};
let allReportActions: OnyxCollection<ReportActions>;
Onyx.connect({

Check warning on line 223 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function

Check warning on line 223 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
waitForCollectionCallback: true,
callback: (actions) => {
Expand Down Expand Up @@ -265,7 +265,7 @@
});

let activePolicyID: OnyxEntry<string>;
Onyx.connect({

Check warning on line 268 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function

Check warning on line 268 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.NVP_ACTIVE_POLICY_ID,
callback: (value) => (activePolicyID = value),
});
Expand Down Expand Up @@ -2851,35 +2851,6 @@
};
}

/**
* Build the options for the Workspace Member Invite view
* This method will be removed. See https://github.com/Expensify/App/issues/66615 for more information.
*/
function getMemberInviteOptions(
personalDetails: Array<SearchOption<PersonalDetails>>,
nvpDismissedProductTraining: OnyxEntry<DismissedProductTraining>,
loginList: OnyxEntry<Login>,
currentUserAccountID: number,
currentUserEmail: string,
personalDetailsCollection: OnyxEntry<PersonalDetailsList>,
betas: Beta[] = [],
excludeLogins: Record<string, boolean> = {},
includeSelectedOptions = false,
countryCode: number = CONST.DEFAULT_COUNTRY_CODE,
): Options {
return getValidOptions({personalDetails, reports: []}, undefined, undefined, nvpDismissedProductTraining, loginList, currentUserAccountID, currentUserEmail, {
betas,
includeP2P: true,
excludeLogins,
includeSelectedOptions,
includeRecentReports: false,
searchString: '',
maxElements: undefined,
personalDetails: personalDetailsCollection,
countryCode,
});
}

/**
* Helper method that returns the text to be used for the header's message and title (if any)
*/
Expand Down Expand Up @@ -3423,7 +3394,6 @@
getLastActorDisplayNameFromLastVisibleActions,
getLastMessageTextForReport,
getManagerMcTestParticipant,
getMemberInviteOptions,
getParticipantsOption,
getPersonalDetailSearchTerms,
getPersonalDetailsForAccountIDs,
Expand Down
Loading
Loading