[No QA][Sentry] activeSpans logs are displayed locally only#85351
[No QA][Sentry] activeSpans logs are displayed locally only#85351sosek108 wants to merge 9 commits intoExpensify:mainfrom
Conversation
|
@rlinoz According to our slack discussion I think we don't need server side logs for |
…r Sentry spans are sent
| }, | ||
|
|
||
| { | ||
| files: ['src/libs/ReportNameUtils.ts'], |
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The eslint.changed.config.mjs file already imports and spreads the entire mainConfig from eslint.config.mjs via ...mainConfig at line 39. Since the report-name-utils plugin rule block was added to eslint.config.mjs, it is automatically inherited here. Adding the same block again in eslint.changed.config.mjs is redundant duplication — the import of reportNameUtilsPlugin on line 2 and the rule block (lines 111–115) should be removed from this file.
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
|
Closing this as base for this branch was wrong. Correct PR: #85353 |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Explanation of Change
This PR removes sending Sentry logs from
activeSpansto/api/Log. Only local debug logs will be displayed for debug purposes.Fixed Issues
$ #84761
PROPOSAL:
Tests
[Sentry]logs are displayed on the logs.expensify.com[Sentry]logs are displayed in Developer Tools consoleOffline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari