Skip to content

Remove useDocumentTitle cleanup to fix tab title race condition #85473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuwenmemon merged 2 commits into from
Mar 20, 2026
+0 −1
Merged

Remove useDocumentTitle cleanup to fix tab title race condition #85473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2b9dba
Remove cleanup function from useDocumentTitle to prevent title race c…
MelvinBot Mar 16, 2026
636e030
Merge branch 'main' of github.com:Expensify/App into claude-removeDoc…
yuwenmemon Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/hooks/useDocumentTitle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ function useDocumentTitle(title: string) {
useFocusEffect(
useCallback(() => {
setPageTitle(title);
return () => setPageTitle('');
}, [title]),
Comment on lines 7 to 9
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset page title when focus effect is cleaned up

Dropping the cleanup here leaves currentPageTitle latched to the previous screen indefinitely, because updateUnread only falls back to CONFIG.SITE_TITLE when that value is empty. With NavigationContainer document titles disabled (src/libs/Navigation/NavigationRoot.tsx), any route that does not call useDocumentTitle (for example auth routes like SCREENS.VALIDATE_LOGIN in src/libs/Navigation/AppNavigator/AuthScreens.tsx) will inherit the last page title; a common case is leaving a report and then opening login/auth screens, where the tab can continue showing the old report name instead of the app title.

Useful? React with 👍 / 👎.

Copy link
Contributor

@yuwenmemon yuwenmemon Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new screen should update it with its title. The way proposed above introduced a race condition that caused page titles to be reset more often than they were set to the correct ones.

);
}
Expand Down
Loading