fix: Confirm page shows Amount field with 0.00 amount when receipt is scanning v3#85513
Conversation
…h 0.00 amount when receipt is scanning v2""
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ef765d22a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| setMoneyRequestDescription(transaction?.transactionID, newComment, isTransactionDraft); | ||
| setMoneyRequestDescription(transaction?.transactionID, newComment, isTransactionDraft, hasReceipt(transaction)); |
There was a problem hiding this comment.
Avoid cancelling SmartScan on description-only edits
In the create scan flow, this new hasReceipt(transaction) argument makes setMoneyRequestDescription() flip the draft receipt state to OPEN, even though comment edits are not considered SmartScan-stopping anywhere else (getUpdatedTransaction() in src/libs/TransactionUtils/index.ts only does that for created/amount/currency/merchant changes). If a user adds a note while the receipt is still scanning or after it failed, we cancel the remaining extraction and clear the failure state, so the confirmation view can fall back to $0.00/missing fields instead of letting SmartScan finish or preserving the retry warning.
Useful? React with 👍 / 👎.
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp85513_android_native.movAndroid: mWeb Chrome85513_android_web.moviOS: HybridApp85513_ios_native.moviOS: mWeb Safari85513_ios_web.movMacOS: Chrome / Safari85513_web_chrome.mov |
|
I can reproduce a bug in our PR:
MacOS: Chrome / Safaribug_PR.movHowever, also in production: I don't believe it's within the scope of our PR, what do you think @nkdengineer? I can report it on Slack. Thank you. |

Explanation of Change
fix: Confirm page shows Amount field with 0.00 amount when receipt is scanning
Fixed Issues
$ #80287
PROPOSAL: #80287 (comment)
Tests
scanning...text.Offline tests
Same
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-02.at.16.39.18.mov
Android: mWeb Chrome
Screen.Recording.2026-02-02.at.16.35.44.mov
iOS: Native
Screen.Recording.2026-02-02.at.16.45.24.mov
iOS: mWeb Safari
Screen.Recording.2026-02-02.at.16.41.00.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-02.at.16.34.25.mov
Screen.Recording.2026-03-03.at.21.52.35.mov
Screen.Recording.2026-03-18.at.13.46.49.mov