Skip to content

Replace FullScreenLoadingIndicator with ActivityIndicator in VerifyAccountPageBase #85517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 3 commits into from
Mar 17, 2026
+9 −5
Merged

Replace FullScreenLoadingIndicator with ActivityIndicator in VerifyAccountPageBase #85517

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
146444e
Replace FullScreenLoadingIndicator with ActivityIndicator in VerifyAc…
MelvinBot Mar 17, 2026
a620926
Use styles.fullScreenLoading instead of inline styles
MelvinBot Mar 17, 2026
9213317
Restore reasonAttributes prop on ActivityIndicator
MelvinBot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/pages/settings/VerifyAccountPageBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, {useCallback, useEffect} from 'react';
import FullScreenLoadingIndicator from '@components/FullscreenLoadingIndicator';
import {View} from 'react-native';
import ActivityIndicator from '@components/ActivityIndicator';
import HeaderWithBackButton from '@components/HeaderWithBackButton';
import ScreenWrapper from '@components/ScreenWrapper';
import ValidateCodeActionContent from '@components/ValidateCodeActionModal/ValidateCodeActionContent';
Expand All @@ -11,6 +12,7 @@ import {clearContactMethodErrors, clearUnvalidatedNewContactMethodAction, reques
import {getEarliestErrorField, getLatestErrorField} from '@libs/ErrorUtils';
import Navigation from '@libs/Navigation/Navigation';
import type {SkeletonSpanReasonAttributes} from '@libs/telemetry/useSkeletonSpan';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import type {Route} from '@src/ROUTES';
import {isEmptyObject} from '@src/types/utils/EmptyObject';
Expand Down Expand Up @@ -82,10 +84,12 @@ function VerifyAccountPageBase({navigateBackTo, navigateForwardTo, handleClose,
title={translate('contacts.validateAccount')}
onBackButtonPress={handleCloseWithFallback}
/>
<FullScreenLoadingIndicator
style={[styles.flex1, styles.pRelative]}
reasonAttributes={{context: 'VerifyAccountPageBase', isUserValidated} satisfies SkeletonSpanReasonAttributes}
Copy link
Contributor

@situchan situchan Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot restore this prop reasonAttributes. We need it

Copy link
Contributor Author

@MelvinBot MelvinBot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored the reasonAttributes prop on ActivityIndicator — it accepts the same prop as FullScreenLoadingIndicator did, so the telemetry span is preserved.

/>
<View style={[styles.flex1, styles.fullScreenLoading]}>
<ActivityIndicator
size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE}
reasonAttributes={{context: 'VerifyAccountPageBase', isUserValidated} satisfies SkeletonSpanReasonAttributes}
/>
</View>
</ScreenWrapper>
);
}
Expand Down
Loading