Remove personal details requirement for virtual card reveal#85525
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@jjcoffee @rafecolton One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Re-assigned to Joe since he has more context. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Change makes sense from a product perspective 👍
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-03-17.at.6.07.02.PM.moviOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-03-17.at.6.09.51.PM.mov |
rafecolton
left a comment
There was a problem hiding this comment.
Just the one comment - everything else looks great and worked well when I tested it
|
🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rafecolton in version: 9.3.40-0 🚀
|
|
🚀 Deployed to staging by https://github.com/rafecolton in version: 9.3.40-0 🚀
|
|
Not working on staging. Does this need your backend PR to be deployed before it will work @chuckdries ? API command is throwing an error saying card details can't be revealed without setting personal info. Logs.
|
|
Revealing works fine for US virtual cards with no personal details set |
|
Hmm, my backend PR is concerned with issuing virtual cards |
|
I see. Investigating this error here then |
|
We discussed in the above thread and confirmed this does not need to block the deploy because it is behind beta. We will fix the BE issue separately |
|
Hi @DylanDylann. QA team is not able to Set up a UK or EU Expensify Card. 205e5c97e4e2bf70dc25bc9d501db679.mp4 |
|
@joekaufmanexpensify can you QA please? |
|
I previously QA'ed it here, and the checklist is closed. So I think this is all set, but let me know if that's not correct @IuliiaHerets |
|
I will retest once the backend PR is out, since I think that is still pending. Sounds like you will be working on it, yeah @chuckdries ? |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀
|

Explanation of Change
Fixed Issues
#85297
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-03-17.at.17.25.22.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari