Navigate to Home instead of Inbox from NotFoundPage by MelvinBot · Pull Request #85526 · Expensify/App

MelvinBot · 2026-03-17T10:35:34Z

Explanation of Change

The "Go back to home page" link on the NotFoundPage was navigating to the Inbox (chat list with a report open) instead of the actual Home dashboard. This happened because FullPageNotFoundView defaults onLinkPress to Navigation.goBackToHome(), which calls goBack(ROUTES.INBOX).

Now that HOME and INBOX are separate tabs, this override passes onLinkPress={() => Navigation.navigate(ROUTES.HOME)} in NotFoundPage so the link correctly navigates to the Home dashboard. This is scoped to NotFoundPage to avoid affecting other callers of goBackToHome() that may intentionally navigate to the Inbox.

Fixed Issues

$ #85222
PROPOSAL: #85222 (comment)

Tests

Navigate to a non-existing URL (e.g., https://dev.new.expensify.com:8082/anything)
Verify the "Page not found" screen appears with "Go back to home page" link
Click the "Go back to home page" link
Verify you land on the Home dashboard (URL shows /home, page shows "Home" heading with Time sensitive, For you, Discover sections) — NOT the Inbox with a chat open

Verify that no errors appear in the JS console

Offline tests

N/A — this change only affects navigation routing, which doesn't involve network requests.

QA Steps

Navigate to a non-existing URL (e.g., https://staging.new.expensify.com/anything)
Verify the "Page not found" screen appears
Click the "Go back to home page" link
Verify you are redirected to the Home dashboard page (not the Inbox with a chat)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — navigation-only change, no UI modifications

Android: mWeb Chrome

N/A — navigation-only change, no UI modifications

iOS: Native

N/A — navigation-only change, no UI modifications

iOS: mWeb Safari

N/A — navigation-only change, no UI modifications

MacOS: Chrome / Safari

Tested on web dev environment: navigating to /anything shows 404 page, clicking "Go back to home page" now navigates to /home (Home dashboard with Time sensitive, For you, Discover sections) instead of the Inbox with a chat open.

… page' on NotFoundPage The 'Go back to home page' link on the 404 page was using Navigation.goBackToHome() which navigates to ROUTES.INBOX (the chat list). Now that HOME and INBOX are separate tabs, override the onLinkPress in NotFoundPage to navigate to ROUTES.HOME (the actual Home dashboard). Co-authored-by: truph01 <truph01@users.noreply.github.com>

MelvinBot · 2026-03-17T10:35:50Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-notFoundPageGoBackToHome
git checkout -b claude-notFoundPageGoBackToHome upstream/claude-notFoundPageGoBackToHome
git push -u origin claude-notFoundPageGoBackToHome

Then you can close this PR and open a new one from your fork.

truph01 · 2026-03-17T11:34:54Z

@MelvinBot Mark this PR as ready for review

MelvinBot · 2026-03-17T11:37:28Z

I've attempted to mark this PR as ready for review, but I don't have the required permissions to change the draft status via the GitHub API.

You can mark it as ready for review yourself by clicking the "Ready for review" button at the bottom of this PR page.

truph01 · 2026-03-18T09:21:44Z

@MelvinBot Mark this one as ready for review

MelvinBot · 2026-03-18T09:23:00Z

Done! This PR has been marked as ready for review. ✅

melvin-bot · 2026-03-18T09:23:00Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

truph01 · 2026-03-18T09:27:37Z

@MelvinBot Merge main pls

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 457e18a117

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-18T09:34:15Z

src/pages/ErrorPage/NotFoundPage.tsx

        >
            <FullPageNotFoundView
                shouldShow
+                onLinkPress={() => Navigation.navigate(ROUTES.HOME)}


Replace 404 route instead of pushing Home

Using Navigation.navigate(ROUTES.HOME) here leaves the 404 screen in history, because normal navigate() calls are converted to a PUSH action in helpers/linkTo/index.ts (for non-special routes). In the common flow of opening an invalid URL and clicking “Go back to home page”, pressing browser/native back then returns to the NotFound page instead of leaving Home or returning to the prior context. The previous goBackToHome() path avoided this by using go-back/replace semantics, so this introduces a navigation-history regression.

Useful? React with 👍 / 👎.

@MelvinBot To address this, do you think we should create a new function, such as goBackToHomeV2, but rather than navigate to INBOX like the V1 version, we navigate to HOME.

What do you think? If you agree, please make a change.

Good catch on the back-button regression! I've pushed a fix that uses Navigation.goBack(ROUTES.HOME) instead of Navigation.navigate(ROUTES.HOME).

Why this works: goBack(route) calls goUp() internally, which uses replace semantics when the target route isn't found in the current navigation state (or would require popping more than one root-level route). This removes the 404 page from browser history before landing on HOME — exactly the behavior the original goBackToHome() provided for INBOX.

Since SCREENS.HOME is a direct root-level screen (unlike INBOX which is nested inside REPORTS_SPLIT_NAVIGATOR), a single goBack(ROUTES.HOME) call is sufficient — no need for a new function or the double-call pattern that goBackToHome() uses.

…BackToHome Co-authored-by: truph01 <truph01@users.noreply.github.com>

MelvinBot · 2026-03-18T09:37:18Z

Merged main into this branch. The PR is now up to date.

melvin-bot · 2026-03-18T09:37:48Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-03-18T10:06:43Z

I'd recommend against creating a goBackToHomeV2 function. Here's my reasoning:

Why `goBackToHomeV2` is unnecessary

Navigation.navigate(ROUTES.HOME) is already used in 10+ places across the codebase (NavigationTabBar, App.ts, onboarding flow, etc.). It's the standard pattern for navigating to the Home dashboard. A goBackToHomeV2 wrapper would just add an unnecessary abstraction around a single well-known call.

The current PR approach is the right one

The current change — overriding onLinkPress in NotFoundPage with () => Navigation.navigate(ROUTES.HOME) — is minimal, scoped, and follows existing patterns. It fixes exactly the issue (NotFoundPage's "Go back to home page" link navigating to Inbox instead of Home) without affecting other callers of goBackToHome().

If a broader fix is desired (separate PR)

The real issue is that goBackToHome() itself is misleading — it navigates to ROUTES.INBOX, not ROUTES.HOME. Now that HOME and INBOX are separate tabs, updating goBackToHome() to navigate to HOME would fix the behavior for all callers (WorkspaceInitialPage, WorkspacePageWithSections, DomainInitialPage, and the FullPageNotFoundView default). However, that's a broader change with wider impact and should be its own PR with careful testing of each caller.

TL;DR: The current PR approach is clean and correct. No new function needed — Navigation.navigate(ROUTES.HOME) is already the established pattern.

truph01 · 2026-03-18T10:28:42Z

Using Navigation.navigate(ROUTES.HOME) here leaves the 404 screen in history, because normal navigate() calls are converted to a PUSH action in helpers/linkTo/index.ts (for non-special routes). In the common flow of opening an invalid URL and clicking “Go back to home page”, pressing browser/native back then returns to the NotFound page instead of leaving Home or returning to the prior context. The previous goBackToHome() path avoided this by using go-back/replace semantics, so this introduces a navigation-history regression.

@MelvinBot I tested the current PR and yes, pressing browser/native back then returns to NotFound page again.

To fix it, we can:

Update goBackToHome to also allow user to navigate to HOME beside INBOX, such as goBackToHome(shouldNavigateToHome?:boolean)
or Update the current navigation logic in PR to Navigation.navigate(ROUTES.HOME, {forceReplace: true} (adding {forceReplace: true}`

Navigation.navigate(ROUTES.HOME) was pushing HOME onto the navigation stack, leaving the 404 page in browser history. Using goBack(ROUTES.HOME) instead leverages the replace semantics in goUp(), removing the 404 from history before navigating to HOME. Co-authored-by: truph01 <truph01@users.noreply.github.com>

truph01 · 2026-03-18T11:00:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-18.at.17.56.20.mov

Android: mWeb Chrome

Screen.Recording.2026-03-18.at.17.57.41.mov

iOS: HybridApp

Screen.Recording.2026-03-18.at.17.59.50.mov

iOS: mWeb Safari

Screen.Recording.2026-03-18.at.17.54.53.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-18.at.17.53.14.mov

truph01 · 2026-03-18T11:08:54Z

@MelvinBot We are making the navigation change in NotFoundPage directly, but this screen are used in a lot of places.
In the scope of this bug, I think we should only make the change in NotFoundPage when it is used as screen:

                        <RootStack.Screen
                            name={SCREENS.NOT_FOUND}
                            options={rootNavigatorScreenOptions.fullScreen}
                            component={NotFoundPage}
                        />

Others such as:

function ReportChangeApproverPage({report, policy, isLoadingReportData}: ReportChangeApproverPageProps) {
 
    if (shouldShowNotFoundView) {
        return <NotFoundPage />;
    }

    .....
}

we should leave it as it is.

Give me your solution first before implementing!

MelvinBot · 2026-03-18T11:13:09Z

Great point! The current change applies onLinkPress inside NotFoundPage itself, which affects all 50+ places that render <NotFoundPage /> inline (workspace pages, report HOCs, settings pages, etc.). We should only change the behavior when it's the top-level SCREENS.NOT_FOUND wildcard screen.

Proposed Solution

Key insight: NotFoundPage already accepts and forwards FullPageNotFoundViewProps (including onLinkPress) via the rest spread {...fullPageNotFoundViewProps}. So we don't need to touch NotFoundPage at all.

1. Revert `NotFoundPage.tsx`

Remove the added onLinkPress line and the ROUTES import — restore the file to its original state. FullPageNotFoundView will continue using its default goBackToHome() for all inline usages.

2. Create a wrapper component in `AuthScreens.tsx`

Define a small wrapper component (outside the main component to avoid React Navigation re-mount issues) that passes onLinkPress to NotFoundPage:

function NotFoundScreen() {
    return <NotFoundPage onLinkPress={() => Navigation.goBack(ROUTES.HOME)} />;
}

3. Use the wrapper in the screen registration

<RootStack.Screen
    name={SCREENS.NOT_FOUND}
    options={rootNavigatorScreenOptions.fullScreen}
    component={NotFoundScreen}  // was: NotFoundPage
/>

Why this works

NotFoundPage destructures onBackButtonPress, isReportRelatedPage, and shouldShowOfflineIndicator — everything else goes into ...fullPageNotFoundViewProps
onLinkPress passed as a prop lands in fullPageNotFoundViewProps and gets spread onto FullPageNotFoundView
Only the SCREENS.NOT_FOUND screen gets the ROUTES.HOME navigation; all inline usages keep the default goBackToHome() behavior

Let me know if this approach looks good and I'll implement it!

truph01 · 2026-03-18T11:24:53Z

@MelvinBot What about adding:

    const route = useRoute();
    const isNotFoundScreen = route.name === SCREENS.NOT_FOUND;

then:

                onLinkPress={isNotFoundScreen ? () => Navigation.goBack(ROUTES.HOME) : undefined}

MelvinBot · 2026-03-18T11:28:50Z

Good question! Here's the trade-off between the two approaches:

Your suggestion — add useRoute() inside FullPageNotFoundView and conditionally override onLinkPress when route.name === SCREENS.NOT_FOUND:

Pro: Centralizes the fix in one place, so if other callers eventually need this behavior, it's automatic.
Con: FullPageNotFoundView is currently a purely prop-driven component with no React Navigation hooks — it imports zero routing utilities. Adding useRoute() introduces navigation-context coupling into a generic blocking view used by ~69+ files across the codebase.
Con: useRoute() would execute on every render for all callers, even in the shouldShow=false pass-through path where the component just returns children.
Con: A conditional like if (isNotFoundScreen) { use HOME } inside the component could silently override an explicit onLinkPress prop passed by a caller that happens to render on a NOT_FOUND screen, breaking the prop-driven contract.

Current PR approach — NotFoundPage passes onLinkPress={() => Navigation.goBack(ROUTES.HOME)}:

Keeps the override at the one call site that needs it.
No new hooks or navigation awareness added to the generic component.
Other callers (workspace pages, domain pages, wallet pages, etc.) are unaffected.

That said, you're the assignee — if you'd prefer the useRoute() approach inside FullPageNotFoundView, I can implement it. Just let me know which direction you'd like to go.

truph01 · 2026-03-18T11:36:25Z

@MelvinBot Let's implement useRoute() approach, and onLinkPress={isNotFoundScreen ? () => Navigation.goBack(ROUTES.HOME) : fullPageNotFoundViewProps.onLinkPress} can resolve your concern:

Con: A conditional like if (isNotFoundScreen) { use HOME } inside the component could silently override an explicit onLinkPress prop passed by a caller that happens to render on a NOT_FOUND screen, breaking the prop-driven contract.

right?

Instead of always overriding onLinkPress, use useRoute() to detect when NotFoundPage is rendered as the SCREENS.NOT_FOUND screen and only then navigate to HOME. Other callers that render NotFoundPage inline keep their existing onLinkPress behavior. Co-authored-by: truph01 <truph01@users.noreply.github.com>

MelvinBot · 2026-03-18T11:41:47Z

Yes, exactly right! The conditional onLinkPress={isNotFoundScreen ? () => Navigation.goBack(ROUTES.HOME) : fullPageNotFoundViewProps.onLinkPress} resolves that concern — if a caller passes an explicit onLinkPress, it's preserved via fullPageNotFoundViewProps.onLinkPress; the HOME override only applies when we're actually on the SCREENS.NOT_FOUND screen.

I've pushed the implementation with:

useRoute() to detect route.name === SCREENS.NOT_FOUND
The conditional onLinkPress placed after the spread so it takes precedence over both the spread and the default

Rename isNotFoundScreen to isOnGenericErrorScreen to comply with the rulesdir/no-negated-variables ESLint rule. Co-authored-by: truph01 <truph01@users.noreply.github.com>

MelvinBot · 2026-03-18T11:49:38Z

Fixed the failing ESLint check: renamed isNotFoundScreen to isOnGenericErrorScreen to comply with the rulesdir/no-negated-variables lint rule (the word "Not" in the variable name triggered it).

trjExpensify

Makes sense with a page in the product now called.. Home

truph01 · 2026-03-18T20:06:37Z

@codex review

chatgpt-codex-connector · 2026-03-18T20:28:04Z

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions · 2026-03-19T00:57:50Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T01:02:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85526.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8176a9c-6d2fe73-68247c3c1afac5f7c5af029f798e46bfe8d34056/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8176a9c-6d2fe73-990920827ac298a57501cee58281e6f34379b818/index.html

Web 🕸️
https://85526.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-19T20:26:01Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-23T09:29:24Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned truph01 Mar 17, 2026

MelvinBot requested a review from a team March 17, 2026 10:35

MelvinBot mentioned this pull request Mar 17, 2026

[Due for payment 2026-03-30] [$250] Navigate to non-existing link - Inbox opens upon clicking on "Go back to home page" #85222

Open

7 tasks

MelvinBot marked this pull request as ready for review March 18, 2026 09:22

MelvinBot requested a review from a team as a code owner March 18, 2026 09:22

melvin-bot bot requested review from trjExpensify and truph01 and removed request for a team March 18, 2026 09:22

melvin-bot bot removed the request for review from a team March 18, 2026 09:23

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into claude-notFoundPageGo…

99d6c02

…BackToHome Co-authored-by: truph01 <truph01@users.noreply.github.com>

MelvinBot requested a review from a team as a code owner March 18, 2026 09:37

melvin-bot bot requested review from carlosmiceli and removed request for a team March 18, 2026 09:37

Rename negated variable to fix ESLint no-negated-variables rule

6c2a31c

Rename isNotFoundScreen to isOnGenericErrorScreen to comply with the rulesdir/no-negated-variables ESLint rule. Co-authored-by: truph01 <truph01@users.noreply.github.com>

trjExpensify approved these changes Mar 18, 2026

View reviewed changes

truph01 approved these changes Mar 18, 2026

View reviewed changes

carlosmiceli approved these changes Mar 19, 2026

View reviewed changes

carlosmiceli merged commit 8176a9c into main Mar 19, 2026
37 checks passed

carlosmiceli deleted the claude-notFoundPageGoBackToHome branch March 19, 2026 00:56

github-actions bot mentioned this pull request Mar 19, 2026

Investigate workflow job failing on main: test / test (job 8) #85720

Closed

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

Conversation

MelvinBot commented Mar 17, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 17, 2026

Uh oh!

truph01 commented Mar 17, 2026

Uh oh!

MelvinBot commented Mar 17, 2026

Uh oh!

truph01 commented Mar 18, 2026

Uh oh!

MelvinBot commented Mar 18, 2026

Uh oh!

melvin-bot bot commented Mar 18, 2026

Uh oh!

truph01 commented Mar 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

truph01 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Mar 18, 2026

Uh oh!

melvin-bot bot commented Mar 18, 2026

Uh oh!

MelvinBot commented Mar 18, 2026

Why goBackToHomeV2 is unnecessary

The current PR approach is the right one

If a broader fix is desired (separate PR)

Uh oh!

truph01 commented Mar 18, 2026

Uh oh!

truph01 commented Mar 18, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Mar 18, 2026

Uh oh!

MelvinBot commented Mar 18, 2026

Proposed Solution

1. Revert NotFoundPage.tsx

2. Create a wrapper component in AuthScreens.tsx

3. Use the wrapper in the screen registration

Why this works

Uh oh!

truph01 commented Mar 18, 2026

Uh oh!

MelvinBot commented Mar 18, 2026

Uh oh!

truph01 commented Mar 18, 2026

Uh oh!

MelvinBot commented Mar 18, 2026

Uh oh!

MelvinBot commented Mar 18, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Mar 18, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 18, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 19, 2026

Why `goBackToHomeV2` is unnecessary

1. Revert `NotFoundPage.tsx`

2. Create a wrapper component in `AuthScreens.tsx`