fix: Assignee avatar is inconsistent in task & assignee page#85539
fix: Assignee avatar is inconsistent in task & assignee page#85539dangrous merged 2 commits intoExpensify:mainfrom
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a030ad5f7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@dukenv0307 are you able to give this a look to keep the deploy moving? Thanks! |
|
on it now |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-03-18.at.18.44.35.mov |
|
The fix makes sense to me 👍 |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Not really a product priority though LGTM
|
🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.41-0 🚀
Bundle Size Analysis (Sentry): |
Regression from Expensify#85539. Three fixes: 1. Restore unconditional participant cleanup on success — moved participants:{[assigneeAccountID]: null} back outside the isOptimisticPersonalDetail conditional so BE response always takes precedence over optimistic data. 2. Guard failure data personal details deletion — only delete personal details on failure if isOptimisticPersonalDetail is true, preventing real users' data from being removed. 3. Remove duplicate isOptimisticReport:false success data entry. Fixes Expensify#85974
…k to prevent crash on task assignee change Fixes Expensify#85974. PR Expensify#85539 moved the participants cleanup into isOptimisticPersonalDetail conditional, but for existing users this check returns false, leaving stale participant data that causes the app to crash on Android.
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀
|
Explanation of Change
fix: Assignee avatar is inconsistent in task & assignee page
Fixed Issues
$ #85532
PROPOSAL:
Tests
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-03-17.at.20.39.08.mov