[No QA] fix: add span lifecycle cleanup for ManualNavigateToInboxTab by BartekObudzinski · Pull Request #85542 · Expensify/App

BartekObudzinski · 2026-03-17T14:05:38Z

Explanation of Change

ManualNavigateToInboxTab spans were leaking inflated durations (7-10% of all spans) due to two missing cleanup paths in SidebarLinksData:

useFocusEffect had an early return when hasHadFirstLayout was false, so it never registered a cleanup function. If the user navigated away before the first layout completed (rapid tab switching, navigation interruption), the orphaned span was never canceled.
There was no unmount cleanup, so if the component was destroyed before layout, the span stayed active indefinitely.

Fix:

Inverted the useFocusEffect condition so the blur cleanup (cancelSpan) is always returned, regardless of layout state. On focus, endSpan only runs if the first layout already happened (re-visit from freeze).
Added a useEffect unmount cleanup with a span identity guard: cancels the span only if layout never completed AND the active span matches the one captured at mount time. This avoids accidentally canceling a newer span started by a subsequent tab click. Pattern mirrors SPAN_NAVIGATE_TO_REPORTS in Search/index.tsx.
Moved pre-existing currentReportIDRef.current assignment into useEffect to resolve react-hooks/refs lint warning that was blocking commits to this file.

Fixed Issues

$ #77175
PROPOSAL:

Tests

Open the app on web (wide layout), click the Inbox tab, verify the chat list renders normally
Rapidly switch between tabs (Inbox → Home → Inbox → Search → Inbox), verify no console errors
On narrow layout, navigate to Inbox then immediately tap another tab before the list renders, verify no lingering span warnings in logs
Navigate to Inbox, wait for list to render, navigate away and back, verify span ends correctly on re-visit (useFocusEffect path)

Verify that no errors appear in the JS console

Offline tests

N/A - telemetry span cleanup only, no network behavior changes.

QA Steps

Same as Tests above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-03-17T14:38:26Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/pages/inbox/sidebar/SidebarLinksData.tsx	`80.64% <69.23%> (-5.07%)`	⬇️
... and 198 files with indirect coverage changes

melvin-bot · 2026-03-18T07:54:40Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c7a0502f6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-18T08:07:51Z

src/pages/inbox/sidebar/SidebarLinksData.tsx

+    useEffect(() => {
+        currentReportIDRef.current = currentReportID;
+    }, [currentReportID]);


Keep active report ref in sync during render

Updating currentReportIDRef in a passive useEffect introduces a stale-value window after currentReportID changes: isActiveReport() can still return the previous report until the effect runs. SidebarLinks uses this callback in showReportPage to suppress duplicate navigation on narrow layouts, so quick consecutive taps right after a report change can bypass that guard and trigger an unnecessary second navigation to the already-active report.

Useful? React with 👍 / 👎.

Thanks for the note. The project enforces a custom ESLint rule (react-hooks/refs) that disallows mutating refs during render, so useEffect is the required pattern here. The stale-value window is one render cycle at most, and isActiveReport is only called in response to user interaction (tap on a report row), which cannot physically happen within that window.

JS00001 · 2026-03-18T15:52:23Z

@rojiphil can you review please

rojiphil · 2026-03-18T16:00:31Z

@JS00001 Reviewing now

rojiphil · 2026-03-18T19:08:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

85542-android-hybrid-002.mp4

Android: mWeb Chrome

85542-mweb-chrome-001.mp4

iOS: HybridApp

Ran into build issues locally but I think it should be fine as android hybrid version is tested.

iOS: mWeb Safari

85542-mweb-safari-001.mp4

MacOS: Chrome / Safari

85542-web-chrome-001.mp4

rojiphil

@JS00001 Changes LGTM.
Over to you now. Thanks.

github-actions · 2026-03-19T11:26:22Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T11:30:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85542.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-52881d0-5a38169-ef2b4a4be314ad2c289f81e0206cbd3563730a20/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-52881d0-5a38169-20de3dd9585883ec30e922929d97b0436265a84e/index.html

Web 🕸️
https://85542.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-19T11:34:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-19T20:26:14Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-23T09:29:39Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: add span lifecycle cleanup for ManualNavigateToInboxTab

88acfc6

melvin-bot bot assigned BartekObudzinski Mar 17, 2026

fix: move ref update to useEffect to fix react-hooks/refs warning

5c7a050

BartekObudzinski changed the title ~~fix: add span lifecycle cleanup for ManualNavigateToInboxTab~~ [No QA] fix: add span lifecycle cleanup for ManualNavigateToInboxTab Mar 17, 2026

BartekObudzinski mentioned this pull request Mar 17, 2026

[Due for payment 2026-03-31] [Due for payment 2026-03-30] [Metrics] Improve ManualNavigateToInboxTab #77175

Open

BartekObudzinski marked this pull request as ready for review March 18, 2026 07:54

BartekObudzinski requested review from a team as code owners March 18, 2026 07:54

melvin-bot bot requested a review from rojiphil March 18, 2026 07:54

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 18, 2026 07:54

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

fix: update currentReportIDRef during render instead of useEffect

4024d68

JS00001 approved these changes Mar 18, 2026

View reviewed changes

rojiphil approved these changes Mar 18, 2026

View reviewed changes

melvin-bot bot requested a review from JS00001 March 18, 2026 19:09

JS00001 approved these changes Mar 19, 2026

View reviewed changes

JS00001 merged commit 52881d0 into Expensify:main Mar 19, 2026
35 of 39 checks passed

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

Conversation

BartekObudzinski commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Mar 18, 2026

Uh oh!

rojiphil commented Mar 18, 2026

Uh oh!

rojiphil commented Mar 18, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BartekObudzinski commented Mar 17, 2026 •

edited

Loading

codecov bot commented Mar 17, 2026 •

edited by github-actions bot

Loading