Skip to content

[NO QA] Composer Performance Improvements #85544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JS00001 merged 3 commits into from
Mar 17, 2026
Merged

[NO QA] Composer Performance Improvements #85544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07b350c
composer
JS00001 Mar 17, 2026
22c6118
dont parse text where its not needed
JS00001 Mar 17, 2026
4b89dba
add logic to containsOnlyEmojis as well
JS00001 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/Composer/implementation/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,13 @@ function Composer({
ref,
...props
}: ComposerProps) {
const textContainsOnlyEmojis = useMemo(() => containsOnlyEmojis(Parser.htmlToText(Parser.replace(value ?? ''))), [value]);
const textContainsOnlyEmojis = useMemo(() => {
if (!value) {
return false;
}
return containsOnlyEmojis(Parser.htmlToText(Parser.replace(value)));
}, [value]);

const theme = useTheme();
const styles = useThemeStyles();
const session = useSession();
Expand Down
4 changes: 4 additions & 0 deletions src/libs/EmojiUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ function isFirstLetterEmoji(message: string): boolean {
* Validates that this message contains only emojis
*/
function containsOnlyEmojis(message: string): boolean {
if (!message) {
return false;
}

const trimmedMessage = Str.replaceAll(message.replaceAll(' ', ''), '\n', '');
const match = trimmedMessage.match(CONST.REGEX.ALL_EMOJIS);

Expand Down
Loading