Update country and state when the draft is updated#85547
Update country and state when the draft is updated#85547arosiclair merged 1 commit intoExpensify:mainfrom
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
||
| if (prevStateDraft.current !== currentStateDraft) { | ||
| prevStateDraft.current = currentStateDraft; | ||
| setState(currentStateDraft); |
There was a problem hiding this comment.
I use the same approach we used in FormProvider. We need to update the local state here because we use it as the input value.
App/src/pages/MissingPersonalDetails/subPages/Address.tsx
Lines 165 to 188 in e149717
And FormProvider will show the value from value.
App/src/components/Form/FormProvider.tsx
Lines 333 to 334 in e149717
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeScreen.Recording.2026-03-18.at.17.10.57.moviOS: HybridAppiOS: mWeb SafariScreen.Recording.2026-03-18.at.17.12.06.movMacOS: Chrome / SafariScreen.Recording.2026-03-18.at.17.01.44.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.41-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀
|
Explanation of Change
Fixed Issues
$ #85331
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
For testing it easier, we can directly access the page by going to
staging.new.expensify.com/missing-personal-details/{any_number_here}PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4