Make header and footer components self-subscribe via reportID by adhorodyski · Pull Request #85550 · Expensify/App

adhorodyski · 2026-03-17T15:17:23Z

Explanation of Change

This PR moves 5 header/footer components from receiving full report and policy objects as props to self-subscribing via useOnyx with just a reportID. This is part of the ongoing decomposition of ReportScreen to reduce prop drilling and allow each component to own its own data dependencies.

Components updated:

HeaderView: removed report, parentReportAction, shouldUseNarrowLayout props — now self-subscribes via useOnyx + useParentReportAction + useResponsiveLayout
MoneyReportHeader: removed report, policy, reportActions, transactionThreadReportID, isLoadingInitialReportActions — now self-subscribes via useOnyx + usePaginatedReportActions + useReportTransactionsCollection
MoneyRequestHeader: removed report, policy, parentReportAction — now self-subscribes via useOnyx + useParentReportAction
ArchivedReportFooter: removed report, currentUserAccountID — now self-subscribes via useOnyx + useCurrentUserPersonalDetails
AnonymousReportFooter: removed report, isSmallSizeLayout — now self-subscribes and computes layout internally

Call sites updated: ReportScreen, MoneyRequestReportView, ReportFooter. Tests updated. Net result: 9 files changed, +72/-124 lines.

Fixed Issues

$ #84895
PROPOSAL:

Tests

Open any expense report → verify the header (MoneyReportHeader) renders correctly with title, amounts, and action buttons
Open a single money request (click into a transaction) → verify MoneyRequestHeader shows with the back button and correct details
Open the Concierge chat in the side panel → verify HeaderView shows with close button, no SidePanelButton
Open any regular chat → verify HeaderView shows with back button, SidePanelButton visible, onboarding banners if applicable
Archive a report (or open an existing archived one) → verify ArchivedReportFooter shows the "this report has been closed" message
Log out and open a public room link → verify AnonymousReportFooter shows the sign-in prompt with correct layout on both narrow and wide screens
Navigate between reports quickly (tap several in the LHN) → verify headers swap without flicker or stale data

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…y#84895) Convert 5 header/footer components from receiving full report/policy objects as props to self-subscribing via reportID: - HeaderView: subscribe to report via useOnyx, get parentReportAction via useParentReportAction, get shouldUseNarrowLayout from useResponsiveLayout - MoneyReportHeader: subscribe to report/policy/metadata via useOnyx, get reportActions via usePaginatedReportActions, compute transactionThreadReportID internally - MoneyRequestHeader: subscribe to report/policy via useOnyx, get parentReportAction via useParentReportAction - ArchivedReportFooter: subscribe to report via useOnyx, get currentUserAccountID from useCurrentUserPersonalDetails - AnonymousReportFooter: subscribe to report via useOnyx, compute isSmallSizeLayout internally using useResponsiveLayout and useWindowDimensions Update all call sites (ReportScreen, MoneyRequestReportView, ReportFooter) to pass reportID instead of full objects. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

melvin-bot · 2026-03-17T15:26:44Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-17T15:47:24Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
.../MoneyRequestReportView/MoneyRequestReportView.tsx	`0.00% <ø> (ø)`
src/pages/Search/SearchMoneyRequestReportPage.tsx	`0.00% <ø> (ø)`
src/pages/inbox/HeaderView.tsx	`97.80% <ø> (-0.03%)`	⬇️
src/pages/inbox/ReportScreen.tsx	`71.12% <ø> (ø)`
src/components/AnonymousReportFooter.tsx	`0.00% <0.00%> (ø)`
src/components/ArchivedReportFooter.tsx	`0.00% <0.00%> (ø)`
src/components/MoneyRequestHeader.tsx	`0.00% <0.00%> (ø)`
src/pages/inbox/report/ReportFooter.tsx	`53.70% <0.00%> (+0.13%)`	⬆️
src/components/MoneyReportHeader.tsx	`0.00% <0.00%> (ø)`
... and 5 files with indirect coverage changes

DylanDylann · 2026-03-18T07:18:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6c869dc7e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

src/components/MoneyReportHeader.tsx

src/components/MoneyRequestHeader.tsx

src/pages/inbox/HeaderView.tsx

src/components/MoneyReportHeader.tsx

DylanDylann · 2026-03-18T08:22:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-18.at.15.25.48.mov

Android: mWeb Chrome

Screen.Recording.2026-03-18.at.15.19.37.mov

iOS: HybridApp

Screen.Recording.2026-03-18.at.15.23.35.mov

iOS: mWeb Safari

Screen.Recording.2026-03-18.at.15.18.55.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-18.at.15.16.15.mov

DylanDylann · 2026-03-18T08:29:13Z

The rest looks fine to me

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Replace the local reportToUse memoization with a dedicated hydrateReportCurrencyFromSnapshot action so self-subscribing child components (e.g. MoneyReportHeader) can read the currency directly from Onyx. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…-footers

src/pages/Search/SearchMoneyRequestReportPage.tsx

… collections The Search API returns main Onyx collections alongside snapshot data, so by the time the user opens a search result, useOnyx already has the full report with currency. The snapshot fallback is unnecessary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

adhorodyski · 2026-03-20T14:43:06Z

@codex review

…-footers

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d8feb1357

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/pages/Search/SearchMoneyRequestReportPage.tsx

github-actions · 2026-03-20T15:21:36Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-20T15:25:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-20T15:25:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85550.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1094c93-fe6e12a-3794e7177f866b89660ee875e22e1cc6b33126a0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1094c93-fe6e12a-c2e4e52dd4c3b18d9aa456573fc568050ff894b6/index.html

Web 🕸️
https://85550.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-23T09:51:06Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.42-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

melvin-bot bot assigned adhorodyski Mar 17, 2026

adhorodyski changed the title ~~[No QA] Make header and footer components self-subscribe via reportID~~ Make header and footer components self-subscribe via reportID Mar 17, 2026

adhorodyski marked this pull request as ready for review March 17, 2026 15:26

adhorodyski requested review from a team as code owners March 17, 2026 15:26

melvin-bot bot requested review from DylanDylann and heyjennahay and removed request for a team March 17, 2026 15:26

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

src/components/MoneyRequestReportView/MoneyRequestReportView.tsx Show resolved Hide resolved

src/components/MoneyReportHeader.tsx Show resolved Hide resolved

DylanDylann reviewed Mar 18, 2026

View reviewed changes

src/components/MoneyRequestHeader.tsx Outdated Show resolved Hide resolved

src/pages/inbox/HeaderView.tsx Outdated Show resolved Hide resolved

src/components/MoneyReportHeader.tsx Outdated Show resolved Hide resolved

adhorodyski and others added 3 commits March 18, 2026 14:01

Remove noisy self-subscribe comments from header components

e0e72d6

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Merge branch 'Expensify:main' into decompose/self-subscribing-headers…

386cddc

…-footers

rlinoz previously approved these changes Mar 19, 2026

View reviewed changes

DylanDylann reviewed Mar 19, 2026

View reviewed changes

src/pages/Search/SearchMoneyRequestReportPage.tsx Outdated Show resolved Hide resolved

DylanDylann approved these changes Mar 19, 2026

View reviewed changes

melvin-bot bot requested a review from rlinoz March 19, 2026 17:45

adhorodyski changed the title ~~Make header and footer components self-subscribe via reportID~~ WIP Make header and footer components self-subscribe via reportID Mar 20, 2026

adhorodyski dismissed rlinoz’s stale review via d626b68 March 20, 2026 14:36

adhorodyski changed the title ~~WIP Make header and footer components self-subscribe via reportID~~ Make header and footer components self-subscribe via reportID Mar 20, 2026

Merge branch 'Expensify:main' into decompose/self-subscribing-headers…

5d8feb1

…-footers

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

src/pages/Search/SearchMoneyRequestReportPage.tsx Show resolved Hide resolved

rlinoz approved these changes Mar 20, 2026

View reviewed changes

rlinoz merged commit 1094c93 into Expensify:main Mar 20, 2026
31 checks passed

adhorodyski deleted the decompose/self-subscribing-headers-footers branch March 20, 2026 15:16

OSBotify mentioned this pull request Mar 23, 2026

Deploy Checklist: New Expensify 2026-03-23 #86080

Open

69 tasks

adhorodyski mentioned this pull request Mar 23, 2026

[WIP] decompose ReportScreen 5: self-subscribe List and Composer #86119

Draft

52 tasks

Conversation

adhorodyski commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 17, 2026

Uh oh!

codecov bot commented Mar 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DylanDylann commented Mar 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Mar 18, 2026

Uh oh!

Uh oh!

adhorodyski commented Mar 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

OSBotify commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adhorodyski commented Mar 17, 2026 •

edited

Loading

codecov bot commented Mar 17, 2026 •

edited by github-actions bot

Loading

DylanDylann commented Mar 18, 2026 •

edited

Loading