Fix Next button is unresponsive after going online on Manually add BA page#85559
Fix Next button is unresponsive after going online on Manually add BA page#85559JS00001 merged 5 commits intoExpensify:mainfrom
Conversation
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
This is ready for review! I'll prepare the screenshots/videos later today |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
trjExpensify
left a comment
There was a problem hiding this comment.
No qualms from the product with the bug fix to unstuck people here. 👍
|
Reviewing shortly |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid.movAndroid: mWeb ChromemChrome.moviOS: HybridAppIOS.moviOS: mWeb SafarimSafari.movMacOS: Chrome / SafariChrome.mov |
|
@layacat some of the CI isnt running, could you please pull main |
|
That's weird 😅 . Let me merge main. |
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.41-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀
|
Explanation of Change
We fix the race condition between 2 APIs (the main root cause). We should only call the
onReconnectwhen the current screen is focused.Fixed Issues
$ #82769
PROPOSAL: #82769 (comment)
Tests
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-03-18.at.23.17.12.mov
Android: mWeb Chrome
Screen.Recording.2026-03-18.at.23.17.12.mov
iOS: Native
Screen.Recording.2026-03-18.at.22.57.34.mov
iOS: mWeb Safari
Screen.Recording.2026-03-18.at.23.02.34.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-18.at.22.48.31.mov