Skip to content

[CP Staging] fix: reset error message when split expenses change #85561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakchote merged 2 commits into from
Mar 17, 2026
Merged

[CP Staging] fix: reset error message when split expenses change #85561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a60e7e7
fix: reset error message when split expenses change
kubabutkiewicz Mar 17, 2026
64cdcae
fix: update keyboard type handling in PercentageForm and SplitPercent…
kubabutkiewicz Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/PercentageForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function PercentageForm({value: amount, errorText, onInputChange, label, allowEx
textInput.current = newRef;
}}
suffixCharacter="%"
keyboardType={CONST.KEYBOARD_TYPE.DECIMAL_PAD}
keyboardType={rest.keyboardType ?? CONST.KEYBOARD_TYPE.DECIMAL_PAD}
// On android autoCapitalize="words" is necessary when keyboardType="decimal-pad" or inputMode="decimal" to prevent input lag.
// See https://github.com/Expensify/App/issues/51868 for more information
autoCapitalize="words"
Expand Down
2 changes: 2 additions & 0 deletions src/components/SelectionList/ListItem/SplitListItem/SplitPercentageInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import PercentageForm from '@components/PercentageForm';
import type {SplitListItemType} from '@components/SelectionList/ListItem/types';
import useStyleUtils from '@hooks/useStyleUtils';
import useThemeStyles from '@hooks/useThemeStyles';
import CONST from '@src/CONST';
import SplitPercentageDisplay from './SplitPercentageDisplay';

type SplitPercentageInputProps = {
Expand Down Expand Up @@ -50,6 +51,7 @@ function SplitPercentageInput({splitItem, contentWidth, percentageDraft, onSplit
allowExceedingHundred
allowDecimal
allowNegative
keyboardType={CONST.KEYBOARD_TYPE.NUMBERS_AND_PUNCTUATION}
/>
);
}
Expand Down
29 changes: 21 additions & 8 deletions src/pages/iou/SplitExpensePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {deepEqual} from 'fast-equals';
import React, {useMemo} from 'react';
import React, {useEffect, useMemo} from 'react';
import {InteractionManager, Keyboard, View} from 'react-native';
import type {ValueOf} from 'type-fest';
import FullPageNotFoundView from '@components/BlockingViews/FullPageNotFoundView';
Expand Down Expand Up @@ -138,6 +138,10 @@ function SplitExpensePage({route}: SplitExpensePageProps) {
const difference = sumOfSplitExpenses - transactionDetailsAmount;
const currencySymbol = getCurrencySymbol(transactionDetails.currency ?? '') ?? transactionDetails.currency ?? CONST.CURRENCY.USD;

useEffect(() => {
setErrorMessage('');
}, [splitExpenses.length]);

const isPerDiem = isPerDiemRequest(transaction);
const isDistance = isDistanceRequest(transaction);
const isCard = isManagedCardTransaction(transaction);
Expand Down Expand Up @@ -168,7 +172,6 @@ function SplitExpensePage({route}: SplitExpensePageProps) {
const currentTransactionViolations = transactionViolations?.[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`] ?? [];
const hasCustomUnitOutOfPolicyViolation = currentTransactionViolations.some((violation) => violation.name === CONST.VIOLATIONS.CUSTOM_UNIT_OUT_OF_POLICY);

const draftTransactionError = useMemo(() => getLatestErrorMessage(draftTransaction ?? {}), [draftTransaction]);
let isUnitRateIDOutOfPolicy = false;
for (const splitExpense of splitExpenses) {
const splitTransaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${getNonEmptyStringOnyxID(splitExpense.transactionID)}`] ?? transaction;
Expand All @@ -186,6 +189,18 @@ function SplitExpensePage({route}: SplitExpensePageProps) {
}
}

useEffect(() => {
const errorString = getLatestErrorMessage(draftTransaction ?? {});

if (errorString) {
setErrorMessage(errorString);
}
}, [draftTransaction, draftTransaction?.errors]);

useEffect(() => {
setErrorMessage('');
}, [sumOfSplitExpenses, splitExpenses]);

const onAddSplitExpense = () => {
if (draftTransaction?.errors) {
clearSplitTransactionDraftErrors(transactionID);
Expand Down Expand Up @@ -309,7 +324,6 @@ function SplitExpensePage({route}: SplitExpensePageProps) {
};

const onSplitExpenseValueChange = (id: string, value: number, mode: ValueOf<typeof CONST.TAB.SPLIT>) => {
setErrorMessage('');
if (mode === CONST.TAB.SPLIT.AMOUNT || mode === CONST.TAB.SPLIT.DATE) {
const amountInCents = convertToBackendAmount(value);
updateSplitExpenseAmountField(draftTransaction, id, amountInCents, currentPolicy);
Expand Down Expand Up @@ -394,7 +408,6 @@ function SplitExpensePage({route}: SplitExpensePageProps) {
</View>
);

const displayError = errorMessage || draftTransactionError;
let warningMessage = '';

if (invalidSplit && sumOfSplitExpenses !== transactionDetailsAmount) {
Expand All @@ -411,12 +424,12 @@ function SplitExpensePage({route}: SplitExpensePageProps) {

const footerContent = (
<View style={[styles.ph5, styles.pb5]}>
{(!!displayError || !!warningMessage) && (
{(!!errorMessage || !!warningMessage) && (
<FormHelpMessage
style={[styles.ph1, styles.mb2]}
isError={!!displayError}
isInfo={!displayError && !!warningMessage}
message={displayError || warningMessage}
isError={!!errorMessage}
isInfo={!errorMessage && !!warningMessage}
message={errorMessage || warningMessage}
/>
)}
<Button
Expand Down
Loading