[CP Staging] Fix the Search footer showing $0.00 by JakubKorytko · Pull Request #85566 · Expensify/App

JakubKorytko · 2026-03-17T16:26:04Z

Explanation of Change

This PR fixes the Search footer showing $0.00 when selecting expenses on the default "Expenses" search view. The footer total relied solely on groupAmount, which is only populated when shouldCalculateTotals=true. For the default Expenses search key this flag is false, so groupAmount is always undefined and the total falls back to 0. This adds a fallback to Math.abs(transaction.amount) and a defensive currency fallback to transaction.currency.

Fixed Issues

$ #85534
PROPOSAL: N/A

Tests

Open the app on a wide layout, go to Reports > Expenses.
Create a new manual expense (FAB > Create expense > Manual) with a known amount (e.g. $25.00).
After being navigated to the Expenses search view, select the newly created expense via checkbox.
Verify that the footer shows the correct expense amount ($25.00) instead of $0.00.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2026-03-17T16:26:13Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d8addf79c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-17T16:34:55Z

src/pages/Search/SearchPage.tsx

              }, 0)
            : metadata?.count;
-        const total = shouldUseClientTotal ? selectedTransactionItems.reduce((acc, transaction) => acc - (transaction.groupAmount ?? 0), 0) : metadata?.total;
+        const total = shouldUseClientTotal ? selectedTransactionItems.reduce((acc, transaction) => acc - (transaction.groupAmount ?? -Math.abs(transaction.amount)), 0) : metadata?.total;


Avoid summing mixed-currency amounts without conversion

When groupAmount is missing, this fallback adds Math.abs(transaction.amount) values directly, but amount is stored in each transaction’s original currency. In the default Expenses view (shouldCalculateTotals=false), selecting transactions with different currencies will now produce a mathematically invalid total and label it with a single currency (from metadata/first item), which misstates spend. The total should only be computed from a common-currency field (e.g., groupAmount) or guarded to same-currency selections.

Useful? React with 👍 / 👎.

That's a valid observation, but it's not a new problem introduced by this fix - the existing code already sums groupAmount values and labels the total with a single currency. When groupAmount is available, it's converted to the group/policy currency, so mixed currencies work. When it's missing (the bug case), the previous behavior was showing $0.00, which is strictly worse. This fix at least shows a correct total for the common single-currency case. A multi-currency guard could be a follow-up improvement but is outside the scope of this regression fix.

codecov · 2026-03-17T16:37:28Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/Search/SearchPage.tsx	`53.62% <0.00%> (ø)`
... and 21 files with indirect coverage changes

ShridharGoel · 2026-03-17T17:23:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-17.at.10.53.00.PM.mov

…-footer-0-00 [CP Staging] Fix the Search footer showing $0.00 (cherry picked from commit f74fdc0) (cherry-picked to staging by mountiny)

github-actions · 2026-03-17T21:08:09Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-17T21:28:06Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-03-17T21:45:26Z

@JakubKorytko CP was passed by QA team, comment

cc @mountiny

OSBotify · 2026-03-17T21:51:10Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Julesssss · 2026-03-17T23:32:55Z

Retrying failed builds

github-actions · 2026-03-17T23:38:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85566.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f74fdc0-aa5d43c-a532b358cfa7e75f8da92d160155d05c0674e0a5/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://85566.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-18T13:04:59Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:31:24Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:44:32Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:46:48Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T14:07:25Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-23T09:30:00Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: search footer showing bash.00 when groupAmount is unavailable

5d8addf

JakubKorytko requested review from a team as code owners March 17, 2026 16:26

melvin-bot bot assigned JakubKorytko Mar 17, 2026

melvin-bot bot requested review from JmillsExpensify and ShridharGoel and removed request for a team March 17, 2026 16:26

melvin-bot bot removed the request for review from a team March 17, 2026 16:26

JakubKorytko mentioned this pull request Mar 17, 2026

[Due for payment 2026-03-30] Reports - After creating expense and selecting expense, footer shows $0.00 #85534

Closed

7 tasks

chatgpt-codex-connector bot reviewed Mar 17, 2026

View reviewed changes

ShridharGoel approved these changes Mar 17, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny March 17, 2026 17:23

mountiny changed the title ~~Fix the Search footer showing $0.00~~ [CP Staging] Fix the Search footer showing $0.00 Mar 17, 2026

mountiny approved these changes Mar 17, 2026

View reviewed changes

mountiny merged commit f74fdc0 into Expensify:main Mar 17, 2026
38 of 40 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 17, 2026

github-actions bot mentioned this pull request Mar 17, 2026

Investigate workflow job failing on main: chooseDeployActions #85598

Closed

OSBotify mentioned this pull request Mar 17, 2026

Deploy Checklist: New Expensify 2026-03-17 #85529

Closed

75 tasks

This comment has been minimized.

Sign in to view

Conversation

JakubKorytko commented Mar 17, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

JakubKorytko Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ShridharGoel commented Mar 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

This comment has been minimized.

OSBotify commented Mar 17, 2026

Uh oh!

IuliiaHerets commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

Julesssss commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Mar 17, 2026 •

edited by github-actions bot

Loading