Skip to content

Fix suggested followup: preserve HTML formatting and fix response ordering#85592

Merged
marcochavezf merged 2 commits intomainfrom
marcochavezf/612990-fix-followup-optimistic-rendering
Mar 19, 2026
Merged

Fix suggested followup: preserve HTML formatting and fix response ordering#85592
marcochavezf merged 2 commits intomainfrom
marcochavezf/612990-fix-followup-optimistic-rendering

Conversation

@marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Mar 17, 2026 •
edited
Loading

Explanation of Change

Fixes three bugs with suggested followup button clicks:

Bug A — Collapsed formatting in optimistic Concierge response: parseFollowupsFromHtml() used DomUtils.textContent() to extract <followup-response> content, which strips all HTML tags. This caused the optimistic Concierge response to appear as plain text without formatting. Fixed by using dom-serializer's render() to preserve the inner HTML. Also added an isHTML parameter to buildOptimisticAddCommentReportAction so it skips getParsedComment() (markdown-to-HTML conversion) when the input is already HTML.

Bug B — Response appears before question: The Concierge response had no createdOffset, defaulting to 0 (same timestamp as the question). This caused a race where the response could render before the question. Fixed by adding createdOffset: 1 (1ms after the question) to ensure correct chronological ordering. The 4-second visual delay is handled separately by displayAfter in addOptimisticConciergeActionWithDelay.

Bug C — Followup Q&A leaks into clipboard copy: When copying a Concierge message that contains <followup-list> elements, the followup questions and answers were included in the clipboard text. Fixed by calling stripFollowupListFromHtml() in setClipboardMessage() (in ContextMenuActions.tsx) to remove followup content before it reaches the clipboard. This re-applies the clipboard stripping from the reverted PR 84452.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/612990

Tests

  1. Open a Concierge chat that has suggested followup buttons
  2. Click on a followup button that has a pre-generated response
  3. Verify the user's question appears first, followed by "Concierge is typing..." indicator
  4. After ~4 seconds, verify the Concierge response appears with proper HTML formatting (bold text, links, lists, etc. are preserved)
  5. Verify the Concierge response appears after the question (not before)
  6. Right-click on a Concierge message that has suggested followups and select "Copy"
  7. Paste into a text editor and verify the followup questions/answers are NOT included in the copied text
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline
  2. Click a suggested followup button
  3. Verify the optimistic question and response render correctly with proper ordering
  4. Go online and verify the actions sync properly

QA Steps

  1. Open a Concierge chat with suggested followup buttons
  2. Click a followup button with a pre-generated response
  3. Verify the response appears after the question with proper HTML formatting preserved
  4. Verify no console errors
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A - no UI changes, only logic fix for HTML preservation and timestamp ordering

Android: mWeb Chrome

N/A - no UI changes, only logic fix for HTML preservation and timestamp ordering

iOS: Native

N/A - no UI changes, only logic fix for HTML preservation and timestamp ordering

iOS: mWeb Safari

N/A - no UI changes, only logic fix for HTML preservation and timestamp ordering

MacOS: Chrome / Safari

N/A - no UI changes, only logic fix for HTML preservation and timestamp ordering

@marcochavezf @claude
Fix suggested followup button: preserve HTML formatting and fix respo…
9e54be5 
…nse ordering

Bug A: Use dom-serializer render() instead of DomUtils.textContent() to preserve
HTML formatting in followup responses. Add isHTML parameter to
buildOptimisticAddCommentReportAction to skip getParsedComment() when input
is already HTML.

Bug B: Add createdOffset: 1 to the Concierge response so its timestamp is 1ms
after the question, ensuring correct ordering. The visual typing delay is
handled separately by displayAfter in addOptimisticConciergeActionWithDelay.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@marcochavezf marcochavezf requested review from a team as code owners March 17, 2026 20:38
@melvin-bot melvin-bot bot requested review from dukenv0307 and removed request for a team March 17, 2026 20:38
@melvin-bot
Copy link

melvin-bot bot commented Mar 17, 2026

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from trjExpensify and removed request for a team March 17, 2026 20:38
@marcochavezf @claude
Strip followup-list from clipboard copy
e743524 
Use stripFollowupListFromHtml in setClipboardMessage so that
<followup-list> Q&A content is removed before copying to clipboard.
This re-applies the clipboard stripping from PR 84452 which was reverted.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
trjExpensify
trjExpensify reviewed Mar 18, 2026
View reviewed changes
Copy link
Contributor

@trjExpensify trjExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fixes for the conversional onboarding project! 👍

@dukenv0307
Copy link
Contributor

dukenv0307 commented Mar 19, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-03-19.at.09.57.35.mov
Android: mWeb Chrome
Screen.Recording.2026-03-19.at.09.47.34.mov
iOS: HybridApp
Screen.Recording.2026-03-19.at.09.54.58.mov
iOS: mWeb Safari
Screen.Recording.2026-03-19.at.09.37.53.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-19.at.09.30.24.mov

@melvin-bot melvin-bot bot requested a review from Gonals March 19, 2026 02:58
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot mentioned this pull request Mar 19, 2026
Open
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

🎯 @dukenv0307, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #85728.

@dukenv0307
Copy link
Contributor

dukenv0307 commented Mar 19, 2026

@marcochavezf We got the failed test, can you please take a look?

@marcochavezf marcochavezf merged commit 9afe97f into main Mar 19, 2026
40 of 43 checks passed
@marcochavezf marcochavezf deleted the marcochavezf/612990-fix-followup-optimistic-rendering branch March 19, 2026 22:57
@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

🚧 @marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85592.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9afe97f-c58bf3c-85a0504ac1e2c2261939f77ac30c28f0a9bcc461/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9afe97f-c58bf3c-55f68a5cf836d8a8634336d73ef8dcc8bec35925/index.html
Android iOS
Web 🕸️
https://85592.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify
Copy link
Contributor

OSBotify commented Mar 19, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 23, 2026
Open
69 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Mar 23, 2026

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.3.42-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trjExpensify trjExpensify trjExpensify left review comments

@Gonals Gonals Gonals approved these changes

+1 more reviewer

@dukenv0307 dukenv0307 dukenv0307 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marcochavezf marcochavezf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marcochavezf @dukenv0307 @OSBotify @trjExpensify @Gonals