Part 9 - Thread betas through navigateToAndOpenChildReport, toggleSubscribeToChildReport and explain.#85710
Conversation
…SubscribeToChildReport Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
| await waitForBatchedUpdates(); | ||
|
|
||
| Report.navigateToAndOpenChildReport(EXISTING_CHILD_REPORT, PARENT_REPORT_ACTION, PARENT_REPORT, TEST_USER_ACCOUNT_ID, INTRO_SELECTED); | ||
| Report.navigateToAndOpenChildReport(EXISTING_CHILD_REPORT, PARENT_REPORT_ACTION, PARENT_REPORT, TEST_USER_ACCOUNT_ID, INTRO_SELECTED, undefined); |
There was a problem hiding this comment.
@Krishna2323 Please add new test cases to cover new changes
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Part 8 is merged, it would be helpful if you can check this one and approve. I can open next PRs once this is merged. |
|
@Krishna2323 COuld you merge the new main? |
|
@DylanDylann done. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-03-19.at.20.15.46.mov |
|
@DylanDylann all done here, just need your approval 🙇🏻 |
tgolen
left a comment
There was a problem hiding this comment.
Yep, nice and simple. It feels like I've seen this PR 9 times already 😂
|
🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.42-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66417
PROPOSAL:
Tests
Same as QA steps
Verify that no errors appear in the JS console
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-03-19.02-25-47.mp4