Skip to content

[NoQA] Rename const that had a typo in its name #85713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuwenmemon merged 1 commit into from
Mar 19, 2026
+4 −5
Merged

[NoQA] Rename const that had a typo in its name #85713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,6 @@
"Tele",
"Teleproduction",
"testflight",
"THRESHHOLD",
"TIMATIC",
"Timothée",
"tnode",
Expand Down
2 changes: 1 addition & 1 deletion src/CONST/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8175,7 +8175,7 @@ const CONST = {
CUSTOM_FIELD_1: 'customField1',
CUSTOM_FIELD_2: 'customField2',
ROLE: 'role',
REPORT_THRESHHOLD: 'reportThreshold',
REPORT_THRESHOLD: 'reportThreshold',
APPROVE_TO_ALTERNATE: 'approveToAlternate',
SUBRATE: 'subRate',
AMOUNT: 'amount',
Expand Down
2 changes: 1 addition & 1 deletion src/components/ImportColumn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function findColumnName(header: string): string {
case 'reporttotal':
case 'reporttotalthreshold':
case 'approvallimit':
attribute = CONST.CSV_IMPORT_COLUMNS.REPORT_THRESHHOLD;
attribute = CONST.CSV_IMPORT_COLUMNS.REPORT_THRESHOLD;
break;

case 'alternate':
Expand Down
4 changes: 2 additions & 2 deletions src/pages/workspace/members/ImportedMembersPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function ImportedMembersPage({route}: ImportedMembersPageProps) {
{text: translate('common.forwardTo'), value: CONST.CSV_IMPORT_COLUMNS.APPROVE_TO},
{text: translate('workspace.common.customField1'), value: CONST.CSV_IMPORT_COLUMNS.CUSTOM_FIELD_1},
{text: translate('workspace.common.customField2'), value: CONST.CSV_IMPORT_COLUMNS.CUSTOM_FIELD_2},
{text: translate('common.approvalLimit'), value: CONST.CSV_IMPORT_COLUMNS.REPORT_THRESHHOLD},
{text: translate('common.approvalLimit'), value: CONST.CSV_IMPORT_COLUMNS.REPORT_THRESHOLD},
{text: translate('common.overLimitForwardTo'), value: CONST.CSV_IMPORT_COLUMNS.APPROVE_TO_ALTERNATE},
];

Expand Down Expand Up @@ -104,7 +104,7 @@ function ImportedMembersPage({route}: ImportedMembersPageProps) {
const membersForwardsToColumn = columns.findIndex((column) => column === CONST.CSV_IMPORT_COLUMNS.APPROVE_TO);
const membersCustomField1Column = columns.findIndex((column) => column === CONST.CSV_IMPORT_COLUMNS.CUSTOM_FIELD_1);
const membersCustomField2Column = columns.findIndex((column) => column === CONST.CSV_IMPORT_COLUMNS.CUSTOM_FIELD_2);
const membersApprovalLimitColumn = columns.findIndex((column) => column === CONST.CSV_IMPORT_COLUMNS.REPORT_THRESHHOLD);
const membersApprovalLimitColumn = columns.findIndex((column) => column === CONST.CSV_IMPORT_COLUMNS.REPORT_THRESHOLD);
const membersOverLimitForwardsToColumn = columns.findIndex((column) => column === CONST.CSV_IMPORT_COLUMNS.APPROVE_TO_ALTERNATE);
const membersSubmitsTo = membersSubmitsToColumn !== -1 ? spreadsheet?.data[membersSubmitsToColumn].map((submitsTo) => submitsTo) : [];
const membersForwardsTo = membersForwardsToColumn !== -1 ? spreadsheet?.data[membersForwardsToColumn].map((forwardsTo) => forwardsTo) : [];
Expand Down
Loading