Skip to content

[No QA] Update Duplicate-Workspace.md to add merchant rules #85724

Merged
RachCHopkins merged 3 commits intomainfrom
helpsite-update-merchant-rules-duplicate
Mar 20, 2026
Merged

[No QA] Update Duplicate-Workspace.md to add merchant rules #85724
RachCHopkins merged 3 commits intomainfrom
helpsite-update-merchant-rules-duplicate

Conversation

@stephanieelliott
Copy link
Contributor

Help site update for: #81364

@stephanieelliott stephanieelliott self-assigned this Mar 19, 2026
@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds Merchant rules as a new selectable option in the Duplicate Workspace feature list. The change is minimal (one line added, one line modified) and accurately reflects the UI label. There are two minor formatting issues worth addressing.

Scores Summary

  • Readability: 9/10 - The new list item integrates naturally into the existing bulleted list and is immediately scannable. Minor trailing-whitespace inconsistency noted below.
  • AI Readiness: 9/10 - The term Merchant rules matches the exact UI string from the codebase (src/languages/en.ts line 5675). No metadata updates are needed for this small addition.
  • Style Compliance: 8/10 - The label matches the UI exactly (confirmed in source code), but trailing whitespace formatting is inconsistent with surrounding list items.

Key Findings

Positive aspects:

  • The added term Merchant rules exactly matches the UI label in the product (merchantRules: Merchant rules in src/languages/en.ts), satisfying the HELPSITE_NAMING_CONVENTIONS.md requirement to use the exact text shown in the product UI and match capitalization exactly.
  • Placement in the list is correct -- it appears directly after Rules in the same order the duplicate workspace feature form presents these options (WorkspaceDuplicateSelectFeaturesForm.tsx).

Issues to address:

  1. Trailing whitespace inconsistency (formatting): Most list items in this section use trailing double spaces for Markdown line breaks (e.g., Tags, Taxes, Workflows, Distance Rates, Per Diem all have trailing double spaces). The diff removes the trailing spaces from the existing Rules line and the new Merchant rules line lacks them as well. While this does not affect rendered output in most Markdown processors (since these are list items, not inline text), it introduces inconsistency with the rest of the list. For consistency, both lines should either have the trailing spaces or all items should be normalized.

  2. Minor: Rules line modification was unintentional (whitespace-only change): The Rules line changed only by losing its trailing spaces. This appears to be an accidental edit rather than an intentional formatting change. If trailing spaces are being kept elsewhere, this should be restored.

Recommendations

  1. Restore trailing double spaces on Rules and add them to Merchant rules to match the formatting pattern of all other items in the list. Alternatively, remove trailing spaces from all items in a separate cleanup -- but do not mix conventions within the same list.
  2. No other changes needed. The content is accurate and well-placed.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Duplicate-Workspace.md -- One line added (Merchant rules), one line modified (trailing whitespace removed from Rules). Content is accurate; minor formatting inconsistency with trailing spaces.

This review assessed only the proposed changes in the diff, not unchanged portions of the file.

stephanieelliott and others added 2 commits March 18, 2026 18:03
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott stephanieelliott requested a review from a team March 19, 2026 04:04
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @RachCHopkins

@melvin-bot melvin-bot bot requested review from RachCHopkins and removed request for a team March 19, 2026 04:04
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

@RachCHopkins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions github-actions bot changed the title Update Duplicate-Workspace.md to add merchant rules [No QA] Update Duplicate-Workspace.md to add merchant rules Mar 19, 2026
@OSBotify
Copy link
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://468ac031.helpdot.pages.dev ⚡️

Updated articles:

@RachCHopkins
Copy link
Contributor

Phwoar, big update on this one! 😆

Copy link
Contributor

@RachCHopkins RachCHopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RachCHopkins RachCHopkins merged commit d9f8c64 into main Mar 20, 2026
14 checks passed
@RachCHopkins RachCHopkins deleted the helpsite-update-merchant-rules-duplicate branch March 20, 2026 05:33
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.3.42-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants