Web - Distance - Map only fills in small area when map is loading after edit#85731
Web - Distance - Map only fills in small area when map is loading after edit#85731rlinoz merged 4 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@thelullabyy Currently, the height of the loading container isn't similar to the loaded receipt. I think they should be the same/. cc @Expensify/design what do you think? Screen.Recording.2026-03-19.at.21.30.10.mov |
trjExpensify
left a comment
There was a problem hiding this comment.
Staightforward bug fix 👍
|
@dukenv0307 mind rephrasing? I'm not quite following your question. Can you explain it to me with screenshots please? Thanks! |
|
@shawnborton the aspect-ratio of the receipt is 1/1
but the aspect-ratio of the loading indicator isn't 1/1
Is it ok? |
Is this a generic loading indicator we use for all receipts? Or is it specific to map receipts, where we know it will be 1:1? |
For other receipts, the loading is displayed in the center of the whole view Screen_Recording_2026-03-25_at_13.57.32.1.mov |
|
@shawnborton can you please take a look? |
This makes sense, let's standardize on this behavior then. Thanks! |
|
It is fixed @dukenv0307 Screen.Recording.2026-04-03.at.15.30.47.1.mov |
|
@shawnborton can you please confirm the behavior above? Thanks
|
|
That looks good to me 👍 |
|
Looks good |
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-08.at.23.28.41.movAndroid: mWeb ChromeScreen.Recording.2026-04-08.at.17.13.26.moviOS: HybridAppScreen.Recording.2026-04-08.at.22.48.47.moviOS: mWeb SafariScreen.Recording.2026-04-08.at.16.36.10.movMacOS: Chrome / SafariScreen.Recording.2026-04-08.at.16.25.37.mov |
|
I had an issue while running Android, will test it again soon Update: I added a video for Android Native |
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.55-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The changes are a UI bug fix for how the distance expense map renders during loading/editing — specifically adjusting the map container's aspect ratio and resetting the loading state when the receipt source changes. These are purely visual/code-level fixes that don't affect any user-facing workflows, feature names, settings, or documentation-relevant behavior. |



Explanation of Change
Fixed Issues
$ #85584
$ #84903
PROPOSAL:
Tests
→ Map fills in the entire receipt area when map is loading.
Offline tests
QA Steps
→ Map fills in the entire receipt area when map is loading.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.1.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
Updating... (I faced a build issue with iOS)
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.4.mov