Fix NaN bankAccountID in VBBA flow after verify-account resume by c3024 · Pull Request #85733 · Expensify/App

c3024 · 2026-03-19T05:57:08Z

Explanation of Change

When an unvalidated user tries to connect a bank account to a workspace they are redirected to the validate account modal before removing the existing bank account details that sets the bankAccountID as 0. After validation, the flow resumes but removeExistingBankAccountDetails is not called and the bankAccountID remains unset and it becomes NaN and that is passed in the payload.

Before the fix:

Screen.Recording.2026-03-19.at.1.29.30.PM.mov

This PR fixes this by calling removeExistingBankAccountDetails after the account is validated.

After the fix:

Screen.Recording.2026-03-19.at.1.48.04.PM.mov

Defensive ?? CONST.DEFAULT_NUMBER_ID fallback and normalizing non-finite bankAccountIDs to CONST.DEFAULT_NUMBER_ID are also added as Melvin suggested here.

Fixed Issues

$ #85747
PROPOSAL: N/A

Tests

Logon with a new account.
Create a workspace
Navigate to workspace settings > Workflows > Add bank account > Log into your bank > Confirm > Complete the Plaid login flow
Open the Network tab.
After you are navigated to the Bank info page click on the Plaid Saving (or whichever account you selected on Plaid) > Next
Verify that the Payload for the ConnectBankAccountWithPlaid API request has the value 0 for bankAccountID.

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-19.at.1.48.04.PM.mov

Reset reimbursement bank account draft and bankAccountID when resuming manual or Plaid setup after validation so resumed flow matches direct validated entry and prevents undefined bankAccountID values.

codecov · 2026-03-19T06:39:21Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/ReimbursementAccountUtils.ts	`41.93% <100.00%> (+4.00%)`	⬆️
src/libs/actions/BankAccounts.ts	`8.37% <100.00%> (+4.37%)`	⬆️
...t/USD/BeneficialOwnerInfo/BeneficialOwnersStep.tsx	`0.00% <ø> (ø)`
...imbursementAccount/USD/BankInfo/subSteps/Plaid.tsx	`0.00% <0.00%> (ø)`
...bursementAccount/USD/BusinessInfo/BusinessInfo.tsx	`0.00% <0.00%> (ø)`
.../USD/CompleteVerification/CompleteVerification.tsx	`0.00% <0.00%> (ø)`
...nkAccount/components/BankAccountValidationForm.tsx	`0.00% <0.00%> (ø)`
...ccount/USD/Requestor/PersonalInfo/PersonalInfo.tsx	`0.00% <0.00%> (ø)`
...ementAccount/VerifiedBankAccountFlowEntryPoint.tsx	`0.00% <0.00%> (ø)`
...ges/ReimbursementAccount/USD/BankInfo/BankInfo.tsx	`0.00% <0.00%> (ø)`
... and 62 files with indirect coverage changes

c3024 · 2026-03-19T09:16:35Z

@MelvinBot implement the changes you suggested here in this PR.

MelvinBot · 2026-03-19T09:18:38Z

👋 I reviewed the suggested changes and here's exactly what needs to be implemented in this PR:

1. Add `?? CONST.DEFAULT_NUMBER_ID` fallback to three components

These three components use Number(reimbursementAccount?.achData?.bankAccountID) without a fallback, which produces NaN when bankAccountID is undefined:

src/pages/ReimbursementAccount/USD/BankInfo/BankInfo.tsx:54

- const bankAccountID = Number(reimbursementAccount?.achData?.bankAccountID);
+ const bankAccountID = Number(reimbursementAccount?.achData?.bankAccountID ?? CONST.DEFAULT_NUMBER_ID);

src/pages/ReimbursementAccount/USD/Requestor/PersonalInfo/PersonalInfo.tsx:40

- const bankAccountID = Number(reimbursementAccount?.achData?.bankAccountID);
+ const bankAccountID = Number(reimbursementAccount?.achData?.bankAccountID ?? CONST.DEFAULT_NUMBER_ID);

src/pages/ReimbursementAccount/USD/CompleteVerification/CompleteVerification.tsx:35

- Number(reimbursementAccount?.achData?.bankAccountID),
+ Number(reimbursementAccount?.achData?.bankAccountID ?? CONST.DEFAULT_NUMBER_ID),

This matches the pattern already used in BankAccountValidationForm.tsx:93, BeneficialOwnersStep.tsx:72, BusinessInfo.tsx:68, and Plaid.tsx:51.

2. Add defensive guard in `connectBankAccountWithPlaid` (BankAccounts.ts:256-270)

Normalize non-finite bankAccountID at the API boundary:

 function connectBankAccountWithPlaid(bankAccountID: number, selectedPlaidBankAccount: PlaidBankAccount, policyID: string) {
     const parameters: ConnectBankAccountParams = {
-        bankAccountID,
+        bankAccountID: Number.isFinite(bankAccountID) ? bankAccountID : CONST.DEFAULT_NUMBER_ID,

Apply the same guard to connectBankAccountManually at line 1162 as well, since it takes the same bankAccountID parameter from BankInfo.tsx.

⚠️ I can't push changes to this PR because I didn't open it and I'm not listed as an assignee. To have me make this fix, add me to the PR assignees and then retry your request.

c3024 · 2026-03-19T09:21:57Z

@MelvinBot You are an assignee now. Make the changes.

…ponents Add ?? CONST.DEFAULT_NUMBER_ID fallback to BankInfo, PersonalInfo, and CompleteVerification to prevent NaN when achData.bankAccountID is undefined. Also add Number.isFinite guard in connectBankAccountWithPlaid and connectBankAccountManually as a defensive API boundary check. Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>

MelvinBot · 2026-03-19T09:27:52Z

I've pushed the changes from the proposal. Here's what was added:

?? CONST.DEFAULT_NUMBER_ID fallback in three components to prevent NaN when achData.bankAccountID is undefined:
- BankInfo.tsx:54
- PersonalInfo.tsx:40
- CompleteVerification.tsx:35
Number.isFinite() defensive guard at the API boundary in:
- connectBankAccountWithPlaid (BankAccounts.ts:258)
- connectBankAccountManually (BankAccounts.ts:1164)

These match the existing pattern used in BankAccountValidationForm.tsx, BeneficialOwnersStep.tsx, BusinessInfo.tsx, and Plaid.tsx.

c3024 · 2026-03-19T09:54:42Z

@MelvinBot a check is failing

Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>

MelvinBot · 2026-03-19T09:58:36Z

Fixed the failing "Changed files ESLint check". The errors were pre-existing issues in files this PR touched:

BankInfo.tsx — Added // eslint-disable-next-line @typescript-eslint/no-deprecated for the useSubStep call (matches the pattern already in CompleteVerification.tsx:46)
BankInfo.tsx — Added // eslint-disable-next-line react-hooks/set-state-in-effect for the setRedirectedFromPlaidToManual call inside the useEffect
PersonalInfo.tsx — Added // eslint-disable-next-line @typescript-eslint/no-deprecated for the useSubStep call

c3024 · 2026-03-19T10:03:30Z

@MelvinBot How complex are each of these to fix in this PR to avoid overriding linter?

MelvinBot · 2026-03-19T10:07:01Z

Here's a complexity breakdown of the three lint suppressions:

1. `@typescript-eslint/no-deprecated` for `useSubStep` in BankInfo.tsx

2. `@typescript-eslint/no-deprecated` for `useSubStep` in PersonalInfo.tsx

Complexity: High — out of scope for this PR.

useSubStep is deprecated in favor of useSubPage, which uses URL-based navigation (?subPage=&action=edit params) instead of in-memory useState index. The migration is tracked in #79039. All 5 USD step components still use useSubStep, and zero components in the ReimbursementAccount/ tree have migrated yet. Migrating requires:

Defining new navigation routes with subPage?/action? params
Replacing the bodyContent array of components with named {pageName, component} entries
Swapping nextScreen/prevScreen/moveTo calls for Navigation.navigate() / Navigation.goBack()
Updating InteractiveStepWrapper to InteractiveStepSubPageHeader

This is a feature-level refactor, not something to bundle into a bug fix PR.

Recommendation: Keep the eslint-disable comments. These match the existing pattern in CompleteVerification.tsx:46 and other files — the entire USD flow will be migrated together under #79039.

3. `react-hooks/set-state-in-effect` for `setRedirectedFromPlaidToManual` in BankInfo.tsx

Complexity: Very low — easy fix, ~2 lines changed.

redirectedFromPlaidToManual is never rendered in JSX — it's purely a "fire once" sentinel that prevents the Plaid-to-Manual redirect from re-triggering. Since it doesn't affect rendering, it's a textbook useRef candidate:

- const [redirectedFromPlaidToManual, setRedirectedFromPlaidToManual] = React.useState(false);
+ const redirectedFromPlaidToManualRef = React.useRef(false);

And in the useEffect:

  useEffect(() => {
-     if (redirectedFromPlaidToManual) {
+     if (redirectedFromPlaidToManualRef.current) {
          return;
      }
-     if (setupType === CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL && values.bankName !== '' && !redirectedFromPlaidToManual) {
-         // eslint-disable-next-line react-hooks/set-state-in-effect
-         setRedirectedFromPlaidToManual(true);
+     if (setupType === CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL && values.bankName !== '') {
+         redirectedFromPlaidToManualRef.current = true;
      }
- }, [redirectedFromPlaidToManual, setupType, values.bankName]);
+ }, [setupType, values.bankName]);

Writing to a ref doesn't trigger a re-render, so the lint violation goes away and there's a minor perf improvement (one fewer re-render cycle). The NonUSD BankInfo.tsx already uses this exact useRef sentinel pattern.

Recommendation: Worth fixing properly in this PR — it's a clean swap with no behavioral change.

c3024 · 2026-03-19T10:11:04Z

Ok, fix this

react-hooks/set-state-in-effect for setRedirectedFromPlaidToManual in BankInfo.tsx

and then fix the prettier workflow check too.

c3024 · 2026-03-19T10:27:47Z

@MelvinBot Ok, fix this

react-hooks/set-state-in-effect for setRedirectedFromPlaidToManual in BankInfo.tsx

and then fix the prettier workflow check too.

Replace useState with useRef for redirectedFromPlaidToManual in BankInfo.tsx since the value is only used as a guard inside useEffect and never used for rendering. Fix eslint-disable comment indentation in PersonalInfo.tsx. Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>

MelvinBot · 2026-03-19T10:33:13Z

Fixed both issues:

react-hooks/set-state-in-effect in BankInfo.tsx — Replaced useState with useRef for redirectedFromPlaidToManual since the value is only used as a guard inside the useEffect and never used for rendering. This eliminates the lint violation and avoids an unnecessary re-render.
Prettier formatting in PersonalInfo.tsx — Fixed indentation of the eslint-disable-next-line comment inside the destructuring block (4 → 8 spaces to match surrounding properties).

c3024 · 2026-03-19T10:44:55Z

@MelvinBot Jest tests are failing.

MelvinBot · 2026-03-19T10:46:57Z

The failing Jest test is unrelated to this PR's changes.

Failing test: tests/unit/canEditFieldOfMoneyRequestTest.ts — 2 failures in the "move expense" suite (lines 215 and 231)

Why it's unrelated: This PR only modifies bank account/VBBA flow files (BankAccounts.ts, BankInfo.tsx, PersonalInfo.tsx, CompleteVerification.tsx, VerifiedBankAccountFlowEntryPoint.tsx). The failing test covers canEditFieldOfMoneyRequest logic which is an entirely different area.

Likely cause: The test file was recently updated on main (commit f714b7f), and this PR branch appears to be behind main. Merging main into this branch should resolve the failure.

c3024 · 2026-03-19T10:48:23Z

@MelvinBot merge main.

…ountid-main-only Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>

MelvinBot · 2026-03-19T10:54:00Z

Merged main into this branch.

melvin-bot · 2026-03-19T11:07:03Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NikkiWines

One small thing

src/libs/actions/BankAccounts.ts

ikevin127 · 2026-03-20T01:01:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-03-19.at.18.20.38.mov

src/pages/ReimbursementAccount/USD/BankInfo/BankInfo.tsx

src/libs/actions/BankAccounts.ts

ikevin127

🟢 LGTM

Only have 2 NAB comments (ref1, ref2), also shared my take on the CME concern here.

melvin-bot · 2026-03-20T01:46:08Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #85747 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

Normalize only NaN to DEFAULT_NUMBER_ID per review; avoid global isNaN coercion.

Centralize numeric bankAccountID resolution in ReimbursementAccountUtils and use it across USD reimbursement steps. Narrow useCallback deps to bankAccountID where submit read achData. Add unit tests with typed fixtures.

c3024 · 2026-03-20T14:25:23Z

Addressed all review comments!

…wnersStep Match other USD VBBA screens until useSubPage migration (Expensify#79039).

Place no-deprecated on line before useSubStep call; next-line only applies to following line.

NikkiWines

👍

github-actions · 2026-03-20T15:36:50Z

🚧 @NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-20T15:41:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85733.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3fb6cd9-9be7b50-c2e4e52dd4c3b18d9aa456573fc568050ff894b6/index.html
The QR code can't be generated, because the Android build failed

Web 🕸️
https://85733.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-20T15:44:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-23T09:51:42Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.3.42-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Align verified-account resume with clean bank setup state.

0fd0e34

Reset reimbursement bank account draft and bankAccountID when resuming manual or Plaid setup after validation so resumed flow matches direct validated entry and prevents undefined bankAccountID values.

melvin-bot bot assigned c3024 Mar 19, 2026

c3024 assigned MelvinBot and c3024 and unassigned c3024 Mar 19, 2026

c3024 changed the title ~~Align verified-account resume with clean bank setup state.~~ Fix NaN bankAccountID in VBBA flow after verify-account resume Mar 19, 2026

Add eslint-disable comments for pre-existing deprecation warnings

5076cbe

Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into vbba-verified-bankacc…

8eccdae

…ountid-main-only Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>

c3024 marked this pull request as ready for review March 19, 2026 11:06

c3024 requested review from a team as code owners March 19, 2026 11:06

melvin-bot bot requested a review from ikevin127 March 19, 2026 11:06

melvin-bot bot removed the request for review from a team March 19, 2026 11:07

melvin-bot bot requested review from JmillsExpensify and removed request for a team March 19, 2026 11:07

NikkiWines requested changes Mar 19, 2026

View reviewed changes

src/libs/actions/BankAccounts.ts Outdated Show resolved Hide resolved

ikevin127 reviewed Mar 20, 2026

View reviewed changes

src/pages/ReimbursementAccount/USD/BankInfo/BankInfo.tsx Outdated Show resolved Hide resolved

ikevin127 reviewed Mar 20, 2026

View reviewed changes

src/libs/actions/BankAccounts.ts Show resolved Hide resolved

ikevin127 approved these changes Mar 20, 2026

View reviewed changes

melvin-bot bot requested a review from arosiclair March 20, 2026 01:46

c3024 added 7 commits March 20, 2026 10:54

Add unit tests for non-finite bankAccountID in VBBA connect actions

f0b7b8d

Drop non-realistic Infinity cases from BankAccountsTest

913209c

Merge branch 'main' into vbba-verified-bankaccountid-main-only

2c36412

Use !Number.isNaN for bankAccountID in VBBA connect actions

9d303e8

Normalize only NaN to DEFAULT_NUMBER_ID per review; avoid global isNaN coercion.

Add getBankAccountIDAsNumber helper for USD VBBA flow

0c70f7d

Centralize numeric bankAccountID resolution in ReimbursementAccountUtils and use it across USD reimbursement steps. Narrow useCallback deps to bankAccountID where submit read achData. Add unit tests with typed fixtures.

cleanup comment

c28dcf1

cleanup comment

b82b7b6

c3024 requested a review from NikkiWines March 20, 2026 14:46

c3024 added 2 commits March 20, 2026 20:16

Suppress no-deprecated for useSubStep in BusinessInfo and BeneficialO…

832aaea

…wnersStep Match other USD VBBA screens until useSubPage migration (Expensify#79039).

Fix useSubStep eslint-disable placement for CI

d4b1e33

Place no-deprecated on line before useSubStep call; next-line only applies to following line.

NikkiWines approved these changes Mar 20, 2026

View reviewed changes

NikkiWines merged commit 3fb6cd9 into Expensify:main Mar 20, 2026
29 checks passed

github-actions bot mentioned this pull request Mar 20, 2026

Investigate workflow job failing on main: build (Debug, true) #85966

Closed

OSBotify mentioned this pull request Mar 23, 2026

Deploy Checklist: New Expensify 2026-03-23 #86080

Open

69 tasks

Conversation

c3024 commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 19, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

c3024 commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

1. Add ?? CONST.DEFAULT_NUMBER_ID fallback to three components

2. Add defensive guard in connectBankAccountWithPlaid (BankAccounts.ts:256-270)

Uh oh!

c3024 commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

c3024 commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

c3024 commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

1. @typescript-eslint/no-deprecated for useSubStep in BankInfo.tsx

2. @typescript-eslint/no-deprecated for useSubStep in PersonalInfo.tsx

3. react-hooks/set-state-in-effect for setRedirectedFromPlaidToManual in BankInfo.tsx

Uh oh!

c3024 commented Mar 19, 2026

Uh oh!

c3024 commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

c3024 commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

c3024 commented Mar 19, 2026

Uh oh!

MelvinBot commented Mar 19, 2026

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ikevin127 commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 20, 2026

Uh oh!

c3024 commented Mar 20, 2026

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

OSBotify commented Mar 20, 2026

Uh oh!

c3024 commented Mar 19, 2026 •

edited

Loading

codecov bot commented Mar 19, 2026 •

edited by github-actions bot

Loading

1. Add `?? CONST.DEFAULT_NUMBER_ID` fallback to three components

2. Add defensive guard in `connectBankAccountWithPlaid` (BankAccounts.ts:256-270)

1. `@typescript-eslint/no-deprecated` for `useSubStep` in BankInfo.tsx

2. `@typescript-eslint/no-deprecated` for `useSubStep` in PersonalInfo.tsx

3. `react-hooks/set-state-in-effect` for `setRedirectedFromPlaidToManual` in BankInfo.tsx

ikevin127 commented Mar 20, 2026 •

edited

Loading