[NoQA] fix: hide travel cards on workspace member details page#85735
Merged
rlinoz merged 4 commits intoExpensify:mainfrom Mar 20, 2026
Merged
[NoQA] fix: hide travel cards on workspace member details page#85735rlinoz merged 4 commits intoExpensify:mainfrom
rlinoz merged 4 commits intoExpensify:mainfrom
Conversation
melvin-bot
bot
requested review from
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
requested review from
trjExpensify
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // Filter out travel cards — they should not appear on the member profile page | ||
| // as they expose card-level controls and data not intended for workspace admin view. | ||
| const memberCards = workspaceCards | ||
| ? Object.values(workspaceCards).filter( |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
Travel card detection logic is duplicated across multiple locations in the codebase, each using a different combination of checks:
PaymentMethodList.tsx:316checks onlyfeedCountry === CONST.TRAVEL.PROGRAM_TRAVEL_USExpensifyCardPage/index.tsx:80checks onlynameValuePairs?.isTravelCardCardUtils.ts:1428checksisVirtual && isTravelCardTravelInvoicingUtils.ts:163checks onlyfeedCountry === CONST.TRAVEL.PROGRAM_TRAVEL_US- This PR checks both
!isTravelCard && feedCountry !== PROGRAM_TRAVEL_US
The inconsistency across these checks is a bug risk -- different parts of the app may disagree on what constitutes a "travel card." Extract a single canonical utility function in CardUtils.ts and reuse it everywhere:
// In src/libs/CardUtils.ts
function isTravelCard(card: Card): boolean {
return !!card.nameValuePairs?.isTravelCard || card.nameValuePairs?.feedCountry === CONST.TRAVEL.PROGRAM_TRAVEL_US;
}Then in this file:
const memberCards = workspaceCards
? Object.values(workspaceCards).filter(
(card) => card.accountID === accountID && !isTravelCard(card),
)
: [];Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
Author
There was a problem hiding this comment.
IMO each case described has a different rule for display depending on the component / logic flow. The one I just added applies to the WS Member Details Page. The only reason to extract the check to isTravelCard would be if we actually decide to use it in multiple flows.
@blimpich Let me know if you disagree 🙌
Contributor
There was a problem hiding this comment.
I don't think isTravelCard should be used. As per the design doc section 12.1, isTravelCard is a deprecated attribute that is from the old central card project. We should solely be relying on the feedCountry as the source of truth for this.
Contributor
Author
There was a problem hiding this comment.
Understood, removed the extra check ✅
This comment was marked as resolved.
This comment was marked as resolved.
…7-profileTravelCard
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
parasharrajat
approved these changes
Mar 19, 2026
Member
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
Contributor
Author
|
@blimpich Removed the |
trjExpensify
approved these changes
Mar 19, 2026
Contributor
trjExpensify
left a comment
trjExpensify
left a comment
There was a problem hiding this comment.
Travel Invoicing Project PR 👍
…7-profileTravelCard
blimpich
approved these changes
Mar 19, 2026
blimpich
approved these changes
Mar 19, 2026
Contributor
Author
|
@blimpich Maybe run a web-only adhoc build just to verify the fix on your side on the account with travel cards ? |
Contributor
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Working as expected! 
|
rlinoz
approved these changes
Mar 20, 2026
Contributor
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
69 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.42-0 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Problem: Travel cards were appearing on the workspace member profile page as regular e-cards, exposing card-level controls and sensitive data.
Solution: This fix updates the
memberCardsfilter inWorkspaceMemberDetailsPage.tsxto hide them.The filter uses two checks for complete coverage:
isTravelCard: The standard boolean flag for travel cards.feedCountry === CONST.TRAVEL.PROGRAM_TRAVEL_US: Specifically targets the Travel Invoicing program cards, ensuring all travel-related variants are caught even if the boolean flag isn't present in specific Onyx states.Fixed Issues
$ #85725
PROPOSAL:
Tests
Precondition: Ensure you have a workspace with at least one member who has both a regular Expensify Card (or Company Card) and a Travel related dard assigned (either
isTravelCardor Travel Invoicing program).Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-03-18.at.23.49.07.mov