[NoQA] fix: Downgrade Onyx to v3.0.45 to resolve deploy blockers [1/2] by chrispader · Pull Request #85766 · Expensify/App

chrispader · 2026-03-19T11:45:47Z

Explanation of Change

This is one of two PRs which revert recent Onyx bumps that cause deploy blockers related to issues with attachment/receipt upload

This reverts the Onyx bump from version 3.0.46 to 3.0.48.

Fixed Issues

$ #85755
$ #85669
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Open a report
Send an attachment
Make sure that the attachment is uploaded and there is no "No content" error

Open a report
Create an expense
Upload an image/PDF
Finish the expense
Make sure the expense is uploaded and the receipt preview is showing the receipt

Offline tests

QA Steps

Verify that no errors appear in the JS console

Open a report
Send an attachment
Make sure that the attachment is uploaded and there is no "No content" error

Open a report
Create an expense
Upload an image/PDF
Finish the expense
Make sure the expense is uploaded and the receipt preview is showing the receipt

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…obrynski/feat/bump-onyx-to-3.0.48" This reverts commit 04b4916, reversing changes made to fb4f0df.

github-actions · 2026-03-19T11:45:55Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2026-03-19T11:48:13Z

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2026-03-19T11:51:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

mountiny

Straight revert, this is only in main so we split the reverts in two

melvin-bot · 2026-03-19T11:52:43Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2026-03-19T11:53:08Z

Straight revert

github-actions · 2026-03-19T11:56:18Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T12:02:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85766.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-311ce97-5a38169-ef2b4a4be314ad2c289f81e0206cbd3563730a20/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-311ce97-5a38169-20de3dd9585883ec30e922929d97b0436265a84e/index.html

Web 🕸️
https://85766.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-19T12:04:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-19T20:27:29Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-23T09:31:21Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Revert "Merge pull request Expensify#85527 from callstack-internal/JK…

21a6b64

…obrynski/feat/bump-onyx-to-3.0.48" This reverts commit 04b4916, reversing changes made to fb4f0df.

melvin-bot bot assigned chrispader Mar 19, 2026

chrispader changed the title ~~revert: Onyx bump to version 3.0.48~~ fix: Downgrade Onyx to v3.0.45 to resolve deploy blockers [1/2] Mar 19, 2026

chrispader marked this pull request as ready for review March 19, 2026 11:47

chrispader requested review from a team as code owners March 19, 2026 11:47

melvin-bot bot requested review from JmillsExpensify and marcaaron and removed request for a team March 19, 2026 11:47

mountiny changed the title ~~fix: Downgrade Onyx to v3.0.45 to resolve deploy blockers [1/2]~~ [NoQA] fix: Downgrade Onyx to v3.0.45 to resolve deploy blockers [1/2] Mar 19, 2026

mountiny approved these changes Mar 19, 2026

View reviewed changes

mountiny merged commit 311ce97 into Expensify:main Mar 19, 2026
54 of 55 checks passed

melvin-bot bot added the Emergency label Mar 19, 2026

mountiny removed the Emergency label Mar 19, 2026

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

rafecolton mentioned this pull request Mar 20, 2026

Update react-native-onyx to include https://github.com/Expensify/react-native-onyx/pull/754 #85983

Merged

52 tasks

This was referenced Mar 23, 2026

[Due for payment 2026-03-30] Web - User receives an error message while scanning a receipt. The expense is not created. #85755

Closed

[Due for payment 2026-03-30] [$250] Expenses - Uploaded receipt is not displayed when create manual expense #85669

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] fix: Downgrade Onyx to v3.0.45 to resolve deploy blockers [1/2]#85766

[NoQA] fix: Downgrade Onyx to v3.0.45 to resolve deploy blockers [1/2]#85766
mountiny merged 1 commit intoExpensify:mainfrom
margelo:@chrispader/revert-onyx-bump-to-3.0.48

chrispader commented Mar 19, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

mountiny commented Mar 19, 2026

Uh oh!

mountiny left a comment

Uh oh!

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

mountiny commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chrispader commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

mountiny commented Mar 19, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Mar 19, 2026

Uh oh!

mountiny commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chrispader commented Mar 19, 2026 •

edited

Loading