Skip to content

Revert "Fix distance rate not selected after creating new rate from self DM" #85890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aldo-expensify merged 1 commit into from
Mar 20, 2026
+2 −1
Merged

Revert "Fix distance rate not selected after creating new rate from self DM" #85890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/MoneyRequestConfirmationList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,13 +709,14 @@ function MoneyRequestConfirmationList({
!isPolicyExpenseChat ||
!transactionID ||
!lastSelectedRate ||
isMovingTransactionFromTrackExpense ||
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allow self-DM submit flow to restore the chosen distance rate

In the track-expense → submit upgrade path, IOURequestStepUpgrade intentionally resets the draft rate to '-1' before navigating to the workspace-rate creation flow, and this effect is the only place that later replaces that placeholder with lastSelectedRate on the confirmation screen. Re-adding isMovingTransactionFromTrackExpense to the guard disables that recovery exactly for SUBMIT/SHARE/CATEGORIZE, so after creating a new distance rate from a self DM the draft can stay on the placeholder rate, MoneyRequestConfirmationList keeps formError === 'iou.error.invalidRate', and the user is blocked from confirming the expense.

Useful? React with 👍 / 👎.

!selectedParticipants.some((participant) => participant.policyID === policy?.id)
) {
return;
}

setCustomUnitRateID(transactionID, lastSelectedRate, transaction, policy);
}, [customUnitRateID, transactionID, lastSelectedRate, isDistanceRequest, isPolicyExpenseChat, transaction, policy, selectedParticipants]);
}, [customUnitRateID, transactionID, lastSelectedRate, isDistanceRequest, isPolicyExpenseChat, isMovingTransactionFromTrackExpense, transaction, policy, selectedParticipants]);

const splitParticipants = useMemo(() => {
if (!isTypeSplit) {
Expand Down
Loading