Fix distance rate auto-selection when submitting from Self DM to workspace by MelvinBot · Pull Request #85918 · Expensify/App

MelvinBot · 2026-03-20T09:02:05Z

Explanation of Change

PR #84850 removed the isMovingTransactionFromTrackExpense guard from the auto-rate-update useEffect in MoneyRequestConfirmationList.tsx to fix issue #82629 (new custom rates not being selected after upgrade flow). However, removing the guard entirely also affected the standard Self DM submission flow, causing it to auto-select the workspace's distance rate instead of showing the "Rate not valid for this workspace" error.

This PR adds a targeted guard that distinguishes between the two flows based on the sentinel value of customUnitRateID:

FAKE_P2P_ID (submit-from-Self-DM flow): The guard blocks the auto-rate-update effect, allowing the rate validation effect to correctly show the "Rate not valid" error.
'-1' (upgrade/new-rate-creation flow): The guard does NOT block, preserving the fix from PR Fix distance rate not selected after creating new rate from self DM #84850 for issue [Due for payment 2026-03-30] [$250] Distance - New rate is not selected after entering new rate when submitting distance from self DM #82629.

Fixed Issues

$ #85879
PROPOSAL: #85879 (comment)

Tests

Go to staging.new.expensify.com
Go to self DM
Create a manual distance expense
Click "Submit it to someone"
Select a workspace chat
Verify the confirm page shows "Rate not valid for this workspace. Please select an available rate from the workspace." error instead of auto-selecting the workspace distance rate

Verify that no errors appear in the JS console

Offline tests

N/A - This change only affects the rate selection logic on the confirmation page, which requires online access to fetch policy rates.

QA Steps

Go to self DM
Create a manual distance expense
Click "Submit it to someone"
Select a workspace chat
Verify the confirm page shows "Rate not valid for this workspace" error and does NOT auto-select the workspace distance rate
Additionally, verify the upgrade flow still works: create a new custom distance rate and confirm it gets auto-selected correctly (original fix from [Due for payment 2026-03-30] [$250] Distance - New rate is not selected after entering new rate when submitting distance from self DM #82629)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…space Add targeted guard to the auto-rate-update effect so that it blocks when isMovingTransactionFromTrackExpense is true AND customUnitRateID is FAKE_P2P_ID (submit-to-workspace flow), but allows when customUnitRateID is '-1' (upgrade/new-rate-creation flow). This preserves the fix from PR #84850 for issue #82629 while restoring the correct "Rate not valid" validation error for the Self DM submission flow. Co-authored-by: Joel Davies <jjcoffee@users.noreply.github.com>

MelvinBot · 2026-03-20T09:04:01Z

The failing check (build (developmentDebug, false)) is unrelated to this PR.

Analysis: The Android build fails with:

Could not read script '/home/runner/_work/App/App/node_modules/expo/scripts/autolinking.gradle' as it does not exist.

This is a build infrastructure / dependency issue — the expo autolinking script is missing from node_modules.

Evidence: This PR only modifies src/components/MoneyRequestConfirmationList.tsx, which has no relation to Android build tooling or Expo autolinking. The failure is in android/settings.gradle line 40 trying to read an Expo script that wasn't installed correctly.

Re-running the check or merging from main may resolve this if it's a transient CI issue.

codecov · 2026-03-20T09:25:53Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MoneyRequestConfirmationList.tsx	`61.89% <0.00%> (ø)`
... and 4 files with indirect coverage changes

MelvinBot · 2026-03-20T09:26:34Z

The failing checks are unrelated to this PR's changes.

Failing checks:

build (New Expensify Dev, DebugDevelopment, false) — iOS build
build (developmentDebug, false) — Android build (error: Could not read script 'node_modules/expo/scripts/autolinking.gradle' as it does not exist)

Why unrelated: This PR only modifies src/components/MoneyRequestConfirmationList.tsx. Both the iOS and Android Remote Build workflows are also failing on main with the same infrastructure errors. This is a CI environment issue, not caused by the code changes in this PR.

jjcoffee · 2026-03-20T10:22:20Z

@MelvinBot make this ready for review.

melvin-bot · 2026-03-20T10:23:40Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-03-20T10:23:40Z

PR has been marked as ready for review! 🚀

jjcoffee · 2026-03-20T10:24:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-app-regression-2026-03-20_12.41.12.mp4

Android: mWeb Chrome

android-chrome-regression-2026-03-20_12.47.58.mp4

iOS: HybridApp

ios-app-regression-2026-03-20_12.24.48.mp4

iOS: mWeb Safari

ios-safari-regression-2026-03-20_12.25.44.mp4

MacOS: Chrome / Safari

desktop-chrome-regression-2026-03-20_11.29.36.mp4

jjcoffee · 2026-03-20T10:24:45Z

@aimane-chnaif ignore the ping, this is a regression from my PR 🙏

aimane-chnaif · 2026-03-20T10:26:17Z

Is this PR needed? Original PR was reverted in #85890.
Or is this rework PR v2?

jjcoffee · 2026-03-20T10:51:32Z

@aimane-chnaif Yes, it's a fix PR.

jjcoffee · 2026-03-20T12:31:03Z

@MelvinBot please merge main.

MelvinBot · 2026-03-20T12:32:39Z

I was unable to merge main into this branch. The branch has only a single orphan commit (no shared history with main), which causes Git to treat this as "unrelated histories" — resulting in merge conflicts across 40+ files throughout the entire codebase.

The only file this PR actually changes is src/components/MoneyRequestConfirmationList.tsx. The simplest fix would be to recreate the branch from current main and re-apply the one-line change. Would you like me to do that (create a new branch from main and force-push to update this PR)?

jjcoffee · 2026-03-20T12:49:40Z

@MelvinBot That's weird, but yes go ahead with the suggested fix.

MelvinBot · 2026-03-20T12:53:53Z

Closed this PR and created a replacement with a proper branch based on main: #85942

The code change is identical. The old branch had orphan history (no shared commits with main) which made it unmergeable, and I'm unable to force-push to fix it. Please mark the new PR as "Ready for review" when ready.

MelvinBot assigned jjcoffee Mar 20, 2026

MelvinBot requested a review from a team March 20, 2026 09:02

MelvinBot mentioned this pull request Mar 20, 2026

Distance - Confirm page auto selects distance rate instead of showing "Rate not valid" #85879

Closed

7 tasks

MelvinBot marked this pull request as ready for review March 20, 2026 10:23

MelvinBot requested a review from a team as a code owner March 20, 2026 10:23

melvin-bot bot requested review from aimane-chnaif and removed request for a team March 20, 2026 10:23

melvin-bot bot requested review from JmillsExpensify and removed request for a team March 20, 2026 10:23

MelvinBot closed this Mar 20, 2026

MelvinBot mentioned this pull request Mar 20, 2026

Fix distance rate auto-selection when submitting from Self DM to workspace #85942

Open

52 tasks

Conversation

MelvinBot commented Mar 20, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 20, 2026

Uh oh!

codecov bot commented Mar 20, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MelvinBot commented Mar 20, 2026

Uh oh!

jjcoffee commented Mar 20, 2026

Uh oh!

melvin-bot bot commented Mar 20, 2026

Uh oh!

MelvinBot commented Mar 20, 2026

Uh oh!

jjcoffee commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Mar 20, 2026

Uh oh!

aimane-chnaif commented Mar 20, 2026

Uh oh!

jjcoffee commented Mar 20, 2026

Uh oh!

jjcoffee commented Mar 20, 2026

Uh oh!

MelvinBot commented Mar 20, 2026

Uh oh!

jjcoffee commented Mar 20, 2026

Uh oh!

MelvinBot commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Mar 20, 2026 •

edited by github-actions bot

Loading

jjcoffee commented Mar 20, 2026 •

edited

Loading