[ECUK in-app 3DS] Enable passkeys for 3DS challenges and show prompt before allowing user to close RHP#86002
Conversation
… decline the transaction before navigating away from 3DS challenge
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c337390a04
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…er approves transaction
|
Updated test steps to cover approval flow and attached a video of it |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
rafecolton
left a comment
There was a problem hiding this comment.
LGTM! Assigning a couple more reviewers, since I'm not sure what if any side-effects this would could cause.
Screen.Recording.2026-03-20.at.3.35.32.PM.mov
|
🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
I'm actually going to review after all - I wasn't sure about the optimistic data but it turns out that solves another bug (https://github.com/Expensify/Expensify/issues/614316) |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-03-20.at.3.35.32.PM.mov |
|
@rafecolton looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
rock build failure is unrelated |
|
🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rafecolton in version: 9.3.42-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
In AuthorizeTransactionPage, use
useBeforeRemoveto prompt the user to deny the transaction before allowing them to close the RHP. Also enables passkeys for AuthorizeTransaction scenario because this change only makes sense in browsers.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/613913
$ #79470
Tests
Clicking outside the RHP
Back button
Outcome screens do not show a prompt
Approve flow navigates as normal
Offline tests
N/A
QA Steps
Same as tests. Assign to @joekaufmanexpensify for QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Note that this PR is only relevant in desktop browsers
MacOS: Chrome / Safari
rhp.nav.guard.mp4
rhp.outcome.got.it.works.mp4
rhp.guard.approve.navigates.normally.mp4