Skip to content

Enable passkeys for PIN flows #86009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chuckdries merged 2 commits into from
Mar 21, 2026
+4 −4
Merged

Enable passkeys for PIN flows #86009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd81b60
Enable passkeys for PIN flows
rafecolton Mar 21, 2026
7dae0e1
Updates tests
rafecolton Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/MultifactorAuthentication/config/scenarios/ChangePIN.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const ChangePINSuccessScreen = createScreenWithDefaults(
* This scenario is used when a UK/EU cardholder changes the PIN of their physical card.
*/
export default {
allowedAuthenticationMethods: [CONST.MULTIFACTOR_AUTHENTICATION.TYPE.BIOMETRICS],
allowedAuthenticationMethods: [CONST.MULTIFACTOR_AUTHENTICATION.TYPE.BIOMETRICS, CONST.MULTIFACTOR_AUTHENTICATION.TYPE.PASSKEYS],
action: changePINForCard,
successScreen: <ChangePINSuccessScreen />,
defaultClientFailureScreen: <ClientFailureScreen />,
Expand Down
2 changes: 1 addition & 1 deletion src/components/MultifactorAuthentication/config/scenarios/RevealPIN.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const ServerFailureScreen = createScreenWithDefaults(
* - Authentication failure: Return SHOW_OUTCOME_SCREEN to show failure screen
*/
export default {
allowedAuthenticationMethods: [CONST.MULTIFACTOR_AUTHENTICATION.TYPE.BIOMETRICS],
allowedAuthenticationMethods: [CONST.MULTIFACTOR_AUTHENTICATION.TYPE.BIOMETRICS, CONST.MULTIFACTOR_AUTHENTICATION.TYPE.PASSKEYS],
action: revealPINForCard,
callback: async (isSuccessful, callbackInput, payload) => {
if (isSuccessful && isRevealPINPayload(payload)) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/MultifactorAuthentication/config/scenarios/SetPINOrderCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const ServerFailureScreen = createScreenWithDefaults(
* - Authentication failure: Return SHOW_OUTCOME_SCREEN to show failure screen
*/
export default {
allowedAuthenticationMethods: [CONST.MULTIFACTOR_AUTHENTICATION.TYPE.BIOMETRICS],
allowedAuthenticationMethods: [CONST.MULTIFACTOR_AUTHENTICATION.TYPE.BIOMETRICS, CONST.MULTIFACTOR_AUTHENTICATION.TYPE.PASSKEYS],
action: setPersonalDetailsAndShipExpensifyCardsWithPIN,

callback: async (isSuccessful, _callbackInput, payload) => {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/components/MultifactorAuthentication/config/scenarios/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ describe('MultifactorAuthentication Scenarios Config', () => {
const setPinScenario = config[CONST.MULTIFACTOR_AUTHENTICATION.SCENARIO.SET_PIN_ORDER_CARD];

expect(setPinScenario).toBeDefined();
expect(setPinScenario.allowedAuthenticationMethods).toStrictEqual([CONST.MULTIFACTOR_AUTHENTICATION.TYPE.BIOMETRICS]);
expect(setPinScenario.allowedAuthenticationMethods).toStrictEqual([CONST.MULTIFACTOR_AUTHENTICATION.TYPE.BIOMETRICS, CONST.MULTIFACTOR_AUTHENTICATION.TYPE.PASSKEYS]);
expect(setPinScenario.action).toBeDefined();
expect(setPinScenario.callback).toBeDefined();
expect(typeof setPinScenario.callback).toBe('function');
Expand Down
Loading