add policy to getForExpenseMovedFromSelfDM by dukenv0307 · Pull Request #86191 · Expensify/App

dukenv0307 · 2026-03-24T11:16:31Z

Explanation of Change

Fixed Issues

$ #66415
PROPOSAL:

Tests

Open any workspace expense report that you own
Edit the amount of an expense
In the report chat, verify the activity message reads "changed the amount to $X.XX (previously $Y.YY)"
Edit the description — verify "set the description to …" or "changed the description to … (previously …)"
Edit the category — verify "changed the category to … (previously …)"

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-24.at.18.26.32.mov

melvin-bot · 2026-03-24T11:30:18Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify · 2026-03-24T22:08:05Z

No product review needed

DylanDylann · 2026-03-30T08:54:32Z

src/libs/ModifiedExpenseMessage.ts

    translate: LocalizedTranslate;
    reportAction: OnyxEntry<ReportAction>;
-    policy?: OnyxEntry<Policy>;
+    policy: OnyxEntry<Policy>;


Policy is missing in some usages of the getReportName function

@DylanDylann What do you mean? In this PR, we just refactored getForExpenseMovedFromSelfDM

We need to ensure policy is passed to getForExpenseMovedFromSelfDM in all usages

The call chain is: getReportName → getForReportAction → getMovedFromOrToReportMessage → getForExpenseMovedFromSelfDM

If policy is missing in getReportName, it will also be missing in getForExpenseMovedFromSelfDM

@DylanDylann but we don't want to make policy required in getReportName here. We'll do it in another PR

DylanDylann · 2026-03-30T09:05:00Z

src/libs/ModifiedExpenseMessage.ts

        ? getPolicyExpenseChatName({report: rootParentReport})
        : buildReportNameFromParticipantNames({report: rootParentReport, currentUserAccountID});
-    const policyName = getPolicyName({report: rootParentReport, returnEmptyIfNotFound: true});
+    const policyName = getPolicyName({report: rootParentReport, returnEmptyIfNotFound: true, policy});


One more concern: how do we ensure the child report policy matches the root report policy?

It's obvious that the child report will have the same policy as the parent report

DylanDylann · 2026-04-01T05:45:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-04-01.at.12.48.57.mov

DylanDylann

LGTM

lakchote

LGTM

github-actions · 2026-04-01T16:34:08Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-01T16:38:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86191.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6342ca7-08e403c-cc771e996458bf1a4f5f897b556a9613d24c6e6b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6342ca7-08e403c-1157a8c435dc03f65751a6799bea0801f6bc9ff6/index.html

Web 🕸️
https://86191.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-02T20:19:50Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-02T20:21:28Z

No help site changes are required for this PR.

This PR is a purely internal code refactor — it passes a policy parameter through getForExpenseMovedFromSelfDM and getMovedFromOrToReportMessage instead of reading it from an Onyx.connect subscription. There are no changes to user-facing behavior, UI labels, workflows, or features. The help site docs under docs/articles/ don't document this level of implementation detail, so no updates are needed.

OSBotify · 2026-04-07T01:10:46Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.52-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

add policy to getForExpenseMovedFromSelfDM

b70e3b1

melvin-bot bot assigned dukenv0307 Mar 24, 2026

lint fix

2864f4c

dukenv0307 marked this pull request as ready for review March 24, 2026 11:30

dukenv0307 requested review from a team as code owners March 24, 2026 11:30

melvin-bot bot requested review from DylanDylann and joekaufmanexpensify and removed request for a team March 24, 2026 11:30

joekaufmanexpensify removed their request for review March 24, 2026 22:08

DylanDylann reviewed Mar 30, 2026

View reviewed changes

Merge branch 'main' into fix/66415-part-4

2d7435b

DylanDylann approved these changes Apr 1, 2026

View reviewed changes

melvin-bot bot requested a review from lakchote April 1, 2026 05:50

lakchote approved these changes Apr 1, 2026

View reviewed changes

lakchote merged commit 6342ca7 into Expensify:main Apr 1, 2026
32 of 34 checks passed

MelvinBot mentioned this pull request Apr 1, 2026

Show role-aware SmartScan failure message to non-submitters #86896

Open

51 tasks

OSBotify mentioned this pull request Apr 2, 2026

Deploy Checklist: New Expensify 2026-04-02 #86989

Closed

melvin-bot bot mentioned this pull request Apr 7, 2026

[Due for payment 2026-04-14] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY in src/libs/ReportUtils.ts #66415

Open

Conversation

dukenv0307 commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 24, 2026

Uh oh!

joekaufmanexpensify commented Mar 24, 2026

Uh oh!

DylanDylann Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

MelvinBot commented Apr 2, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dukenv0307 commented Mar 24, 2026 •

edited

Loading

DylanDylann commented Apr 1, 2026 •

edited

Loading